Re: BookKeeper repo has been moved into gitbox

2017-06-29 4:06 GMT+02:00 Jia Zhai : > Hi Sijie, > opened a ticket https://issues.apache.org/jira/browse/INFRA-14470 to only > "squash merge" > Thanks > > On Thu, Jun 29, 2017 at 5:17 AM, Sijie Guo wrote: > >> Hi Enrico, >> >> The gitbox is the readonly mirror of the github repo. The github repo i

[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

jiazhai commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-311847825 Seems there are conflict files. This is an automated message from the Apache Git

[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

jiazhai commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-311847825 Seems there is conflict files. This is an automated message from the Apache Git

[GitHub] bookkeeper issue #205: Issue 208: Improve ledger fence logic

Github user jiazhai commented on the issue: https://github.com/apache/bookkeeper/pull/205 Seems there is conflict files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: BookKeeper repo has been moved into gitbox

Hi Sijie, opened a ticket https://issues.apache.org/jira/browse/INFRA-14470 to only "squash merge" Thanks On Thu, Jun 29, 2017 at 5:17 AM, Sijie Guo wrote: > Hi Enrico, > > The gitbox is the readonly mirror of the github repo. The github repo is > the source of truth. So we should use the github

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#discussion_r124678337 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ##

[GitHub] reddycharan commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

reddycharan commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029 URL: https://github.com/apache/bookkeeper/pull/127#issuecomment-311815591 @sijie my bad, missed checking findbugs error after previous push. Fixed them now and it passed. Thanks. -

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067419#comment-16067419 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user reddycharan comm

[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/127 @sijie my bad, missed checking findbugs error after previous push. Fixed them now and it passed. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/198 marked this as a blocker for 4.5.0, since it seems to indicate some kind of reference leaking in current code base. --- If your project is set up for it, you can reply to this email and have you

[GitHub] sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/issues/198#issuecomment-311804836 marked this as a blocker for 4.5.0, since it seems to indicate some kind of reference

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067297#comment-16067297 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user sijie commented on

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311802299 fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change.

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] sijie commented on a change in pull request #213: Issue 212: change github PR template to adjust both issue# and jira#

sijie commented on a change in pull request #213: Issue 212: change github PR template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/pull/213#discussion_r124664720 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,15 +1,16 @@ Descriptions

[jira] [Commented] (BOOKKEEPER-974) make pushing a docker image as part of the release procedure

[ https://issues.apache.org/jira/browse/BOOKKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067288#comment-16067288 ] ASF GitHub Bot commented on BOOKKEEPER-974: --- Github user sijie commented on

[GitHub] bookkeeper issue #197: BOOKKEEPER-974: Add an official bookkeeper docker ima...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/197 @caiok any updates on this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] sijie commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-311800374 @caiok any updates on this pull request? This is an automated m

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r124664167 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067282#comment-16067282 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user sijie commented on

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 @eolivelli I will try to go through this again. /cc @merlimat for reviewing as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311799940 @eolivelli I will try to go through this again. /cc @merlimat for reviewing as well --

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067280#comment-16067280 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user sijie commented

[GitHub] sijie commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

sijie commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029 URL: https://github.com/apache/bookkeeper/pull/127#issuecomment-311799683 @reddycharan there is a findbugs error introduced in this pull request. Can you fix that? --

[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/127 @reddycharan there is a findbugs error introduced in this pull request. Can you fix that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067278#comment-16067278 ] ASF GitHub Bot commented on BOOKKEEPER-1098: Github user sijie commented

[GitHub] sijie commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

sijie commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#issuecomment-311799215 @athanatos yeah, I just changed the title for the correct jira number. ---

[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/193 @athanatos yeah, I just changed the title for the correct jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] athanatos commented on a change in pull request #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

athanatos commented on a change in pull request #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#discussion_r124662485 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/util/SubTreeCacheTest.java ##

[jira] [Commented] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067267#comment-16067267 ] ASF GitHub Bot commented on BOOKKEEPER-1098: Github user athanatos commen

[GitHub] athanatos commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

athanatos commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#issuecomment-311798072 @sijie Oops, I just noticed the comments. I guess you just changed the title? ---

[GitHub] bookkeeper issue #195: Update JMX documentation

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/195 @eolivelli I assume this should be go into 4.5.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Resolved] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1098. --- Resolution: Fixed Assignee: Samuel Just Fix Version/s: 4.5.0 > ZkUnderrep

[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...

Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/193 @sijie Oops, I just noticed the comments. I guess you just changed the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] sijie commented on issue #195: Update JMX documentation

sijie commented on issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195#issuecomment-311797998 @eolivelli I assume this should be go into 4.5.0 release? This is an automated message from t

[jira] [Commented] (BOOKKEEPER-1086) Ledger Recovery - Refactor PendingReadOp

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067265#comment-16067265 ] ASF GitHub Bot commented on BOOKKEEPER-1086: Github user sijie closed the

[GitHub] bookkeeper pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cac...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher

sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (BOOKKEEPER-753) Bookie should run garbage collection before startup when all directories became full

[ https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067258#comment-16067258 ] ASF GitHub Bot commented on BOOKKEEPER-753: --- Github user sijie commented on

[GitHub] bookkeeper issue #81: BOOKKEEPER-753: Bookie should run garbage collection b...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/81 @jvrao @reddycharan #190 is merged. let me know what is your thought of this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-311796693 @jvrao @reddycharan #190 is merged. let me know what is your thought of this pull requ

[jira] [Resolved] (BOOKKEEPER-1034) When all disks are full, start Bookie in RO mode if RO mode is enabled

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1034. --- Resolution: Fixed Fix Version/s: 4.5.0 Issue resolved by merging pull request 190

[jira] [Commented] (BOOKKEEPER-1034) When all disks are full, start Bookie in RO mode if RO mode is enabled

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067253#comment-16067253 ] ASF GitHub Bot commented on BOOKKEEPER-1034: Github user sijie closed the

[GitHub] sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull URL: https://github.com/apache/bookkeeper/pull/190 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] bookkeeper pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskf...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: BookKeeper repo has been moved into gitbox

Hi Enrico, The gitbox is the readonly mirror of the github repo. The github repo is the source of truth. So we should use the github repo for jenkins build and also for patch submissions. The merge script uses 'apache' remote as the destination for pushing the squashed changes and uses 'apache-gi

[GitHub] bookkeeper pull request #215: Issue 216: Remove useless and misleading '&= t...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] bookkeeper issue #216: Remove useless and misleading '&= true'

Github user sijie closed the issue at: https://github.com/apache/bookkeeper/issues/216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true'

sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/pull/215 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] sijie closed issue #216: Remove useless and misleading '&= true'

sijie closed issue #216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/issues/216 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

Re: BookKeeper repo has been moved into gitbox

Enrico, Jia, I have confirmed that I have the permission on creating label/milestones and also I see the 'merge button' in the pull requests as well. Following the BP-9, I have created corresponding labels and milestones for 4.5.0 and 4.6.0. Let me know if they look good to you. For the 'merge b

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067060#comment-16067060 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311757496 @jvrao I am fine with having a configuration setting as what I said before. The comments are mostly for people knowing different as

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao I am fine with having a configuration setting as what I said before. The comments are mostly for people knowing different aspects on the solutions. --- If your project is set up fo

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066823#comment-16066823 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311716056 Multiple entrylog change is coming in and Charan is using this for that. So you can think of this as setting stage for that. If you

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 Multiple entrylog change is coming in and Charan is using this for that. So you can think of this as setting stage for that. If you don't want to have the flag/configuration parameter we can

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311713578 >> re 1. I am not aware if they are users configuring in this way. but I am not sure if this is the case for flagging as error. be

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066813#comment-16066813 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 >> re 1. I am not aware if they are users configuring in this way. but I am not sure if this is the case for flagging as error. because in current implementation, such configuration doesn'

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066794#comment-16066794 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user sijie commented

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/210 @jvrao do you mind sending out your proposal. we might need to merge the efforts here, and also @eolivelli has some ideas on how to implement this with standard servlets. --- If your project is s

[GitHub] sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-311709678 @jvrao do you mind sending out your proposal. we might need to merge the efforts here, and also @eolivelli has some ideas on how to implem

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311708998 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a po

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311708998 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a po

[GitHub] bookkeeper issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/200 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a policy will make things easier and we don't have to duplicate the co

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#discussion_r124584618 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ##

Re: BookKeeper repo has been moved into gitbox

I think the GitBox change is related to BP-9: Using Github Issues. Gitbox is the solution provided by ASF to managing Github repos, linking the Github accounts with Apache counts. Before this, the bookkeeper repo was setup with dural-sync, when the source-of-truth is the git-wp-us.apache.org/repos

[GitHub] bookkeeper issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/200 @sijie what is the major drive of this change? Current method of trying speculative reads has any major flaw? I understand this is better organized as speculative reads has its own policy, but tryi

[GitHub] jvrao commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

jvrao commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311673084 @sijie what is the major drive of this change? Current method of trying speculative reads has any major flaw? I understand this is

[GitHub] jvrao commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

jvrao commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#discussion_r124549893 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java ##

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311665630 @sijie @reddycharan Let me step back and discuss this. 1. Are there any legitimate use cases of specifying multiple ledger dirs on

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066501#comment-16066501 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 @sijie @reddycharan Let me step back and discuss this. 1. Are there any legitimate use cases of specifying multiple ledger dirs on the same disk partition? if not, in production I would lik

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066479#comment-16066479 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user jvrao commented

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/210 We are adding REST endpoint to BookKeeper. I need to check if they overlap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jvrao commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

jvrao commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-311660233 We are adding REST endpoint to BookKeeper. I need to check if they overlap.

Build failed in Jenkins: bookkeeper-master #1799

See -- [...truncated 1.03 MB...] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.433 sec - in org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementT

Re: Write retry issues with ZooKeeperClient

Current retry logic is transparent to the type of the operation and is down the stack which has no understanding of the operation type. If we want to differentiate between idempotent and non-idempotent, we may need to insert that logic into the retry logic. Other option is to handle retry at higher

Re: BookKeeper repo has been moved into gitbox

JV, GitHub at the moment is only a mirror for the official Git repo. When committing we must push to gitbox now For clones/readonly work/pull requests we are using GitHub as before -- Enrico 2017-06-28 15:18 GMT+02:00 Venkateswara Rao Jujjuri : > What is this change about? Can we still access and

Re: BookKeeper repo has been moved into gitbox

What is this change about? Can we still access and use https://github.com/apache/bookkeeper.git ? On Wed, Jun 28, 2017 at 5:53 AM, Enrico Olivelli wrote: > Jia, > I already did it. > I'm not aware of other places to change the link to the repo. > Do you have other ideas for the switch ? > Cheers

Re: BookKeeper repo has been moved into gitbox

Jia, I already did it. I'm not aware of other places to change the link to the repo. Do you have other ideas for the switch ? Cheers -- Enrico 2017-06-28 14:51 GMT+02:00 Jia Zhai : > Thanks Enrico for the confirm. Yes, we may need some changes, especially > the repo address. > > On Wed, Jun 28, 2

Re: BookKeeper repo has been moved into gitbox

Thanks Enrico for the confirm. Yes, we may need some changes, especially the repo address. On Wed, Jun 28, 2017 at 8:07 PM, Enrico Olivelli wrote: > I am going on with trials in order to discover our new space before > hitting bad problems. > > If you try to access the old git repo you will get

Build failed in Jenkins: bookkeeper-master #1798

See -- [...truncated 1.02 MB...] Running org.apache.bookkeeper.test.LedgerCreateDeleteTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.559 sec - in org.apache.book

Re: BookKeeper repo has been moved into gitbox

I am going on with trials in order to discover our new space before hitting bad problems. If you try to access the old git repo you will get [enrico.olivelli@localhost bookkeeper]$ git pull apache master fatal: repository 'https://git-wip-us.apache.org/repos/asf/bookkeeper.git/' not found As the

Re: BookKeeper repo has been moved into gitbox

This is great it seems that we have also a GitHub team for bookkeeper committers https://github.com/orgs/apache/teams/bookkeeper-committers/members -- Enrico 2017-06-28 12:29 GMT+02:00 Enrico Olivelli : > Hi Jia, > this is a very important change !! > > Do you now what will happen if any committ

Re: BookKeeper repo has been moved into gitbox

Hi Jia, this is a very important change !! Do you now what will happen if any committers uses git-ws-us.apache.org as usual ? is there any chance to break things ? we should immediately update the wiki page https://cwiki.apache.org/confluence/display/BOOKKEEPER/Patch+Sumission let's wait for Sij

BookKeeper repo has been moved into gitbox

Hi All, Thanks to the help from INFRA team, now bookkeeper repo has been moved into gitbox. The new URL (on our side) is https://gitbox.apache.org/repos/asf/bookkeeper.git For committers, please go through the setup at https://gitbox.apache.org/setup/ Thanks.

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066090#comment-16066090 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user sijie commented

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/210 regarding the servlet, I agree with @eolivelli , we probably should define a standard API and allow it running with different web container. @yzang : do finagle and vertx support servlet? --- If

Re: Write retry issues with ZooKeeperClient

On Tue, Jun 27, 2017 at 4:27 PM, Sam Just wrote: > Should EXPIRED be considered a recoverable error for retry purposes? > Retrying in that case would mean that operations which might have been > submitted under the assumption that ephemeral nodes were still present > would be retried after the ep

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066056#comment-16066056 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao @reddycharan one more question, most of the comments are around the performance on journal directories. but it turns out this change has nothing to do with the journal directories.

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066032#comment-16066032 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao yes, that's the idea. I am +0 on this. It is fine for me to adding an option, although I still don't think it is the right approach to do this. --- If your project is set up for i