[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066813#comment-16066813
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1033:
--------------------------------------------

Github user sijie commented on the issue:

    https://github.com/apache/bookkeeper/pull/189
  
    >> re 1.
    
    I am not aware if they are users configuring in this way. but I am not sure 
if this is the case for flagging as error. because in current implementation, 
such configuration doesn't have any performance impacts. if this flag is 
necessarily for multiple entry log files, I would defer adding this flag when 
reviewing the multiple-active-entry-log-files change. because it is not very 
clear about the problem and benefits.
    
    >> re 2>
    
    this sounds like a policy problem - how to choose the directory to place 
the entry log files to achieve balance between disk partitions? currently 
bookie asks the ledgerdirs manager for a ledger directory. the ledger disks can 
do a better job for balancing the placement of entry log files.
    
    >> re 3.
    
    if we have a policy abstraction in LedgerDirsManager, we can have a better 
policy on how to pick up the entry log files for write. in this way, we can 
balance the disk usage and I/O usage.
    
    I am seeing a trend of adding more and more configuration settings into the 
bookies. some are strongly required. some doesn't seem to be really needed. In 
this pull request, the configuration doesn't seem to be the right solution that 
address the problems that you guys are listing. it seems to be me a flag to 
mask the underneath problems and this flag will most likely be used anymore 
when we have the correct solution in place.


> Handle DirsPartitionDuplication
> -------------------------------
>
>                 Key: BOOKKEEPER-1033
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1033
>             Project: Bookkeeper
>          Issue Type: New Feature
>            Reporter: Charan Reddy Guttapalem
>            Assignee: Charan Reddy Guttapalem
>
> - Provide configuration for allowDirsPartitionDuplication
> - while calculating total disk metrics account Partition Duplication



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to