Re: CompactionTest tests are broken because of BOOKKEEPER-1088 change

I found the problem. I think it is a merge issue. there were two same lines merged. sending a pull request out now. - Sijie On Fri, Jun 9, 2017 at 7:02 PM, Sijie Guo wrote: > Yes, I am working on it. Enrico pointed it out earlier. > > Sijie > > On Jun 9, 2017 6:23 PM, "Charan Reddy G" wrote: >

Re: GitHub permissions

Hi Jia, I just granted you the permissions. Do you mind starting a separate email thread? I think this one is about pre-commit builds for pull requests. - Sijie On Fri, Jun 9, 2017 at 8:12 PM, Jia Zhai wrote: > Hi Sijie, Flavio and Enrico, > I prepared a BP for this "Github issues", would you

Re: GitHub permissions

Hi Sijie, Flavio and Enrico, I prepared a BP for this "Github issues", would you please help comment on it? And seems I did not have write permission, Would please help add it in https://cwiki.apache.org/confluence/display/BOOKKEEPER/BookKeeper+Proposals ? If could get the permission, it is better,

Re: CompactionTest tests are broken because of BOOKKEEPER-1088 change

Yes, I am working on it. Enrico pointed it out earlier. Sijie On Jun 9, 2017 6:23 PM, "Charan Reddy G" wrote: > Hey Sijie, > > It seems one of your commit > https://github.com/apache/bookkeeper/commit/5fe86525a9c823f79b3e97fd82ea4a > a1c75c79eb > has broken CompactionTests tests. For me locally

CompactionTest tests are broken because of BOOKKEEPER-1088 change

Hey Sijie, It seems one of your commit https://github.com/apache/bookkeeper/commit/5fe86525a9c823f79b3e97fd82ea4aa1c75c79eb has broken CompactionTests tests. For me locally consistently some of the tests in CompactionTest.java are failing with test timeout exceptions. Can you please look into the

[jira] [Commented] (BOOKKEEPER-1096) When ledger is deleted, along with leaf node all the eligible branch nodes also should be deleted in ZooKeeper.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045197#comment-16045197 ] ASF GitHub Bot commented on BOOKKEEPER-1096: Github user reddycharan comm

[GitHub] bookkeeper issue #186: BOOKKEEPER-1096: recursive znode delete

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/186 @revans2 and @knusbaum FYI, LongHierarchicalLedgerManager needs this fix for https://issues.apache.org/jira/browse/BOOKKEEPER-1096 --- If your project is set up for it, you can reply to this

[jira] [Commented] (BOOKKEEPER-1096) When ledger is deleted, along with leaf node all the eligible branch nodes also should be deleted in ZooKeeper.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045193#comment-16045193 ] ASF GitHub Bot commented on BOOKKEEPER-1096: GitHub user reddycharan open

[GitHub] bookkeeper pull request #186: BOOKKEEPER-1096: recursive znode delete

GitHub user reddycharan opened a pull request: https://github.com/apache/bookkeeper/pull/186 BOOKKEEPER-1096: recursive znode delete When ledger is deleted, along with leaf node all the eligible branch nodes should be deleted in ZooKeeper. You can merge this pull request int

[jira] [Created] (BOOKKEEPER-1096) When ledger is deleted, along with leaf node all the eligible branch nodes also should be deleted in ZooKeeper.

Charan Reddy Guttapalem created BOOKKEEPER-1096: --- Summary: When ledger is deleted, along with leaf node all the eligible branch nodes also should be deleted in ZooKeeper. Key: BOOKKEEPER-1096 URL: ht

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

+1 (binding) Regards, Uma On Thu, Jun 8, 2017 at 5:21 PM, Sijie Guo wrote: > ( /cc bookkeeper dev@ and incubator general@ for awareness ) > > Hi all, > > There was a joint discussion between BookKeeper PMC and DistributedLog PPMC > about moving the development of DistributedLog as part of Apach

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

+1 (binding) - Sijie On Fri, Jun 9, 2017 at 1:38 PM, Jon Derrick wrote: > +1 (non-binding) > > On Fri, Jun 9, 2017 at 9:39 AM, Gerrit Sundaram > wrote: > > > +1 (non-binding) > > > > On Fri, Jun 9, 2017 at 9:38 AM, Xi Liu wrote: > > > > > +1 (non-binding) > > > > > > On Fri, Jun 9, 2017 at 3:

Build failed in Jenkins: bookkeeper-master #1779

See -- [...truncated 1.18 MB...] Running org.apache.bookkeeper.conf.NoSystemPropertiesConfigurationTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.156 sec - in or

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044628#comment-16044628 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user sijie commented on

[jira] [Commented] (BOOKKEEPER-1093) Piggyback LAC on ReadResponse

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044624#comment-16044624 ] ASF GitHub Bot commented on BOOKKEEPER-1093: Github user sijie commented

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/80 @eolivelli I haven't yet will do in the weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] bookkeeper issue #180: BOOKKEEPER-1093: Piggyback LAC on ReadResponse

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/180 you still need to call "readLastAddConfirmed". This change is not "long poll", it is "piggy-back lac". It is an optimization on reducing the times of calling readLastAddConfirmed. In a tailing case

Re: Master is broker

I will take a look at the failures. On Fri, Jun 9, 2017 at 5:17 AM, Enrico Olivelli wrote: > In order to automatically publish snapshots I added > -Dmaven.test.failure.ignore=true option but this is actaully hiding > the fact that the job is failing consistently I have reverted the > configurat

[jira] [Commented] (BOOKKEEPER-1017) Create documentation for ZooKeeper ACLs

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044552#comment-16044552 ] ASF GitHub Bot commented on BOOKKEEPER-1017: GitHub user eolivelli opened

[GitHub] bookkeeper pull request #185: BOOKKEEPER-1017 Create documentation for ZooKe...

GitHub user eolivelli opened a pull request: https://github.com/apache/bookkeeper/pull/185 BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs This is the documentation for ZooKeeper security and there is an intro about security in general. It is work-in-progress, I created

[jira] [Updated] (BOOKKEEPER-1017) Create documentation for ZooKeeper ACLs

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated BOOKKEEPER-1017: Summary: Create documentation for ZooKeeper ACLs (was: Create documentation fo

[jira] [Assigned] (BOOKKEEPER-1017) Create documentation for ZooKeeepr ACLs

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned BOOKKEEPER-1017: --- Assignee: Enrico Olivelli > Create documentation for ZooKeeepr ACLs > --

[jira] [Commented] (BOOKKEEPER-753) Bookie should run garbage collection before startup when all directories became full

[ https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044534#comment-16044534 ] ASF GitHub Bot commented on BOOKKEEPER-753: --- Github user eolivelli commented

[GitHub] bookkeeper issue #81: BOOKKEEPER-753: Bookie should run garbage collection b...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/81 @sijie @jvrao @reddycharan do you think we can proceed with this patch ? or is there any conflict with new patches @reddycharan is going to push ? --- If your project is set up for

Re: Jenkins Pull-Request Build

Yeah, I think it is fine to delete that job. Given this line in the config: curl http://people.apache.org/~ivank/debug.diff | patch -p0 I suspect Ivan created it for debugging. Does anyone else see a problem with deleting this job: https://builds.apache.org/view/All/job/bookkeeper-debug

[GitHub] bookkeeper issue #184: Support GitHub issues in bk-merge script

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/issues/184 another problem...how can we create release notes ? maybe for 4.5.0 we should stay on JIRA as most of the issues are on that system --- If your project is set up for it, you can reply to

[GitHub] bookkeeper issue #184: Support GitHub issues in bk-merge script

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/issues/184 I am not expert of GitHub API and I am a python newbie, @Sijie I think you created the actual script and maybe you be be able to edit is in order to enhance it I think that fir

My first Issue on GitHub !

I have just created a "GitHub issue" to support "GitHub issues" https://github.com/apache/bookkeeper/issues/184 I am not expert of GitHub API and I am a python newbie, @Sijie I think you created the actual script and maybe you be be able to edit is in order to enhance it I think that first of all

[GitHub] bookkeeper issue #184: Support GitHub issues in bk-merge script

GitHub user eolivelli opened an issue: https://github.com/apache/bookkeeper/issues/184 Support GitHub issues in bk-merge script This issue is to support GitHub issues in bk-merge script as well as we are doing with ASF JIRA. --- If your project is set up for it, you c

Re: Jenkins Pull-Request Build

There is a bookkeeper-debug job which I think it should be dropped can you do it Sijie or Flavio ? If you are OK I think I can do it by myself -- Enrico 2017-06-01 20:17 GMT+02:00 Sijie Guo : > Yeah. I updated the description for the master job. > > (yes. this wiki page is cloned from DL.) > > O

Master is broker

In order to automatically publish snapshots I added -Dmaven.test.failure.ignore=true option but this is actaully hiding the fact that the job is failing consistently I have reverted the configuration. Last build without failures is Build #1775 (Jun 5, 2017 12:49:01 PM) https://builds.apache.org/j

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044357#comment-16044357 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user eolivelli commen

[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/127 I am sorry @reddycharan but findbugs is still failing [INFO] Boxing/unboxing to parse a primitive org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd.runCmd(CommandLine)

[jira] [Commented] (BOOKKEEPER-1093) Piggyback LAC on ReadResponse

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044344#comment-16044344 ] ASF GitHub Bot commented on BOOKKEEPER-1093: Github user eolivelli commen

[GitHub] bookkeeper issue #180: BOOKKEEPER-1093: Piggyback LAC on ReadResponse

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/180 @sijie I did a more deep review and it is all great for me. Do you think it would be useful to add a test for readUnconfirmedEntries ? Actually the implementation is shared with readEn

Re: GitHub permissions

2017-06-09 12:37 GMT+02:00 Enrico Olivelli : > 2017-06-09 12:25 GMT+02:00 Enrico Olivelli : >> >> >> Il ven 9 giu 2017, 12:04 Sijie Guo ha scritto: >>> >>> On Fri, Jun 9, 2017 at 1:51 AM, Enrico Olivelli >>> wrote: >>> >>> > Hi, >>> > I would like to ask infra permissions to edit pull requests of

Re: GitHub permissions

2017-06-09 12:25 GMT+02:00 Enrico Olivelli : > > > Il ven 9 giu 2017, 12:04 Sijie Guo ha scritto: >> >> On Fri, Jun 9, 2017 at 1:51 AM, Enrico Olivelli >> wrote: >> >> > Hi, >> > I would like to ask infra permissions to edit pull requests of other >> > users, at least "close"/"reopen" to force au

Re: GitHub permissions

Il ven 9 giu 2017, 12:04 Sijie Guo ha scritto: > On Fri, Jun 9, 2017 at 1:51 AM, Enrico Olivelli > wrote: > > > Hi, > > I would like to ask infra permissions to edit pull requests of other > > users, at least "close"/"reopen" to force automatic QA. > > > > You can manually trigger the pre-commit

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

+1 (non-binding) On Fri, Jun 9, 2017 at 3:02 PM, Stevo Slavić wrote: > +1 (non-binding) > > On Fri, Jun 9, 2017 at 8:47 AM, Sijie Guo wrote: > > > (dropping general@) > > > > - Sijie > > > > On Thu, Jun 8, 2017 at 5:21 PM, Sijie Guo wrote: > > > > > ( /cc bookkeeper dev@ and incubator general@

Re: GitHub permissions

On Fri, Jun 9, 2017 at 1:51 AM, Enrico Olivelli wrote: > Hi, > I would like to ask infra permissions to edit pull requests of other > users, at least "close"/"reopen" to force automatic QA. > You can manually trigger the pre-commit job to build a specific pull request. There is one parameter and

Re: GitHub permissions

Agreed that it is best to have the Apache pre-commit build run successfully before merging. -Flavio > On 09 Jun 2017, at 11:12, Enrico Olivelli wrote: > > 2017-06-09 11:06 GMT+02:00 Flavio Junqueira : >> I just checked the configuration in jenkins and the retention of a build is >> currently

Re: GitHub permissions

2017-06-09 11:06 GMT+02:00 Flavio Junqueira : > I just checked the configuration in jenkins and the retention of a build is > currently 14 days and no max number of jobs. That should be sufficient, > otherwise we might end up overwhelming jenkins. > Yet I think that actual configuration is ok fr

Re: GitHub permissions

I just checked the configuration in jenkins and the retention of a build is currently 14 days and no max number of jobs. That should be sufficient, otherwise we might end up overwhelming jenkins. -Flavio > On 09 Jun 2017, at 10:58, Flavio Junqueira wrote: > > I can increase retention if that

Re: GitHub permissions

I can increase retention if that helps. -Flavio > On 09 Jun 2017, at 10:51, Enrico Olivelli wrote: > > Hi, > I would like to ask infra permissions to edit pull requests of other > users, at least "close"/"reopen" to force automatic QA. > > We have a short backlog of PR QA builds so after some

GitHub permissions

Hi, I would like to ask infra permissions to edit pull requests of other users, at least "close"/"reopen" to force automatic QA. We have a short backlog of PR QA builds so after some time it is not possible to see old tests results Maybe this permission can be extended automatically to every comm

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044150#comment-16044150 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user eolivelli commented

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/183 I wonder if we have to add some "stat" about SSL clients. Maybe we can enhance this aspect in the future --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/80 @sijie did you have time to take a look to this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044147#comment-16044147 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user eolivelli commented

[GitHub] bookkeeper issue #97: BOOKKEEPER-588 SSL Support

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/97 closing this PR in favour of #183 from @kishorekasi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044138#comment-16044138 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user eolivelli closed th

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044137#comment-16044137 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user eolivelli commented

[GitHub] bookkeeper pull request #97: BOOKKEEPER-588 SSL Support

Github user eolivelli closed the pull request at: https://github.com/apache/bookkeeper/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (BOOKKEEPER-588) SSL support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044071#comment-16044071 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- GitHub user kishorekasi opened

[GitHub] bookkeeper pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

GitHub user kishorekasi opened a pull request: https://github.com/apache/bookkeeper/pull/183 BOOKKEEPER-588 SSL Support for Bookkeeper + Merged changes from @eoliville + Mutual Authentication You can merge this pull request into a Git repository by running: $ git pull https

Re: [VOTE] Merge DistributedLog as the subproject of Apache BookKeeper

+1 (non-binding) On Fri, Jun 9, 2017 at 8:47 AM, Sijie Guo wrote: > (dropping general@) > > - Sijie > > On Thu, Jun 8, 2017 at 5:21 PM, Sijie Guo wrote: > > > ( /cc bookkeeper dev@ and incubator general@ for awareness ) > > > > Hi all, > > > > There was a joint discussion between BookKeeper PMC