[ https://issues.apache.org/jira/browse/BOOKKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045193#comment-16045193 ]
ASF GitHub Bot commented on BOOKKEEPER-1096: -------------------------------------------- GitHub user reddycharan opened a pull request: https://github.com/apache/bookkeeper/pull/186 BOOKKEEPER-1096: recursive znode delete When ledger is deleted, along with leaf node all the eligible branch nodes should be deleted in ZooKeeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reddycharan/bookkeeper recursiveznodedelete Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bookkeeper/pull/186.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #186 ---- commit d1feabb7e2c95bbd4beb8d8a68956deeb28894aa Author: Charan Reddy Guttapalem <cguttapa...@salesforce.com> Date: 2017-06-08T02:54:35Z BOOKKEEPER-1096: recursive znode delete When ledger is deleted, along with leaf node all the eligible branch nodes should be deleted in ZooKeeper. ---- > When ledger is deleted, along with leaf node all the eligible branch nodes > also should be deleted in ZooKeeper. > --------------------------------------------------------------------------------------------------------------- > > Key: BOOKKEEPER-1096 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1096 > Project: Bookkeeper > Issue Type: Improvement > Reporter: Charan Reddy Guttapalem > Assignee: Charan Reddy Guttapalem > > Currently when we delete a ledger, we delete just the leaf node in the ZK but > we ignore about the branch nodes. This is ok for FlatLedgerManager, but for > HierarchicalLedgerManagers, especially for LongHierarchicalLedgerManager, the > number of internal nodes gets blown up over time and we would get into ZK > capacity limitations. When ZK reaches the capacity limits, it will manifest > in very severe performance and stability issues of cluster. So for > HierarchicalLedgerManagers, when we delete a ledger we should optimistically > recursively delete the parent znodes as well if they don’t have anymore child > znodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)