[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

2017-05-10 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/145 @jvrao @merlimat IHMO In case of a failed bookie it is not good to spam logs with errors. It is enough that the method returns an error code. I am OK if you prefer to distinguish t

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005982#comment-16005982 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user eolivelli commen

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005975#comment-16005975 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user eolivelli commen

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

2017-05-10 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/141 @jvrao the main explanation is that we already call shutdownNow if the pool does not end execution within 1 minute. In my personal usecases I usually kill bookies (kill -9) and do not w

[GitHub] bookkeeper issue #81: BOOKKEEPER-753: Bookie should run garbage collection b...

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/81 I agree that this change won't conflict with my changes, but I really don't see much value in this change with our changes. @reddycharan did we send pull request on this one? --- If your project i

[jira] [Commented] (BOOKKEEPER-753) Bookie should run garbage collection before startup when all directories became full

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005967#comment-16005967 ] ASF GitHub Bot commented on BOOKKEEPER-753: --- Github user jvrao commented on

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005949#comment-16005949 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user jvrao commented

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/141 Can someone explain me why it won't affect production bookies? @eolivelli ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

Re: Question regarding synchronization in EntryLogger

2017-05-10 Thread Venkateswara Rao Jujjuri
Sure, Charan please have a small writeup so we can discus in next Thursday. On Tue, May 9, 2017 at 10:27 PM, Enrico Olivelli wrote: > > > Il mer 10 mag 2017, 01:59 Sijie Guo ha scritto: > >> On Sat, May 6, 2017 at 9:51 AM, Charan Reddy G >> wrote: >> >> > Hey, >> > >> > In EntryLogger, I'm won

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005937#comment-16005937 ] ASF GitHub Bot commented on BOOKKEEPER-1057: Github user jvrao commented

[GitHub] bookkeeper issue #145: BOOKKEEPER-1057: Do not log error message after read ...

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/145 What about the regular read failure? We need a way to print the error message on regular read request and ignore in recovery case or where we try to read beyond LAC. Changing to default by default

[jira] [Commented] (BOOKKEEPER-1058) Ignore already deleted ledger on replication audit

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005934#comment-16005934 ] ASF GitHub Bot commented on BOOKKEEPER-1058: Github user jvrao commented

[GitHub] bookkeeper issue #146: BOOKKEEPER-1058: Ignore already deleted ledger on rep...

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/146 @athanatos did we do the same fix internally? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005929#comment-16005929 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user jvrao commented

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/138 Nice work!! Finally everything is passing. :) Great news. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] bookkeeper issue #149: BOOKKEEPER-1061: BookieWatcher should not do ZK block...

2017-05-10 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/149 @athanatos FYI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[jira] [Commented] (BOOKKEEPER-1061) BookieWatcher should not do ZK blocking operations from ZK async callback thread

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005925#comment-16005925 ] ASF GitHub Bot commented on BOOKKEEPER-1061: Github user jvrao commented

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On Thu, May 11, 2017 at 8:25 AM, Venkateswara Rao Jujjuri wrote: > Yes; My question is what is the impact we are taking by doing force(true) > all the time. > Just to avoid any concern caused by Charan's statement about "java API > for force method - https://docs.oracle.com/java > se/7/docs/api/j

Jenkins build is back to normal : bookkeeper-master-git-pullrequest #370

2017-05-10 Thread Apache Jenkins Server
See

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Matteo Merli
I think there might be a misunderstanding regarding FileChannel and BufferedFileChannel. BufferedFileChannel is a BK class and has a flush(boolean) method. * flush(false) --> just writes the in-memory byte array to the FileChannel (no fsync/fdatasync involved) * flush(true) --> write to FileCh

Build failed in Jenkins: bookkeeper-master-git-pullrequest #369

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Venkateswara Rao Jujjuri
Yes; My question is what is the impact we are taking by doing force(true) all the time. Just to avoid any concern caused by Charan's statement about "java API for force method - https://docs.oracle.com/javase/7/docs/api/java/nio/ channels/FileChannel.html#force(boolean), it says the implementation

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On Thu, May 11, 2017 at 8:02 AM, Venkateswara Rao Jujjuri wrote: > That is correct. But we are talking about active entrylog file(s) and > journal file(s). > Do you see lot of active journal files that won't get updated but read for > long time? > I am a bit confused about this question here. Wh

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On Thu, May 11, 2017 at 7:47 AM, Venkateswara Rao Jujjuri wrote: > Let me try to consolidate the discussion. > > 1. We need to flush the metadata whenever we cause metadata changes due to > data changes. Mostly Append/Filesize change. > My take on fdatasync - it will sync metadata when filesize

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Venkateswara Rao Jujjuri
That is correct. But we are talking about active entrylog file(s) and journal file(s). Do you see lot of active journal files that won't get updated but read for long time? Anyway just trying broaden the discussion and if we have any doubt if java does fdatasync all the time. On Wed, May 10, 2017

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Matteo Merli
My understanding is that fsync() forces the IO on the metadata even if the file size has not changed, for example to update the access timestamp. On Wed, May 10, 2017 at 4:47 PM Venkateswara Rao Jujjuri wrote: > Let me try to consolidate the discussion. > > 1. We need to flush the metadata whene

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Venkateswara Rao Jujjuri
Let me try to consolidate the discussion. 1. We need to flush the metadata whenever we cause metadata changes due to data changes. Mostly Append/Filesize change. 2. I don't know any operations where we perform "metadata operation" only and we needed it to be "persisted" Even if we can think/come u

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On Thu, May 11, 2017 at 2:28 AM, Charan Reddy G wrote: > @JV and @Sijie I think Android java source is not the appropriate one to > look into. For FileChannelImpl we need to look into jdk code > > http://grepcode.com/file/repository.grepcode.com/java/ > root/jdk/openjdk/8u40-b25/sun/nio/ch/FileC

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On Thu, May 11, 2017 at 2:28 AM, Charan Reddy G wrote: > @JV and @Sijie I think Android java source is not the appropriate one to > look into. For FileChannelImpl we need to look into jdk code > > http://grepcode.com/file/repository.grepcode.com/java/ > root/jdk/openjdk/8u40-b25/sun/nio/ch/FileC

Build failed in Jenkins: bookkeeper-master-git-pullrequest #368

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1063: Use executure.execute() instead of submit() to avoid -- [...truncated 47.54 KB...] Tests run: 3, Failures: 0, Errors

[jira] [Commented] (BOOKKEEPER-1063) Use executure.execute() instead of submit() to avoid creation of unused FutureTask

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005524#comment-16005524 ] ASF GitHub Bot commented on BOOKKEEPER-1063: GitHub user merlimat opened

[GitHub] bookkeeper pull request #150: BOOKKEEPER-1063: Use executure.execute() inste...

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/150 BOOKKEEPER-1063: Use executure.execute() instead of submit() to avoid… … creation of unused FutureTask When submitting tasks to an executor, if the `FutureTask` object is not being

[jira] [Created] (BOOKKEEPER-1063) Use executure.execute() instead of submit() to avoid creation of unused FutureTask

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1063: Summary: Use executure.execute() instead of submit() to avoid creation of unused FutureTask Key: BOOKKEEPER-1063 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1063

[jira] [Commented] (BOOKKEEPER-1062) AuditorLedgerCheckerTest intermittent failures

2017-05-10 Thread Matteo Merli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005502#comment-16005502 ] Matteo Merli commented on BOOKKEEPER-1062: -- Example from https://builds.apa

[jira] [Created] (BOOKKEEPER-1062) AuditorLedgerCheckerTest intermittent failures

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1062: Summary: AuditorLedgerCheckerTest intermittent failures Key: BOOKKEEPER-1062 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1062 Project: Bookkeeper

[GitHub] bookkeeper pull request #144: BOOKKEEPER-1054: Add gitignore file

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005457#comment-16005457 ] ASF GitHub Bot commented on BOOKKEEPER-1054: Github user asfgit closed th

[jira] [Resolved] (BOOKKEEPER-1054) Add gitignore file

2017-05-10 Thread Matteo Merli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1054. -- Resolution: Fixed Issue resolved by merging pull request 144 [https://g

[jira] [Commented] (BOOKKEEPER-1059) Upgrade to SLF4J-1.7.25

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005440#comment-16005440 ] ASF GitHub Bot commented on BOOKKEEPER-1059: Github user asfgit closed th

[jira] [Resolved] (BOOKKEEPER-1059) Upgrade to SLF4J-1.7.25

2017-05-10 Thread Matteo Merli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1059. -- Resolution: Fixed Issue resolved by merging pull request 147 [https://g

[GitHub] bookkeeper pull request #147: BOOKKEEPER-1059: Upgrade to SLF4J-1.7.25

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Jenkins build is back to normal : bookkeeper-master-git-pullrequest #365

2017-05-10 Thread Apache Jenkins Server
See

[jira] [Commented] (BOOKKEEPER-1061) BookieWatcher should not do ZK blocking operations from ZK async callback thread

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005393#comment-16005393 ] ASF GitHub Bot commented on BOOKKEEPER-1061: GitHub user merlimat opened

[GitHub] bookkeeper pull request #149: BOOKKEEPER-1061: BookieWatcher should not do Z...

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/149 BOOKKEEPER-1061: BookieWatcher should not do ZK blocking operations from ZK async callback thread In some cases, the BookieWatcher can get the ZK event thread stuck. This happens when a ZK blo

[jira] [Created] (BOOKKEEPER-1061) BookieWatcher should not do ZK blocking operations from ZK async callback thread

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1061: Summary: BookieWatcher should not do ZK blocking operations from ZK async callback thread Key: BOOKKEEPER-1061 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1061

[jira] [Resolved] (BOOKKEEPER-1060) Add utility to use SafeRunnable from Java8 Lambda

2017-05-10 Thread Matteo Merli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1060. -- Resolution: Fixed Issue resolved by merging pull request 148 [https://g

[jira] [Commented] (BOOKKEEPER-1060) Add utility to use SafeRunnable from Java8 Lambda

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005376#comment-16005376 ] ASF GitHub Bot commented on BOOKKEEPER-1060: Github user asfgit closed th

[GitHub] bookkeeper pull request #148: BOOKKEEPER-1060: Add utility to use SafeRunnab...

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005356#comment-16005356 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user eolivelli commen

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

2017-05-10 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/138 Great work @merlimat and @kishorekasi! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (BOOKKEEPER-1060) Add utility to use SafeRunnable from Java8 Lambda

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005342#comment-16005342 ] ASF GitHub Bot commented on BOOKKEEPER-1060: GitHub user merlimat opened

[GitHub] bookkeeper pull request #148: BOOKKEEPER-1060: Add utility to use SafeRunnab...

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/148 BOOKKEEPER-1060: Add utility to use SafeRunnable from Java8 Lambda Since BK-4.5.0 is already switched to Java8, we should have a simple and concise way to pass lambdas where a `SafeRunnable` is

[jira] [Created] (BOOKKEEPER-1060) Add utility to use SafeRunnable from Java8 Lambda

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1060: Summary: Add utility to use SafeRunnable from Java8 Lambda Key: BOOKKEEPER-1060 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1060 Project: Bookkeeper

Build failed in Jenkins: bookkeeper-master-git-pullrequest #364

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1058: Ignore already deleted ledger on replication audit -- [...truncated 28.39 KB...] Running org.apache.bookkeeper.zooke

Build failed in Jenkins: bookkeeper-master-git-pullrequest #363

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1057: Do not log error message after read failure in -- [...truncated 27.92 KB...] Tests run: 4, Failures: 0, Errors: 0, S

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Matteo Merli
> But the scenario in question is for EntryLogger.logChannel and in GarbageCollectorThread.doCompactEntryLogs codepath. Here we just keep adding entries to the EntryLogger.logChannel and flush it before deleting the compacted entrylog. But in that case, the entry log is just issuing the fdatasync(

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Charan Reddy G
Hey Matteo, I agree with what you said for JournalChannel JournalChannel.preAllocIfNeeded void preAllocIfNeeded(long size) throws IOException { if (bc.position() + size > nextPrealloc) { nextPrealloc += preAllocSize; zeros.clear(); fc.write(zeros,

Build failed in Jenkins: bookkeeper-master-git-pullrequest #362

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Matteo Merli
> On the other hand, a change to the file size (st_size, as made by say ftruncate(2)), would require a metadata flush." This is why the Journal is pre-allocating the blocks instead of just appending entries at the end of the file. That way the metadata is only synced each time you expand a block

[jira] [Commented] (BOOKKEEPER-1059) Upgrade to SLF4J-1.7.25

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005186#comment-16005186 ] ASF GitHub Bot commented on BOOKKEEPER-1059: GitHub user merlimat opened

[GitHub] bookkeeper pull request #147: BOOKKEEPER-1059: Upgrade to SLF4J-1.7.25

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/147 BOOKKEEPER-1059: Upgrade to SLF4J-1.7.25 You can merge this pull request into a Git repository by running: $ git pull https://github.com/merlimat/bookkeeper slf4j-1.7 Alternatively you c

[jira] [Created] (BOOKKEEPER-1059) Upgrade to SLF4J-1.7.25

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1059: Summary: Upgrade to SLF4J-1.7.25 Key: BOOKKEEPER-1059 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1059 Project: Bookkeeper Issue Type: Task

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Charan Reddy G
@JV and @Sijie I think Android java source is not the appropriate one to look into. For FileChannelImpl we need to look into jdk code http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/sun/nio/ch/FileChannelImpl.java#FileChannelImpl.force%28boolean%29 public voi

[jira] [Commented] (BOOKKEEPER-1058) Ignore already deleted ledger on replication audit

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005159#comment-16005159 ] ASF GitHub Bot commented on BOOKKEEPER-1058: GitHub user merlimat opened

[GitHub] bookkeeper pull request #146: BOOKKEEPER-1058: Ignore already deleted ledger...

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/146 BOOKKEEPER-1058: Ignore already deleted ledger on replication audit Replication auditor should skip ledgers that were deleted since the auditing was started. You can merge this pull request i

[jira] [Created] (BOOKKEEPER-1058) Ignore already deleted ledger on replication audit

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1058: Summary: Ignore already deleted ledger on replication audit Key: BOOKKEEPER-1058 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1058 Project: Bookkeeper

Build failed in Jenkins: bookkeeper-master-git-pullrequest #361

2017-05-10 Thread Apache Jenkins Server
See Changes: [mmerli] BOOKKEEPER-1054: Add gitignore file [mmerli] Added NetBeans exclusions as well -- [...truncated 32.58 KB...] T E S T S

[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005129#comment-16005129 ] ASF GitHub Bot commented on BOOKKEEPER-1057: GitHub user merlimat opened

[GitHub] bookkeeper pull request #145: BOOKKEEPER-1057: Do not log error message afte...

2017-05-10 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/145 BOOKKEEPER-1057: Do not log error message after read failure in PendingReadOp In PendingReadOp, there is an error message that is printed each time a read on a specific bookie is failing:

[jira] [Created] (BOOKKEEPER-1057) Do not log error message after read failure in PendingReadOp

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1057: Summary: Do not log error message after read failure in PendingReadOp Key: BOOKKEEPER-1057 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1057 Project:

[jira] [Created] (BOOKKEEPER-1056) Removed PacketHeader serialization/deserialization allocation

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1056: Summary: Removed PacketHeader serialization/deserialization allocation Key: BOOKKEEPER-1056 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1056 Project

[jira] [Created] (BOOKKEEPER-1055) Optimize handling of masterKey in case it is empty

2017-05-10 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1055: Summary: Optimize handling of masterKey in case it is empty Key: BOOKKEEPER-1055 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1055 Project: Bookkeeper

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004973#comment-16004973 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user merlimat comment

[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1

2017-05-10 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/138 @kishorekasi @jvrao @revans2 @sijie @eolivelli All the tests are passing properly with epoll event loop on linux. I have already applied most of the ref-count fixes from yahoo branch as

[jira] [Commented] (BOOKKEEPER-1053) Upgrade RAT maven version to 0.12 and ignore Eclipse project files

2017-05-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004726#comment-16004726 ] Hudson commented on BOOKKEEPER-1053: SUCCESS: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1052) Print autorecovery enabled or not in bookie shell

2017-05-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004725#comment-16004725 ] Hudson commented on BOOKKEEPER-1052: SUCCESS: Integrated in Jenkins build bookkee

Jenkins build is back to normal : bookkeeper-master #1743

2017-05-10 Thread Apache Jenkins Server
See

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

2017-05-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004723#comment-16004723 ] Hudson commented on BOOKKEEPER-1050: SUCCESS: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

2017-05-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004724#comment-16004724 ] Hudson commented on BOOKKEEPER-1051: SUCCESS: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004684#comment-16004684 ] ASF GitHub Bot commented on BOOKKEEPER-1054: Github user merlimat comment

[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file

2017-05-10 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/144 @eolivelli the pr # is 144 and not 114 as in your snippet above. I will also add the netbeans files --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Issue in GarbageCollectorThread compaction logic

2017-05-10 Thread Sijie Guo
On May 10, 2017 12:42 PM, "Venkateswara Rao Jujjuri" wrote: Looked at the source and it is fdatasync() https://android.googlesource.com/platform/libcore/+/ 2496a68/luni/src/main/java/java/nio/FileChannelImpl.java if (metadata) { Libcore.os.fsync(fd); } else { Libcore.os.fdatasync(fd); }

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

2017-05-10 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004468#comment-16004468 ] Enrico Olivelli commented on BOOKKEEPER-1051: - [~mmerli] [~hustlmsp] I am

Apache Rat Plugin in execution

2017-05-10 Thread Enrico Olivelli
Hi, According to the Apache Rat plugin docs the goal (1) to use to execute Rat is mvn apache-rat:check in dev/bk-merge-pr.py I have recently added this check, in order to be sure to merge only rat and finbugs compliant commits mvn clean install -DskipTests findbugs:check rat:rat using 'rat' pre

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004371#comment-16004371 ] ASF GitHub Bot commented on BOOKKEEPER-1054: Github user eolivelli commen

[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file

2017-05-10 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/144 @merlimat could you also include NetBeans files: `/**/nb-configuration.xml` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

2017-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004217#comment-16004217 ] ASF GitHub Bot commented on BOOKKEEPER-1054: Github user eolivelli commen

[GitHub] bookkeeper issue #144: BOOKKEEPER-1054: Add gitignore file

2017-05-10 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/144 @merlimat I have some trouble in checking out this commit ``` git fetch apache-github pull/114/head:bookeeper-1054-gitignore git checkout bookeeper-1054-gitignore ```