[
https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005982#comment-16005982
]
ASF GitHub Bot commented on BOOKKEEPER-1057:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/145
@jvrao @merlimat
IHMO In case of a failed bookie it is not good to spam logs with errors. It
is enough that the method returns an error code.
I am OK if you prefer to distinguish the pointed case of "recovery" from
the other cases.
> Do not log error message after read failure in PendingReadOp
> ------------------------------------------------------------
>
> Key: BOOKKEEPER-1057
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1057
> Project: Bookkeeper
> Issue Type: Task
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Trivial
> Fix For: 4.5.0
>
>
> In {{PendingReadOp}}, there is an error message that is printed each time a
> read on a specific bookie is failing:
> {noformat}
> LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First
> unread entry is {}",
> new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts,
> firstUnread });
> {noformat}
> This message is getting printed each time a ledger is recovered and there is
> no error, since the ledger recovery logic is to keep reading and incrementing
> the entryId until a NoEntry error is received.
> This log message should be set at debug level.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
