Build failed in Jenkins: bookkeeper-master-git-pullrequest #346

2017-05-05 Thread Apache Jenkins Server
See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

Question regarding synchronization in EntryLogger

2017-05-05 Thread Charan Reddy G
Hey, In EntryLogger, I'm wondering what is the need of making flushCurrentLog method synchronized? (if we make logChannel variable volatile or of type AtomicReference and bytesWrittenSinceLastFlush of type AtomicLong). Anyhow in BufferedChannel.flush, flushInternal() is called from synchrnoized bl

Re: Issue in GarbageCollectorThread compaction logic

2017-05-05 Thread Charan Reddy G
By metadata I mean metadata of file in BufferedChannel.java public void flush(boolean shouldForceWrite) throws IOException { synchronized(this) { flushInternal(); } if (shouldForceWrite) { forceWrite(false); <- false here

Issue in GarbageCollectorThread compaction logic

2017-05-05 Thread Charan Reddy G
Hey, In GarbageCollectorThread.doCompactEntryLogs { ... try { compactEntryLog(scannerFactory, meta); scannerFactory.flush();<--- this will eventually call entrylogger.flushCurrentLog and it force writes the content of the Buffer

Build failed in Jenkins: bookkeeper-master-git-pullrequest #345

2017-05-05 Thread Apache Jenkins Server
See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

[GitHub] bookkeeper pull request #139: BOOKKEEPER-1048: Use ByteBuf in LedgerStorage ...

2017-05-05 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/139 BOOKKEEPER-1048: Use ByteBuf in LedgerStorage interface To pass ref-counted buffer from Netty directly to the storage and the Journal, we need to have LedgerStorage to accept ByteBuf instead of

[jira] [Commented] (BOOKKEEPER-1048) Use ByteBuf in LedgerStorageInterface

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999157#comment-15999157 ] ASF GitHub Bot commented on BOOKKEEPER-1048: GitHub user merlimat opened

[jira] [Created] (BOOKKEEPER-1048) Use ByteBuf in LedgerStorageInterface

2017-05-05 Thread Matteo Merli (JIRA)
Matteo Merli created BOOKKEEPER-1048: Summary: Use ByteBuf in LedgerStorageInterface Key: BOOKKEEPER-1048 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1048 Project: Bookkeeper Is

Build failed in Jenkins: bookkeeper-master-git-pullrequest #344

2017-05-05 Thread Apache Jenkins Server
See Changes: [cguttapalem] BOOKKEEPER-944: LowWaterMark Storage Threshold -- [...truncated 25.34 KB...] Tests run: 13, Failures: 0, Errors: 0, Skipped:

Build failed in Jenkins: bookkeeper-master-git-pullrequest #343

2017-05-05 Thread Apache Jenkins Server
See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998724#comment-15998724 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user merlimat comment

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

2017-05-05 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I think I fixed the epoll test issues. Added a couple of small commits on my branch. All tests are now passing on local linux. --- If your project is set up for it, you can reply t

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998626#comment-15998626 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user merlimat comment

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

2017-05-05 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/116 @kishorekasi I get a clean build on mac from my branch. I'm looking at the reasons it's failing with netty-all dependency on linux. I think we shouldn't be forcing the nio transport on linux.

Build failed in Jenkins: bookkeeper-master-git-pullrequest #342

2017-05-05 Thread Apache Jenkins Server
See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

[jira] [Commented] (BOOKKEEPER-1046) Avoid long to Long conversion in OrderedSafeExecutor task submit

2017-05-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998339#comment-15998339 ] Hudson commented on BOOKKEEPER-1046: FAILURE: Integrated in Jenkins build bookkee

[jira] [Commented] (BOOKKEEPER-1047) Add missing error code in ZK setData return path

2017-05-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998341#comment-15998341 ] Hudson commented on BOOKKEEPER-1047: FAILURE: Integrated in Jenkins build bookkee

Build failed in Jenkins: bookkeeper-master #1738

2017-05-05 Thread Apache Jenkins Server
See Changes: [eolivelli] BOOKKEEPER-1046: Avoid long to Long conversion in OrderedSafeExecutor [eolivelli] BOOKKEEPER-1047: Add missing error code in ZK setData return path ---

[jira] [Commented] (BOOKKEEPER-1008) Move to netty4

2017-05-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997869#comment-15997869 ] ASF GitHub Bot commented on BOOKKEEPER-1008: Github user kishorekasi comm

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

2017-05-05 Thread kishorekasi
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli I have not looked into @merlimat changes. I will take a look and add them if they are not already addressed. --- If your project is set up for it, you can reply to this email and