[
https://issues.apache.org/jira/browse/BOOKKEEPER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999157#comment-15999157
]
ASF GitHub Bot commented on BOOKKEEPER-1048:
--------------------------------------------
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/139
BOOKKEEPER-1048: Use ByteBuf in LedgerStorage interface
To pass ref-counted buffer from Netty directly to the storage and the
Journal, we need to have LedgerStorage to accept ByteBuf instead of ByteBuffer
#### Note
This commit is on top of BOOKKEEPER-1048 / #138. Once that gets merged, I
will rebase. Posting now to get Jenkins run. Please review last commit in this
PR for now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper bytebuf-in-ledger-storage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 037ec026472d24d4ec4f607392fbf26c6327387f
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-09-04T22:58:43Z
Close bk connections when handling exceptions
(cherry picked from commit 270835b33c512cfe6e33216cf7e9284c1af556f6)
commit a347a22b4ef6117e5be358c2f3616202971a8181
Author: Kishore Kasi Udayashankar <kudayashan...@salesforce.com>
Date: 2017-02-13T19:50:22Z
BOOKKEEPER-1008 Move to Netty4.1
commit 0ae9b59e93ac90246098d7bd95b6e3eeb2c59027
Author: Kishore Kasi Udayashankar <kudayashan...@salesforce.com>
Date: 2017-05-01T20:55:18Z
Addressing review comments
- Use Netty 4.1.9
- Do not include classifier for Netty dependency. This will force using
Nio in linux platform
- fix testWriteGaps testcase failure
commit b4a24450c3056e04414b32752a86d70bf47ad0a5
Author: Matteo Merli <mme...@apache.org>
Date: 2017-05-03T00:49:11Z
Addressed comments from @revans2 and switched to netty-all dependency
(cherry picked from commit 6b9e1e4f53078808999ea5fed0bd7e6c893635db)
commit 28f5e9adc7d48850f7fd42c63dc01c12fa811227
Author: Kishore Kasi Udayashankar <kudayashan...@salesforce.com>
Date: 2017-05-03T07:21:57Z
Addressing ref count issues in LedgerHandleAdv and PendingAddOp
commit e056096c156a374e75bb6acd552e0f5e7d413155
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-03-24T19:26:39Z
Avoid ByteBuf.duplicate() in deserialization of addEntry
commit 005a02df37e7d95837d4ac4ff4f50dd2c3d9a3ed
Author: Matteo Merli <mme...@apache.org>
Date: 2017-05-04T20:50:18Z
Ensure the buffer to send is retained while we are connecting to bookie
commit dacfe09f1ae4f7b8a7ec5c9c8de109ed0cbfc4af
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-06-10T17:13:50Z
Fixed ref count when reading last confirmed op
commit 42d975c1cc80e7da49df61817931d3ceeb54444d
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-06-18T21:15:03Z
Release buffer after error
commit 8b7c987c3e5fb642cf0daddfd043f3adfdb1971c
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-06-28T04:32:25Z
Release buffer when exception is thrown
commit a82cd439eee2ea73d29c251ebdaa18c447daf14d
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-07-03T05:31:04Z
Added DoubleByteBuf instead of using CompositeByteBuf
commit 79f259151e8e22017e7013f0121f74478c0ebb88
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-07-08T13:47:25Z
Fixed issue with releasing null buffer
commit 9ec9f6b0a69cf1efb4b09eb1d353dc00ec61c1df
Author: Matteo Merli <mme...@yahoo-inc.com>
Date: 2015-08-20T22:37:27Z
Ensure entries for same ledger are sent in order on the same connection, to
minimize reordering
commit 612468442f15f733c0300078d8bfcb2d5af4e923
Author: Matteo Merli <mme...@apache.org>
Date: 2017-05-05T00:16:53Z
Wait for all requests to complete before releasing buffer
commit a3e767eedf80e5509034f8cfe39c9e3e8a8cb14b
Author: Matteo Merli <mme...@apache.org>
Date: 2017-05-05T18:20:55Z
Should expect NativeIoException when Netty uses epoll
commit 8434ba24c7e5c4787e4965f64e289a6a43b2166b
Author: Matteo Merli <mme...@apache.org>
Date: 2017-05-05T18:21:38Z
Use a more effective way to "pause" bookies in test
commit f53f772f79d0a334edc0f05e66edb7cc645b1ffa
Author: Matteo Merli <mme...@apache.org>
Date: 2015-03-17T22:25:38Z
BOOKKEEPER-1048: Use ByteBuf in LedgerStorage interface
----
> Use ByteBuf in LedgerStorageInterface
> -------------------------------------
>
> Key: BOOKKEEPER-1048
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1048
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Fix For: 4.5.0
>
>
> To pass ref-counted buffer from Netty directly to the storage and the
> Journal, we need to have LedgerStorage to accept ByteBuf instead of ByteBuffer
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
