On Thu, Apr 2, 2020 at 2:19 PM Antoine Pitrou wrote:
>
>
> Le 02/04/2020 à 20:58, Joris Van den Bossche a écrit :
> >
> > Yes, both autopep8 and black can fix up linting issues to ensure your code
> > passes the PEP8 checks (although autopep8 can not fix all issues
> > automatically).
> > But with
Le 02/04/2020 à 20:58, Joris Van den Bossche a écrit :
>
> Yes, both autopep8 and black can fix up linting issues to ensure your code
> passes the PEP8 checks (although autopep8 can not fix all issues
> automatically).
> But with autopep8 you *still* need to think about how to format your code,
Personally, I don't think autopep8 being less aggressive / more conservative
is that relevant. This is only for the single PR that does the reformatting
where black gives a much bigger number of changed lines. But once that
one-time cost is paid, using black will not give larger diffs or make more
I admit that the status quo does not bother me that much, so
`autopep8` as the more conservative / less aggressive option seems
fine to me, and also makes it simple for people to fix up common
linting issues in their PRs.
On Thu, Apr 2, 2020 at 5:16 AM Antoine Pitrou wrote:
>
>
> I have looked at
I have looked at the kind of reformatting used by black and I've become
-1 on this. `black` is much too aggressive and actually makes the code
less readable.
`autopep8` seems much better and less aggressive. Let's use that
instead.
Regards
Antoine.
On Thu, 26 Mar 2020 20:37:01 +0100
Joris V
+1 for using black
On Fri, Mar 27, 2020 at 11:53 AM Joris Van den Bossche <
jorisvandenboss...@gmail.com> wrote:
> On Fri, 27 Mar 2020 at 18:49, Antoine Pitrou wrote:
>
> >
> > I don't want to be the small minority opposing this so let's go for it.
> > One question though: will we continue to ch
On Fri, 27 Mar 2020 at 18:49, Antoine Pitrou wrote:
>
> I don't want to be the small minority opposing this so let's go for it.
> One question though: will we continue to check Cython files using
> flake8?
>
Yes, and I think we can continue to check flake8 for python files as well.
At
least that
I don't want to be the small minority opposing this so let's go for it.
One question though: will we continue to check Cython files using
flake8?
Regards
Antoine.
On Thu, 26 Mar 2020 20:37:01 +0100
Joris Van den Bossche wrote:
> Hi all,
>
> I would like to propose adopting Black as code for
+1 from me too, hopefully cython support will land eventually.
On Fri, Mar 27, 2020 at 11:33 AM Rok Mihevc wrote:
>
> +1 for black
>
> On Fri, Mar 27, 2020 at 11:11 AM Uwe L. Korn wrote:
>
> > I'm also very much in favor of this.
> >
> > For the black / cython support, I think the current state
+1 for black
On Fri, Mar 27, 2020 at 11:11 AM Uwe L. Korn wrote:
> I'm also very much in favor of this.
>
> For the black / cython support, I think the current state is reflected in
> https://github.com/pablogsal/black/tree/cython.
>
> On Fri, Mar 27, 2020, at 4:40 AM, Micah Kornfield wrote:
> >
I'm also very much in favor of this.
For the black / cython support, I think the current state is reflected in
https://github.com/pablogsal/black/tree/cython.
On Fri, Mar 27, 2020, at 4:40 AM, Micah Kornfield wrote:
> +1 from me as well.
>
> On Thursday, March 26, 2020, Neal Richardson
> wrote
+1 from me as well.
On Thursday, March 26, 2020, Neal Richardson
wrote:
> I'm also in favor, very much so. Life is too short to hold strong opinions
> about code style; you get used to whatever you're accustomed to seeing. And
> I support using automation to remove manual nuisances like this.
>
I'm also in favor, very much so. Life is too short to hold strong opinions
about code style; you get used to whatever you're accustomed to seeing. And
I support using automation to remove manual nuisances like this.
Neal
On Thu, Mar 26, 2020 at 3:49 PM Wes McKinney wrote:
> I'm in favor of this
I'm in favor of this even though I also probably won't like some of
the formatting decisions it makes. Is there a sense of how far away
Black is from having Cython support? I saw it was being worked on a
while back.
On Thu, Mar 26, 2020 at 2:37 PM Joris Van den Bossche
wrote:
>
> Hi all,
>
> I wo
14 matches
Mail list logo
