+1 from me too, hopefully cython support will land eventually.
On Fri, Mar 27, 2020 at 11:33 AM Rok Mihevc <rok.mih...@gmail.com> wrote: > > +1 for black > > On Fri, Mar 27, 2020 at 11:11 AM Uwe L. Korn <uw...@xhochy.com> wrote: > > > I'm also very much in favor of this. > > > > For the black / cython support, I think the current state is reflected in > > https://github.com/pablogsal/black/tree/cython. > > > > On Fri, Mar 27, 2020, at 4:40 AM, Micah Kornfield wrote: > > > +1 from me as well. > > > > > > On Thursday, March 26, 2020, Neal Richardson < > > neal.p.richard...@gmail.com> > > > wrote: > > > > > > > I'm also in favor, very much so. Life is too short to hold strong > > opinions > > > > about code style; you get used to whatever you're accustomed to > > seeing. And > > > > I support using automation to remove manual nuisances like this. > > > > > > > > Neal > > > > > > > > On Thu, Mar 26, 2020 at 3:49 PM Wes McKinney <wesmck...@gmail.com> > > wrote: > > > > > > > > > I'm in favor of this even though I also probably won't like some of > > > > > the formatting decisions it makes. Is there a sense of how far away > > > > > Black is from having Cython support? I saw it was being worked on a > > > > > while back. > > > > > > > > > > On Thu, Mar 26, 2020 at 2:37 PM Joris Van den Bossche > > > > > <jorisvandenboss...@gmail.com> wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > I would like to propose adopting Black as code formatter within the > > > > > python > > > > > > project. There is an older JIRA issue about this ( > > > > > > https://issues.apache.org/jira/browse/ARROW-5176), but bringing > > it to > > > > > the > > > > > > mailing list for wider attention. > > > > > > > > > > > > Black (https://github.com/ambv/black) is a tool for automatically > > > > > > formatting python code in ways which flake8 and our other linters > > > > approve > > > > > > of (and fill a similar role to clang-format for C++ and > > cmake-format > > > > for > > > > > > cmake). It can also be added to the linting checks on CI and to the > > > > > > pre-commit hooks like we now run flake8. > > > > > > Using it ensures python code will be formatted consistently, and > > more > > > > > > importantly automates this formatting, letting you focus on more > > > > > important > > > > > > matters. > > > > > > > > > > > > Black makes some specific formatting choices, and not everybody (me > > > > > > included) will always like those choices (that's how it goes with > > > > > something > > > > > > subjective like formatting). But my experience with using it in > > some > > > > > other > > > > > > big python projects (pandas, dask) has been very positive. You very > > > > > quickly > > > > > > get used to how it looks, while it is much nicer to not have to > > worry > > > > > about > > > > > > formatting anymore. > > > > > > > > > > > > Best, > > > > > > Joris > > > > > > > > > > > > > >
