Re: Export symbol guidelines

It is probably safer to namespace those symbols On Thu, Jan 17, 2019 at 11:51 AM shyam narayan singh wrote: > > Vendored code is part of the arrow. Gandiva is just the caller of the > timezone apis. > > Regards > Shyam > > On Thu, Jan 17, 2019 at 11:06 PM Antoine Pitrou wrote: > > > > > Side not

Re: Export symbol guidelines

Vendored code is part of the arrow. Gandiva is just the caller of the timezone apis. Regards Shyam On Thu, Jan 17, 2019 at 11:06 PM Antoine Pitrou wrote: > > Side note: why do those symbols appear in libarrow.so and not > libgandiva.so? > > Regards > > Antoine. > > > Le 17/01/2019 à 18:35, Anto

Re: Export symbol guidelines

Side note: why do those symbols appear in libarrow.so and not libgandiva.so? Regards Antoine. Le 17/01/2019 à 18:35, Antoine Pitrou a écrit : > > Le 17/01/2019 à 18:29, shyam narayan singh a écrit : >> Hi >> >> 1. The symbols are "locate_zone" and "to_sys" that are part of >> cast_time.cc. T

Re: Export symbol guidelines

Le 17/01/2019 à 18:29, shyam narayan singh a écrit : > Hi > > 1. The symbols are "locate_zone" and "to_sys" that are part of > cast_time.cc. These are invoked during casting timestamp with timezone > present. > 2. I am trying different things. I just made the symbols hidden to see the > affect.

Re: Export symbol guidelines

Hi 1. The symbols are "locate_zone" and "to_sys" that are part of cast_time.cc. These are invoked during casting timestamp with timezone present. 2. I am trying different things. I just made the symbols hidden to see the affect. "manylinux" passed while the others failed. 3. Couple of approaches

Re: Export symbol guidelines

Le 17/01/2019 à 17:44, shyam narayan singh a écrit : > Hi > > As part of the timestamp support , > we vendored the Howard hinnant date project. > > I had to export the compiled symbols. Can you elaborate on this? Is it because the symbols have to be