It is probably safer to namespace those symbols
On Thu, Jan 17, 2019 at 11:51 AM shyam narayan singh <shyambits2...@gmail.com> wrote: > > Vendored code is part of the arrow. Gandiva is just the caller of the > timezone apis. > > Regards > Shyam > > On Thu, Jan 17, 2019 at 11:06 PM Antoine Pitrou <anto...@python.org> wrote: > > > > > Side note: why do those symbols appear in libarrow.so and not > > libgandiva.so? > > > > Regards > > > > Antoine. > > > > > > Le 17/01/2019 à 18:35, Antoine Pitrou a écrit : > > > > > > Le 17/01/2019 à 18:29, shyam narayan singh a écrit : > > >> Hi > > >> > > >> 1. The symbols are "locate_zone" and "to_sys" that are part of > > >> cast_time.cc. These are invoked during casting timestamp with timezone > > >> present. > > >> 2. I am trying different things. I just made the symbols hidden to see > > the > > >> affect. "manylinux" passed while the others failed. > > >> 3. Couple of approaches > > >> a. relax the constraints > > >> b.move the the vendored code to arrow/vendored namespace. > > > > > > Ideally we don't want to change the vendored code at all (except at the > > > very beginning and end of the file). I'm not sure it's possible to > > > implement b) under that constraint. > > > > > > Regards > > > > > > Antoine. > > > > >
