Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-10-06 Thread Joris Van den Bossche
Worth noting that here were some minor changes made to the spec while the vote was active: - The "uniform_dimensions" metadata key was removed, since this can also be inferred from the "uniform_shape" information - The shape of non-constant dimensions in the "uniform_shape" entry is now represente

Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-10-06 Thread Rok Mihevc
Hey All, We have 4 binding +1 votes, no non-binding +1 votes, and no -1 votes, so the vote passes. Thanks everyone for your work and participation on this! As a follow up we will: [ ] merge changes to the format ( https://github.com/apache/arrow/pull/37166/files) [ ] merge C++ and Python impleme

Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-10-02 Thread Rok Mihevc
+1 Thanks everyone for voting! I'd like to leave the vote open until Wednesday, Rok On Fri, Sep 29, 2023 at 8:58 PM Matt Topol wrote: > +1 > > Thanks for all the work here! > > On Fri, Sep 29, 2023 at 11:04 AM Dewey Dunnington > wrote: > > > +1! Thank you for iterating on this with all of us!

Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-09-29 Thread Matt Topol
+1 Thanks for all the work here! On Fri, Sep 29, 2023 at 11:04 AM Dewey Dunnington wrote: > +1! Thank you for iterating on this with all of us! > > On Fri, Sep 29, 2023 at 11:28 AM Alenka Frim > wrote: > > > > +1 > > Thanks for pushing this through! > > > > On Wed, Sep 27, 2023 at 2:44 PM Rok

Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-09-29 Thread Dewey Dunnington
+1! Thank you for iterating on this with all of us! On Fri, Sep 29, 2023 at 11:28 AM Alenka Frim wrote: > > +1 > Thanks for pushing this through! > > On Wed, Sep 27, 2023 at 2:44 PM Rok Mihevc wrote: > > > Hi all, > > > > Following the discussion [1][2] I would like to propose a vote to add > >

Re: [VOTE][Format] Variable shape tensor canonical extension type

2023-09-29 Thread Alenka Frim
+1 Thanks for pushing this through! On Wed, Sep 27, 2023 at 2:44 PM Rok Mihevc wrote: > Hi all, > > Following the discussion [1][2] I would like to propose a vote to add > variable shape tensor canonical extension type language to > CanonicalExtensions.rst [3] as written below. > A draft C++ imp

[VOTE][Format] Variable shape tensor canonical extension type

2023-09-27 Thread Rok Mihevc
Hi all, Following the discussion [1][2] I would like to propose a vote to add variable shape tensor canonical extension type language to CanonicalExtensions.rst [3] as written below. A draft C++ implementation and a Python wrapper can be seen here [2]. The vote will be open for at least 72 hours.