I opened PR for "MINOR" changes https://github.com/apache/arrow/pull/9763
On Sun, Mar 21, 2021 at 8:59 AM Antoine Pitrou wrote:
>
> Ok, then it sounds ok to me.
>
> Regards
>
> Antoine.
>
>
> Le 20/03/2021 à 20:05, Wes McKinney a écrit :
> > FTR "[MINOR]" is what Apache Spark uses, e.g.
> >
> >
Ok, then it sounds ok to me.
Regards
Antoine.
Le 20/03/2021 à 20:05, Wes McKinney a écrit :
FTR "[MINOR]" is what Apache Spark uses, e.g.
https://github.com/apache/spark/commit/14ad7afa1aa0f3bfd75f1bf076a27af792721190
So, we pick our poison
On Sat, Mar 20, 2021 at 2:59 PM Andrew Lamb wr
I don't have a strong opinion on naming.
I think either way for this and the auto jira creation script we should
have established guidelines for when there use is appropriate (if we think
we need a formal vote on the ones proposed above I can start one).
My preference would be to trust contributo
FTR "[MINOR]" is what Apache Spark uses, e.g.
https://github.com/apache/spark/commit/14ad7afa1aa0f3bfd75f1bf076a27af792721190
So, we pick our poison
On Sat, Mar 20, 2021 at 2:59 PM Andrew Lamb wrote:
>
> Thanks Micah,
>
> I am happy to merge https://github.com/apache/arrow/pull/9598 if that is
Thanks Micah,
I am happy to merge https://github.com/apache/arrow/pull/9598 if that is
the PR you are referring to -- I think there was some concern that such a
feature would encourage less use of JIRA and thus even though using the
functionionaly is entirely optional, there were some objections.
Well, minor fixes are not necessarily straightforward, and we don't want
to encourage people skipping on JIRA creation.
Regards
Antoine.
Le 20/03/2021 à 19:30, Wes McKinney a écrit :
"MINOR:" might be a better marker since "trivial" carries the
connotation of "unimportant" to me (the dict
"MINOR:" might be a better marker since "trivial" carries the
connotation of "unimportant" to me (the dictionary says "of little
value or importance").
On Sat, Mar 20, 2021 at 2:21 PM Micah Kornfield wrote:
>
> Opened https://issues.apache.org/jira/browse/ARROW-12034 for trivial PRs.
>
> I think
Opened https://issues.apache.org/jira/browse/ARROW-12034 for trivial PRs.
I think for the auto-open JIRA PR that spurred some of this conversation we
should merge it and update the guidelines for committers (I think these are
on confluence now?). Thoughts?
On Sat, Mar 6, 2021 at 4:59 AM Andrew L
Thanks for the ideas Micah,
I like most of the ideas you have put forth. One way to make some small
step towards this goal might be:
1. Document, as you describe, some guidelines for trivial PRs (I like your
definitions)
2. Update the bot message that requests people to open a JIRA (e.g. [1]) so
t
Thanks, Micah, for setting up this discussion.
Regarding a GitHub action to make JIRA issues from GitHub issues/PRs, I'm
all in favor of that, though I think it should not be automatic but rather
triggered by a comment on the issue/PR. Sometimes a GitHub issue is a
question with a simple answer, a
Le 05/03/2021 à 06:15, Micah Kornfield a écrit :
2. Guidelines for trivial/minor patches (those not requiring a JIRA) and
updating the PR tool to accept a title indicating them as such. I would
propose the following fall under the trivial guideline:
a. Grammar, usage and spelling fixes
Hi Everyone,
I am writing to give a bump to some of what was written in reply to
Andrew's thread on auto-creating JIRAs. I would like to try to focus on
small (hopefully) short term achievable items, to make the community
friendlier to newcomers and reduce toil for regular contributors.
1. I thi
12 matches
Mail list logo
