Opened https://issues.apache.org/jira/browse/ARROW-12034 for trivial PRs.
I think for the auto-open JIRA PR that spurred some of this conversation we should merge it and update the guidelines for committers (I think these are on confluence now?). Thoughts? On Sat, Mar 6, 2021 at 4:59 AM Andrew Lamb <al...@influxdata.com> wrote: > Thanks for the ideas Micah, > > I like most of the ideas you have put forth. One way to make some small > step towards this goal might be: > 1. Document, as you describe, some guidelines for trivial PRs (I like your > definitions) > 2. Update the bot message that requests people to open a JIRA (e.g. [1]) so > that it is clearer that for trivial PRs (as defined above) JIRA isn't > necessary. > > I think that would at least > > > For example, the text could be something like: > > ``` > Thanks for opening a pull request! > > If this is a non trivial pull request (link to definition of trivial) can > you open an issue for this pull request on JIRA? For non trivial PRs it is > good practice to discuss the idea prior to PR on the mailing list or in > JIRA to uncover any potential hurdles prior to spending too much time > coding. > ``` > > Andrew > > [1] https://github.com/apache/arrow/pull/9624#issuecomment-789694328 > > On Fri, Mar 5, 2021 at 11:23 AM Neal Richardson < > neal.p.richard...@gmail.com> > wrote: > > > Thanks, Micah, for setting up this discussion. > > > > Regarding a GitHub action to make JIRA issues from GitHub issues/PRs, I'm > > all in favor of that, though I think it should not be automatic but > rather > > triggered by a comment on the issue/PR. Sometimes a GitHub issue is a > > question with a simple answer, and sometimes you make a PR and either > > forget to link the existing JIRA or put the wrong issue number on it. A > > comment action still lets you make the JIRA without leaving GitHub. > > > > The other thing that would be nice would be some sort of script/action > that > > makes it easy to add a JIRA user to the "contributors" role so that they > > can be assigned issues. I find that I often have to do this after merging > > someone's first PR, so we could add something to the PR merge tool that > > when an issue is "NOT ASSIGNED!", it asks if you want to assign to the > > reporter, and if the reporter is not a "contributor", add them to that > role > > first. That's not the only time it comes up (and if we start having more > > JIRAs created from GitHub issues/PR by a bot user, it won't be as > helpful), > > but it would be a start. > > > > Neal > > > > On Fri, Mar 5, 2021 at 3:08 AM Antoine Pitrou <anto...@python.org> > wrote: > > > > > > > > Le 05/03/2021 à 06:15, Micah Kornfield a écrit : > > > > > > > > 2. Guidelines for trivial/minor patches (those not requiring a JIRA) > > and > > > > updating the PR tool to accept a title indicating them as such. I > > would > > > > propose the following fall under the trivial guideline: > > > > a. Grammar, usage and spelling fixes that affect no more than N > > > files > > > > b. Documentation updates affecting no more than N files and not > > > more > > > > than M words. > > > > > > I suggest prefixing the PR title with "TRIVIAL: " (instead of the usual > > > "JIRA-XXX: "). > > > > > > Regards > > > > > > Antoine. > > > > > >
