Re: [C++] Minimum CMake version

Merged. In <20201220.11.982066485171320314@clear-code.com> "Re: [C++] Minimum CMake version" on Sun, 20 Dec 2020 15:55:51 +0900 (JST), Sutou Kouhei wrote: > Hi, > > I've implemented: > https://github.com/apache/arrow/pull/8972 > > If

Re: [C++] Minimum CMake version

Hi, I've implemented: https://github.com/apache/arrow/pull/8972 If there is no objection, I'll merge this. Thanks, -- kou In <20201217.065840.717408507431113090@clear-code.com> "[C++] Minimum CMake version" on Thu, 17 Dec 2020 06:58:40 +0900 (JST),

Re: [C++] Minimum CMake version

Le 16/12/2020 à 22:58, Sutou Kouhei a écrit : > Hi, > > We require CMake 3.2 or later. Can we require more newer > CMake? I don't to want to add workaround for CMake 3.2 like > this: > > https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79 > > # CMake 3.2 do

Re: [C++] Minimum CMake version

I support raising the minimum version. On Wed, Dec 16, 2020 at 3:59 PM Sutou Kouhei wrote: > Hi, > > We require CMake 3.2 or later. Can we require more newer > CMake? I don't to want to add workaround for CMake 3.2 like > this: > > > https://github.com/apache/arrow/blob/master/cpp/cmake_modules/

[C++] Minimum CMake version

Hi, We require CMake 3.2 or later. Can we require more newer CMake? I don't to want to add workaround for CMake 3.2 like this: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79 # CMake 3.2 does uppercase the FOUND variable if(re2Alt_FOUND OR RE2ALT_FOUND)