Merged. In <20201220.155551.982066485171320314....@clear-code.com> "Re: [C++] Minimum CMake version" on Sun, 20 Dec 2020 15:55:51 +0900 (JST), Sutou Kouhei <k...@clear-code.com> wrote:
> Hi, > > I've implemented: > https://github.com/apache/arrow/pull/8972 > > If there is no objection, I'll merge this. > > > Thanks, > -- > kou > > In <20201217.065840.717408507431113090....@clear-code.com> > "[C++] Minimum CMake version" on Thu, 17 Dec 2020 06:58:40 +0900 (JST), > Sutou Kouhei <k...@clear-code.com> wrote: > >> Hi, >> >> We require CMake 3.2 or later. Can we require more newer >> CMake? I don't to want to add workaround for CMake 3.2 like >> this: >> >> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/Findre2Alt.cmake#L78-L79 >> >> # CMake 3.2 does uppercase the FOUND variable >> if(re2Alt_FOUND OR RE2ALT_FOUND) >> >> >> Ubuntu 16.04 ships CMake 3.5.1: >> >> https://packages.ubuntu.com/search?keywords=cmake >> >> CentOS 7 doesn't ship CMake 3 but EPEL provides CMake 3.17: >> >> https://src.fedoraproject.org/rpms/cmake3/blob/epel7/f/cmake3.spec >> >> >> Can we require CMake 3.5 or later? >> >> >> Thanks, >> -- >> kou
