Re: [DISCUSS][C++] Indent #if (preprocessor directives)

+1 (non-binding) LGTM in Parquet part Best, Xuwei Fu Sutou Kouhei 于2024年8月28日周三 09:07写道： > Hi, > > How about indenting preprocessor directives for readability? > > Issue: https://github.com/apache/arrow/issues/43796 > PR: https://github.com/apache/arrow/pull/43798 > > For example: > > Before:

Re: [DISCUSS][C++] Indent #if (preprocessor directives)

+1 Definitely agree it improves readability, though it's gonna make for hellish PRs, so we should probably not go making this change all at once but instead do it as we happen to be working in files for things. That's my opinion at least. --Matt On Wed, Aug 28, 2024, 12:02 AM Ruoxi Sun wrote:

Re: [DISCUSS][C++] Indent #if (preprocessor directives)

+1. I think this definitely improves the readability. People no longer need to pair the mind-blowing deep-nested #if/#endif-s. Thanks for doing this! *Regards,* *Rossi SUN* On Wed, Aug 28, 2024 at 9:07 AM Sutou Kouhei wrote: > Hi, > > How about indenting preprocessor directives for readabili

[DISCUSS][C++] Indent #if (preprocessor directives)

Hi, How about indenting preprocessor directives for readability? Issue: https://github.com/apache/arrow/issues/43796 PR: https://github.com/apache/arrow/pull/43798 For example: Before: #ifndef NDEBUG #include "arrow/acero/options_internal.h" #endif After: #ifndef NDEBUG # inc

Re: [VOTE] Split Go release process

+1 (non-binding) On Tue, Aug 27, 2024 at 2:49 PM Uwe L. Korn wrote: > +1 (binding) > > On Tue, Aug 27, 2024, at 3:04 PM, Joris Van den Bossche wrote: > > +1 (binding) > > > > On Mon, 26 Aug 2024 at 09:56, Antoine Pitrou wrote: > >> > >> +1 (binding) > >> > >> Le 26/08/2024 à 04:37, Sutou Kouhei

Arrow community meeting August 28 at 16:00 UTC

Our next biweekly Arrow community meeting is tomorrow at 16:00 UTC / 12:00 EDT. Zoom meeting URL: https://zoom.us/j/87649033008?pwd=SitsRHluQStlREM0TjJVYkRibVZsUT09 Meeting ID: 876 4903 3008 Passcode: 958092 Meeting notes will be captured in this Google Doc: https://docs.google.com/document/d/1xr

Re: [VOTE] Split Go release process

+1 (binding) On Tue, Aug 27, 2024, at 3:04 PM, Joris Van den Bossche wrote: > +1 (binding) > > On Mon, 26 Aug 2024 at 09:56, Antoine Pitrou wrote: >> >> +1 (binding) >> >> Le 26/08/2024 à 04:37, Sutou Kouhei a écrit : >> > Hi, >> > >> > I would like to propose splitting Go release process. >> > >

Re: [VOTE] Split Go release process

+1 (binding) On Mon, 26 Aug 2024 at 09:56, Antoine Pitrou wrote: > > +1 (binding) > > Le 26/08/2024 à 04:37, Sutou Kouhei a écrit : > > Hi, > > > > I would like to propose splitting Go release process. > > > > Motivation: > > > > * We want to reduce needless major releases because major > >re