RE: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Yibo Cai
+1 (binding) Verified cpp/python/go on ubuntu20.04, aarch64 TEST_DEFAULT=0 TEST_CPP=1 TEST_PYTHON=1 TEST_GO=1 dev/release/verify-release-candidate.sh 15.0.0 1 -Original Message- From: Raúl Cumplido Sent: Wednesday, January 17, 2024 18:58 To: dev@arrow.apache.org Subject: [VOTE] Release

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
+1 (non-binding). Other than the aforementioned Go UT failure and a new found Python failure filed in issue [1] (likely trivial), I verified Go/C++/Python are OK on my Intel Mac. TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.0 1 [1] https://github.com/apach

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Matt Topol
Yea, I confirmed you're correct. I have a fix for this now and I've put up a PR[1] for it that Raul can cherry-pick into a new RC. --Matt [1]: https://github.com/apache/arrow/pull/39674 On Wed, Jan 17, 2024 at 2:15 PM Ruoxi Sun wrote: > My guts feeling is this has something to do with timezone

Re: invite to the #arrow-rust channel

2024-01-17 Thread Andrew Lamb
I sent an invite for Max. 455954986 I am not sure what you are asking -- can you please clarify? Thanks, Andrew On Wed, Jan 17, 2024 at 1:40 AM 455954986 <455954...@qq.com.invalid> wrote: > Thank you for the invitation. No questions asked. I look forward to > participating. What should I do nex

Re: [DISCUSS] Donation of a Spark native engine based on DataFusion & Arrow

2024-01-17 Thread Chao Sun
Hi Jacques, Do you mean instead of a single PR, we modify (e.g., git commit amend) all the commits that we have internally to remove any sensitive information, and open PRs for them against the above repo? I understand this will help readability and maintenance of the code, but it will be a lot o

Re: [DISCUSS] Donation of a Spark native engine based on DataFusion & Arrow

2024-01-17 Thread Jacques Nadeau
Thanks for the quick response Chao. My experience on these things is that maintaining commit history for large codebases can be invaluable for tracking down issues. (Hey, why is this code written this way-- oh, it was part of x patch that was trying to achieve y). In the past, I've used git commi

Re: [DISCUSS] Donation of a Spark native engine based on DataFusion & Arrow

2024-01-17 Thread Chao Sun
Hi Andy and Jacques, Thanks for setting the repo up. Yes we are working on cleaning up the internal repo and preparing to open a PR in the next few days. It's a bit difficult to retain the original commit history in the PR though since some of them contain internal info which we need to remove up

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
My guts feeling is this has something to do with timezone, I'm in UTC+8. If I change this line [1] to: testTime := time.Now().UTC() test passed. So for anyone who can't reproduce, maybe you can try change [1] to: loc, _ := time.LoadLocation("Asia/Shanghai") testTime := time.Now().In(loc) to

Re: [DISCUSS] Donation of a Spark native engine based on DataFusion & Arrow

2024-01-17 Thread Jacques Nadeau
Hey Chao, it would be great for you to share the code some place with commit history. (PR to the repo that Andy made or something else.) On Mon, Jan 15, 2024 at 7:38 AM Andy Grove wrote: > Hi Chao, > > I have created https://github.com/apache/arrow-datafusion-comet and you > should be able to cr

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Matt Topol
@pitrou Looks like the verification issue is the script just taking the system Go if it finds it rather than verifying it's at least Go 1.19+ so it should be pretty easy to fix that and not a release blocker. Regarding the unit test failure, it looks like I can't replicate it on my linux machine a

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Matt Topol
I'll take a look at that Go test failure in a bit. As for the ubuntu 22.04 verification failure, I'll double check that we're installing Go 1.19 for the verification and using the right PATH to it, I thought we addressed this but I guess something must have been overlooked. --Matt On Wed, Jan 17

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
Thanks Raúl, and sorry about the confusion. I should've used RC1. Now I just verified RC1 but the failure remains. What's more I tried on my two laptops (one Intel Mac and one M1 Mac), and got the same failure. *Regards,* *Rossi* Raúl Cumplido 于2024年1月18日周四 02:14写道: > Not sure what the issue

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
Not sure what the issue is with the test but could you use RC1 instead of RC0: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.0 1 instead of: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.0 0 El mié, 17 ene 2024 a las 19

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
Tried: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.0 0 But one of go test failed: ok github.com/apache/arrow/go/v15/arrow/flight/flightsql 4.990s 1970-01-01 12:00:00 + UTC --- FAIL: Test_fromArrowType (0.00s) --- FAIL: Test_fromArrowType/fr

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
+1 (binding) I've verified successfully the sources and binaries with: TEST_DEFAULT=0 TEST_SOURCE=1 dev/release/verify-release-candidate.sh 15.0.0 1 TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh 15.0.0 1 with: * Python 3.10.12 * gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
Hi, I have also generated the performance benchmark comparison between 14.0.0 and 15.0.0. It can be seen here [1]. Regards, Raúl [1] http://crossbow.voltrondata.com/release_reports/arrow-release-report-15.0.0-rc1.html El mié, 17 ene 2024 a las 18:10, Jean-Baptiste Onofré () escribió: > > Hi Ra

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Jean-Baptiste Onofré
Hi Raul, Yes, correct, it was my mistake: environment issue. It's now OK by using the correct node version. +1 (non binding) I will tackle the other minor issues/changes in coming PRs. Thanks ! Regards JB On Wed, Jan 17, 2024 at 5:56 PM Raúl Cumplido wrote: > > Jean-Baptiste, > > Are you usin

[DISCUSS][MATLAB] Proposed "Category B" License for Bundling MATLAB MEX Build Artifacts in Official Arrow Release

2024-01-17 Thread Sarah Gilmore
Hi Everyone, Kevin Gurney and I have been working on integrating the MATLAB Arrow bindings with the project's release processes in this pull request [1]. While working on integrating with the release tooling, we realized that we need to ensure that the licenses of any MEX artifacts [2] bundled

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
Jean-Baptiste, Are you using node 21? It seems related to this issue: https://github.com/apache/arrow/pull/39499 Kind regards, Raul El mié, 17 ene 2024, 17:03, Jean-Baptiste Onofré escribió: > +0.5 (non binding) > > I checked: > - hash and signature look good (NB: I think we can provide only >

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Jean-Baptiste Onofré
+0.5 (non binding) I checked: - hash and signature look good (NB: I think we can provide only sha512, no need to provide sha256 anymore imho) - no binary files found in the source distribution (py/pxd files are OK) - few files don't have or not correct ASF headers (for instance in cpp and r module

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Antoine Pitrou
Go verification fails on Ubuntu 22.04: ``` # google.golang.org/grpc ../../gopath/pkg/mod/google.golang.org/grpc@v1.58.3/server.go:2096:14: undefined: atomic.Int64 note: module requires Go 1.19 # github.com/apache/arrow/go/v15/arrow/avro arrow/avro/reader_types.go:594:16: undefined: fmt.Append

Re: [Discussion][C++][FlightRPC] What stage to submit a PR for Flight SQL ODBC driver

2024-01-17 Thread Jean-Baptiste Onofré
Hi David Thanks, I'm preparing the PR and checking legal/ASF aspects in the meantime. I will keep you posted asap. Sorry for the delay, I was busy with a couple of other PRs on Iceberg ;) Regards JB On Wed, Jan 10, 2024 at 4:19 PM David Li wrote: > > I've closed the PMC vote. Once I see the PR

Re: Ensuring compliance with ASF branding policy

2024-01-17 Thread Jean-Baptiste Onofré
Hi Andy Thanks for creating the issue. I will help with that. Regards JB On Sat, Jan 13, 2024 at 8:02 PM Andy Grove wrote: > > It was recently brought to the attention of the Arrow PMC that some of our > documentation and other web content is not fully compliant with the ASF > branding policy.

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
Hi, Just a minor note. All source verification and binary generation jobs were successful but there were two failures on the binary verification jobs [1]. The verify-rc-binaries-wheels-macos-11-amd64 has been failing with a timeout error for several releases. I've opened [2] to follow up. The ver

[VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Raúl Cumplido
Hi, I would like to propose the following release candidate (RC1) of Apache Arrow version 15.0.0. This is a release consisting of 330 resolved GitHub issues[1]. This release candidate is based on commit: a61f4af724cd06c3a9b4abd20491345997e532c0 [2] The source release rc1 is hosted at [3]. The bi