My guts feeling is this has something to do with timezone, I'm in UTC+8.
If I change this line [1] to:
testTime := time.Now().UTC()
test passed.
So for anyone who can't reproduce, maybe you can try change [1] to:
loc, _ := time.LoadLocation("Asia/Shanghai")
testTime := time.Now().In(loc)
to increase the chance?
[1]
https://github.com/apache/arrow/blob/c170af41ba0c30b80aa4172da0b3637206368cf2/go/arrow/flight/flightsql/driver/utils_test.go#L90
*Regards,*
*Rossi*
Matt Topol <zotthewiz...@gmail.com> 于2024年1月18日周四 02:55写道：
> @pitrou Looks like the verification issue is the script just taking the
> system Go if it finds it rather than verifying it's at least Go 1.19+ so it
> should be pretty easy to fix that and not a release blocker.
>
> Regarding the unit test failure, it looks like I can't replicate it on my
> linux machine and I don't have access to a mac at the moment. Would anyone
> happen to have a mac they can try to dig into and check out that unit test
> on? Otherwise I can spin up an AWS instance and try replicating and
> debugging on that if necessary.
>
> --Matt
>
> On Wed, Jan 17, 2024 at 1:30 PM Matt Topol <zotthewiz...@gmail.com> wrote:
>
> > I'll take a look at that Go test failure in a bit.
> >
> > As for the ubuntu 22.04 verification failure, I'll double check that
> we're
> > installing Go 1.19 for the verification and using the right PATH to it, I
> > thought we addressed this but I guess something must have been
> overlooked.
> >
> > --Matt
> >
> > On Wed, Jan 17, 2024 at 1:26 PM Ruoxi Sun <zanmato1...@gmail.com> wrote:
> >
> >> Thanks Raúl, and sorry about the confusion. I should've used RC1.
> >>
> >> Now I just verified RC1 but the failure remains. What's more I tried on
> my
> >> two laptops (one Intel Mac and one M1 Mac), and got the same failure.
> >>
> >>
> >> *Regards,*
> >> *Rossi*
> >>
> >>
> >> Raúl Cumplido <rau...@apache.org> 于2024年1月18日周四 02:14写道：
> >>
> >> > Not sure what the issue is with the test but could you use RC1 instead
> >> of
> >> > RC0:
> >> > TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1
> >> > ./verify-release-candidate.sh 15.0.0 1
> >> >
> >> > instead of:
> >> > TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1
> >> > ./verify-release-candidate.sh 15.0.0 0
> >> >
> >> > El mié, 17 ene 2024 a las 19:07, Ruoxi Sun (<zanmato1...@gmail.com>)
> >> > escribió:
> >> > >
> >> > > Tried:
> >> > >
> >> > > TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1
> >> > > ./verify-release-candidate.sh 15.0.0 0
> >> > >
> >> > > But one of go test failed:
> >> > >
> >> > > ok github.com/apache/arrow/go/v15/arrow/flight/flightsql
> >> 4.990s
> >> > > 1970-01-01 12:00:00 +0000 UTC
> >> > > --- FAIL: Test_fromArrowType (0.00s)
> >> > > --- FAIL: Test_fromArrowType/fromArrowType_date64_f16-d64
> (0.00s)
> >> > > utils_test.go:104: test failed, wanted time.Time 2024-01-17
> >> > > 00:00:00 +0000 UTC got time.Time 2024-01-18 00:00:00 +0000 UTC
> >> > > FAIL
> >> > > FAIL
> github.com/apache/arrow/go/v15/arrow/flight/flightsql/driver
> >> > > 5.821s
> >> > >
> >> > > *Regards,*
> >> > > *Rossi*
> >> > >
> >> > >
> >> > > Raúl Cumplido <rau...@apache.org> 于2024年1月18日周四 01:29写道：
> >> > >
> >> > > > +1 (binding)
> >> > > >
> >> > > > I've verified successfully the sources and binaries with:
> >> > > >
> >> > > > TEST_DEFAULT=0 TEST_SOURCE=1
> dev/release/verify-release-candidate.sh
> >> > > > 15.0.0 1
> >> > > > TEST_DEFAULT=0 TEST_BINARIES=1
> >> dev/release/verify-release-candidate.sh
> >> > > > 15.0.0 1
> >> > > > with:
> >> > > > * Python 3.10.12
> >> > > > * gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
> >> > > > * NVIDIA CUDA Build cuda_11.5.r11.5/compiler.30672275_0
> >> > > > * openjdk version "17.0.9" 2023-10-17
> >> > > > * ruby 3.0.2p107 (2021-07-07 revision 0db68f0233)
> >> [x86_64-linux-gnu]
> >> > > > * dotnet 7.0.115
> >> > > > * Ubuntu 22.04 LTS
> >> > > >
> >> > > > El mié, 17 ene 2024 a las 18:26, Raúl Cumplido (<
> rau...@apache.org
> >> >)
> >> > > > escribió:
> >> > > > >
> >> > > > > Hi,
> >> > > > >
> >> > > > > I have also generated the performance benchmark comparison
> between
> >> > > > > 14.0.0 and 15.0.0. It can be seen here [1].
> >> > > > >
> >> > > > > Regards,
> >> > > > > Raúl
> >> > > > >
> >> > > > > [1]
> >> > > >
> >> >
> >>
> http://crossbow.voltrondata.com/release_reports/arrow-release-report-15.0.0-rc1.html
> >> > > > >
> >> > > > > El mié, 17 ene 2024 a las 18:10, Jean-Baptiste Onofré
> >> > > > > (<j...@nanthrax.net>) escribió:
> >> > > > > >
> >> > > > > > Hi Raul,
> >> > > > > >
> >> > > > > > Yes, correct, it was my mistake: environment issue.
> >> > > > > > It's now OK by using the correct node version.
> >> > > > > >
> >> > > > > > +1 (non binding)
> >> > > > > >
> >> > > > > > I will tackle the other minor issues/changes in coming PRs.
> >> > > > > >
> >> > > > > > Thanks !
> >> > > > > > Regards
> >> > > > > > JB
> >> > > > > >
> >> > > > > > On Wed, Jan 17, 2024 at 5:56 PM Raúl Cumplido <
> >> > raulcumpl...@gmail.com>
> >> > > > wrote:
> >> > > > > > >
> >> > > > > > > Jean-Baptiste,
> >> > > > > > >
> >> > > > > > > Are you using node 21? It seems related to this issue:
> >> > > > > > > https://github.com/apache/arrow/pull/39499
> >> > > > > > >
> >> > > > > > > Kind regards,
> >> > > > > > > Raul
> >> > > > > > >
> >> > > > > > > El mié, 17 ene 2024, 17:03, Jean-Baptiste Onofré <
> >> > j...@nanthrax.net>
> >> > > > escribió:
> >> > > > > > >
> >> > > > > > > > +0.5 (non binding)
> >> > > > > > > >
> >> > > > > > > > I checked:
> >> > > > > > > > - hash and signature look good (NB: I think we can provide
> >> only
> >> > > > > > > > sha512, no need to provide sha256 anymore imho)
> >> > > > > > > > - no binary files found in the source distribution (py/pxd
> >> > files
> >> > > > are OK)
> >> > > > > > > > - few files don't have or not correct ASF headers (for
> >> > instance in
> >> > > > cpp
> >> > > > > > > > and r modules). It's not a blocker for this release but I
> >> will
> >> > > > open a
> >> > > > > > > > PR for discussion, upgrading RAT as well.
> >> > > > > > > > - LICENSE and NOTICE are there and correct
> >> > > > > > > > - I have a build issue on JS module on Mac M1:
> >> > > > > > > >
> >> > > > > > > > [16:59:25] 'compile:es2015:umd' errored after 1.03 s
> >> > > > > > > > [16:59:25] Error: [16:59:24] 'compile:es2015:umd' errored
> >> after
> >> > > > 1.57 ms
> >> > > > > > > > [16:59:24] TypeError: Function.prototype.apply was called
> on
> >> > > > > > > > undefined, which is a undefined and not a function
> >> > > > > > > > at Lo
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/esm/esm.js:1:233359)
> >> > > > > > > > at au
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/esm/esm.js:1:236294)
> >> > > > > > > > at ou
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/esm/esm.js:1:236969)
> >> > > > > > > > at Module.<anonymous>
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/esm/esm.js:1:304731)
> >> > > > > > > > at require
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/esm/esm.js:1:288360)
> >> > > > > > > > at
> >> > > > > > > >
> >> > > >
> >> >
> file:///Users/jbonofre/apache-arrow-15.0.0/js/gulp/closure-task.js:46:46
> >> > > > > > > > at Array.reduce (<anonymous>)
> >> > > > > > > > at closure
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (file:///Users/jbonofre/apache-arrow-15.0.0/js/gulp/closure-task.js:43:60)
> >> > > > > > > > at fn
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (file:///Users/jbonofre/apache-arrow-15.0.0/js/gulp/memoize-task.js:31:41)
> >> > > > > > > > at compile
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (file:///Users/jbonofre/apache-arrow-15.0.0/js/gulp/compile-task.js:30:86)
> >> > > > > > > > [16:59:24] 'compile' errored after 4 ms
> >> > > > > > > > at formatError
> >> > > > > > > >
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/gulp-cli/lib/versioned/^4.0.0/format-error.js:21:10)
> >> > > > > > > > at Gulp.<anonymous>
> >> > > > > > > >
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/gulp-cli/lib/versioned/^4.0.0/log/events.js:33:15)
> >> > > > > > > > at Gulp.emit (node:events:531:35)
> >> > > > > > > > at Gulp.emit (node:domain:488:12)
> >> > > > > > > > at Object.error
> >> > > > > > > >
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/undertaker/lib/helpers/createExtensions.js:61:10)
> >> > > > > > > > at handler
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/now-and-later/lib/mapSeries.js:47:14)
> >> > > > > > > > at f
> >> > > > > > > >
> >> > > >
> >> >
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/once/once.js:25:25)
> >> > > > > > > > at f
> >> > > > > > > >
> >> > > >
> >> >
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/once/once.js:25:25)
> >> > > > > > > > at tryCatch
> >> > > > > > > >
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/bach/node_modules/async-done/index.js:24:15)
> >> > > > > > > > at done
> >> > > > > > > >
> >> > > >
> >> >
> >>
> (/Users/jbonofre/apache-arrow-15.0.0/js/node_modules/bach/node_modules/async-done/index.js:40:12)
> >> > > > > > > > [16:59:25] 'build:es2015:umd' errored after 19 s
> >> > > > > > > > [16:59:25] 'build:apache-arrow' errored after 19 s
> >> > > > > > > >
> >> > > > > > > > I'm investigating.
> >> > > > > > > >
> >> > > > > > > > Regards
> >> > > > > > > > JB
> >> > > > > > > >
> >> > > > > > > > On Wed, Jan 17, 2024 at 11:58 AM Raúl Cumplido <
> >> > rau...@apache.org>
> >> > > > wrote:
> >> > > > > > > > >
> >> > > > > > > > > Hi,
> >> > > > > > > > >
> >> > > > > > > > > I would like to propose the following release candidate
> >> > (RC1) of
> >> > > > Apache
> >> > > > > > > > > Arrow version 15.0.0. This is a release consisting of
> 330
> >> > > > > > > > > resolved GitHub issues[1].
> >> > > > > > > > >
> >> > > > > > > > > This release candidate is based on commit:
> >> > > > > > > > > a61f4af724cd06c3a9b4abd20491345997e532c0 [2]
> >> > > > > > > > >
> >> > > > > > > > > The source release rc1 is hosted at [3].
> >> > > > > > > > > The binary artifacts are hosted at
> >> > [4][5][6][7][8][9][10][11].
> >> > > > > > > > > The changelog is located at [12].
> >> > > > > > > > >
> >> > > > > > > > > Please download, verify checksums and signatures, run
> the
> >> > unit
> >> > > > tests,
> >> > > > > > > > > and vote on the release. See [13] for how to validate a
> >> > release
> >> > > > > > > > candidate.
> >> > > > > > > > >
> >> > > > > > > > > See also a verification result on GitHub pull request
> >> [14].
> >> > > > > > > > >
> >> > > > > > > > > The vote will be open for at least 72 hours.
> >> > > > > > > > >
> >> > > > > > > > > [ ] +1 Release this as Apache Arrow 15.0.0
> >> > > > > > > > > [ ] +0
> >> > > > > > > > > [ ] -1 Do not release this as Apache Arrow 15.0.0
> >> because...
> >> > > > > > > > >
> >> > > > > > > > > [1]:
> >> > > > > > > >
> >> > > >
> >> >
> >>
> https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A15.0.0+is%3Aclosed
> >> > > > > > > > > [2]:
> >> > > > > > > >
> >> > > >
> >> >
> >>
> https://github.com/apache/arrow/tree/a61f4af724cd06c3a9b4abd20491345997e532c0
> >> > > > > > > > > [3]:
> >> > > > > > > >
> >> > > >
> >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-15.0.0-rc1
> >> > > > > > > > > [4]:
> >> https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
> >> > > > > > > > > [5]:
> >> > https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
> >> > > > > > > > > [6]:
> https://apache.jfrog.io/artifactory/arrow/centos-rc/
> >> > > > > > > > > [7]:
> https://apache.jfrog.io/artifactory/arrow/debian-rc/
> >> > > > > > > > > [8]:
> >> > > > https://apache.jfrog.io/artifactory/arrow/java-rc/15.0.0-rc1
> >> > > > > > > > > [9]:
> >> > > > https://apache.jfrog.io/artifactory/arrow/nuget-rc/15.0.0-rc1
> >> > > > > > > > > [10]:
> >> > > > https://apache.jfrog.io/artifactory/arrow/python-rc/15.0.0-rc1
> >> > > > > > > > > [11]:
> >> https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> >> > > > > > > > > [12]:
> >> > > > > > > >
> >> > > >
> >> >
> >>
> https://github.com/apache/arrow/blob/a61f4af724cd06c3a9b4abd20491345997e532c0/CHANGELOG.md
> >> > > > > > > > > [13]:
> >> > > > > > > >
> >> > > >
> >> >
> >>
> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> >> > > > > > > > > [14]: https://github.com/apache/arrow/pull/39641
> >> > > > > > > >
> >> > > >
> >> >
> >>
> >
>
