jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719
Hello Tomasz, I don't want to rush you, but if writing a test is proving to
be time consuming or complicated, do let me know and I'll merge this fix (which
looks good to me) and I'll add a tes
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202
Hi, actually I had problems running the tests in the first place. When I
build the project the tests do not seem to be executed (build pass even when I
introduce failing assertion). I can late
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691
> When I build the project the tests do not seem to be executed
Some of the tasks in Ant, including the `junitlauncher` aren't part of the
"core". You will have to first fetch the depen
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632
Thanks. I will give it a try and let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1420290634
Hi ,tomcat10 change javax.* namespace to jakarta.*， Does ant now support
jakarta.mail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
bodewig commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421399930
https://ant.apache.org/manual/Tasks/mail.html - Ant 1.10.13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421837416
Thanks, JakartaMimeMailer.java use jakarta.mail . I downdload
org.apache.ant-ant-1.10.13
jar(url:https://mvnrepository.com/artifact/org.apache.ant/ant/1.10.13). In this
jar , not found Jakar
jaikiran commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421877210
Hello @Wade-tech, it will be present in the ant-jakartamail artifact which
is here https://repo1.maven.org/maven2/org/apache/ant/ant-jakartamail/1.10.13/
--
This is an automated message fro
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421930331
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
bodewig commented on PR #198:
URL: https://github.com/apache/ant/pull/198#issuecomment-1422055507
I must say I find it extremely difficult to properly review a PR that
touches 100+ files, even if the change is supposed to be mechanical.
In this case I saw a change to `Antlib.java` whe
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1436945641
@jaikiran I'm sorry but I was unable to run the tests. After implementing
your instructions the `LegacyXmlResultFormatterTest` was run but there was no
mention of `JUnitLauncherTaskTest` being
dreis2211 opened a new pull request, #199:
URL: https://github.com/apache/ant/pull/199
Hi,
I've noticed that working with `checkstyle` via Gradle (probably using it
directly will do the same) we always see the very verbose output of the
stylesheet being loaded. Imho this is not a goo
jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
dreis2211 commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118662584
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446237933
Thank you for these changes. Looks good to me. I'll merge this shortly.
Since this is your first contribution to the Ant project, I'll be adding
`Christoph Dreis` to our contributors list
htt
asfgit closed pull request #199: Use verbose log level for loading stylesheets
URL: https://github.com/apache/ant/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553
I wonder what kind of `Resource` this is as `Resource#toString` is expected
to only print the resource's name - and this is what the code here relied on.
Looks as if `StringResource` printed i
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401
Hello Stefan,
> Looks as if StringResource printed its contents, but that seems wrong to
me as there may be more places where code expects toString to not reveal the
contents.
Ag
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446269521
I'll create a bugzilla issue to scan for Resource#toString uses. This change
here is fine as it is and we don't need to clutter it with more discussion.
Thank you for catching this @dreis
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446276764
https://bz.apache.org/bugzilla/show_bug.cgi?id=66496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tbw777 closed pull request #198: Using static modifier to normalize methods
contract and performance
URL: https://github.com/apache/ant/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jglick opened a new pull request, #200:
URL: https://github.com/apache/ant/pull/200
Fixes https://github.com/spotbugs/spotbugs-maven-plugin/issues/423. When
running on Java 18+, where `System.setSecurityManager` is not allowed by
default, just let in-process Java execution run without a sec
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503324250
Hello Jesse, I'm currently in the process of undoing some of the work we had
done in a recent release to set `java.security.manager=allow` when launching
Ant. This change has caused more than
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503392846
> the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
82c70f3 I guess. Yes I think it would be appropriate to not even attempt to
call `setSec
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503458393
> > the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
>
>
[82c70f3](https://github.com/apache/ant/commit/82c70f3202d5aec4d99fa3b6314ba4a6c
mabartos commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1511152337
@jaikiran Hello, any progress with this issue? Or is there any workaround
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1512565293
The change in this PR looks fine to me. A test can be added separately - I
haven't found the time to try and help you get the test implemented/run. I'll
go ahead and merge this now and will ad
asfgit closed pull request #197: Handling forked VM timeout in a similar way to
junit ant task
URL: https://github.com/apache/ant/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
apupier commented on PR #62:
URL: https://github.com/apache/ant-ivy/pull/62#issuecomment-1558743234
long time without progress and no more in my scope of work. Closing. feel
free to reuse my work if needed
--
This is an automated message from the Apache Git Service.
To respond to the mess
apupier closed pull request #62: IVY-1572 - Check for Thread interruption while
resolving resources
URL: https://github.com/apache/ant-ivy/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
arturobernalg closed pull request #163: Make final var when is possible.
URL: https://github.com/apache/ant/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
arturobernalg closed pull request #165: Use object equals instead of ==, which
does a character-by-character comparison when the strings are different objects
URL: https://github.com/apache/ant/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1631739432
Sorry everyone, my testing with the changes I have is taking longer than
expected. @stevenschlansker, are you running these tests by building Ant from
source? If yes, then I'll go ahead and me
didiksupriadi41 closed pull request #97: Remove unused dependencies
URL: https://github.com/apache/ant-ivy/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1632843378
> are you running these tests by building Ant from source?
@jaikiran why would you ask that?
https://github.com/apache/ant/pull/200#issuecomment-1631658175 reports an error
that looks ide
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1633231279
No, I am running the latest spotbugs-maven-plugin release, which uses Ant as
a library. The problem only manifests if you disable forking in the plugin
configuration.
--
This is an
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1633402124
Hello Jesse,
> > are you running these tests by building Ant from source?
>
> @jaikiran why would you ask that? [#200
(comment)](https://github.com/apache/ant/pull/200#issuecomment-16
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1634629922
> it would anyway require an Ant release
Yes, and then for `spotbugs-maven-plugin` to update to that release and cut
its own release.
--
This is an automated message from the Apache Git
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1673554885
Hello Jesse and Steven, I've pushed some commits to master branch which
reverts all the complex/brittle workarounds we had added in Ant 1.10.13 to keep
using SecurityManager.
A fresh se
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1675085764
Looks like this is indeed superseded by
689b6ea90ee1fbad580a437137d80609c9336f12 in particular. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
jglick closed pull request #200: Do not treat failure of
`System.setSecurityManager` as fatal
URL: https://github.com/apache/ant/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jaikiran commented on PR #121:
URL: https://github.com/apache/ant/pull/121#issuecomment-1675840246
Hello Vincent @don-vip,
> Can we please get the same output as JUnit 4?
Test.testMethod[displayedName]
I had forgottent about this. But now that I went backed and looked at it,
this
jaikiran commented on PR #121:
URL: https://github.com/apache/ant/pull/121#issuecomment-1675840459
I'll go ahead and close this PR since this was already delivered in Ant
1.10.10 release as part of https://bz.apache.org/bugzilla/show_bug.cgi?id=64564
--
This is an automated message from t
jaikiran closed pull request #121: use displayName instead of
legacyReportingName in xml reports
URL: https://github.com/apache/ant/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dependabot[bot] opened a new pull request, #201:
URL: https://github.com/apache/ant/pull/201
Bumps xalan:xalan from 2.7.2 to 2.7.3.
[ is in voting phase if you would like to
try it https://lists.apache.org/thread/th6yrxc4dtpqhc2vnzmrd7d9b881hk4g
--
This is an automated message from the
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1680938966
Thank you very much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
sratz opened a new pull request, #203:
URL: https://github.com/apache/ant/pull/203
PropertyOutputStream by default trims output.
This is undesired in the use case. Explicitly set it to false.
Fixes regression introduced in 1.10.13 /
90ed3ff6cca8634e38d7c3c82858ce48c9c4be2b.
jaikiran commented on PR #203:
URL: https://github.com/apache/ant/pull/203#issuecomment-1710984197
Hello Sebastian, thank you for reporting this issue and providing a fix that
too with a test case. This is a very well done patch. I've merged this and also
included your name in our contribut
jaikiran closed pull request #203: bz-67082 fix unintended trimmed string
output by pathconvert
URL: https://github.com/apache/ant/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jmichelberger opened a new pull request, #204:
URL: https://github.com/apache/ant/pull/204
In cases the Depend task scans a class file with Constant Pool entry Type
17 there was no handling, just fireing an Exception.
Constant is defined since JDK11, and format is same as InvokeDynamic
asfgit closed pull request #204: bz-66552 fix Depend task does not handle
Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant
Pool entry Type 17
URL: https://github.com/apache/ant/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the
jaikiran commented on PR #204:
URL: https://github.com/apache/ant/pull/204#issuecomment-1715096911
Thank you @jmichelberger for this patch, this looks OK to me and I've now
merged it and I have added you to our contributors list. The patch doesn't have
a test case, I'm guessing that you we
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722169214
Hello @mataha, what you propose here looks OK to me. However, I haven't been
able to reproduce the issue that prompted this change. Is there some specific
Windows version where this can be rep
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722247407
> Hello @mataha, what you propose here looks OK to me. However, I haven't
been able to reproduce the issue that prompted this change. Is there some
specific Windows version where this can be rep
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722284523
These, of course, can be run on all Windows versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
asfgit closed pull request #205: Fix `--release` param check in bootstrap.bat
URL: https://github.com/apache/ant/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-172236
Thank you @mataha for those details. I have now merged this PR and added you
(`Mateusz Kazimierczuk`) as a contributor to our contributors list.
--
This is an automated message from the Apac
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722502639
The pleasure is mine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Cmac299203 commented on PR #201:
URL: https://github.com/apache/ant/pull/201#issuecomment-1793953335
Awesome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
mfaquan opened a new pull request, #206:
URL: https://github.com/apache/ant/pull/206
Currently, if an IOException occurs in ReplaceRegExp or a file is missing,
the task logs the error, but does not fail. This pull request has
ReplaceRegExp throw a BuildException if the task encounters an I
bodewig commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1814953625
You are correct and I don't recall why the code works the way it does. But
it has done so for more than 20 years now and changing it might break existing
builds. Let me suggest to introduce a `
mfaquan commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815013377
> You are correct and I don't recall why the code works the way it does. But
it has done so for more than 20 years now and changing it might break existing
builds. Let me suggest to introduce a
bodewig commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815261409
looks good, thank you. We'll also need to change the manual page, which I
can do myself.
If you want to be listed in Ant's contributor's list, please let us know
which name you want us t
bodewig merged PR #206:
URL: https://github.com/apache/ant/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
mfaquan commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815320520
> looks good, thank you. We'll also need to change the manual page, which I
can do myself.
>
> If you want to be listed in Ant's contributor's list, please let us know
which name you wan
tg-freigmbh opened a new pull request, #207:
URL: https://github.com/apache/ant/pull/207
I realized that running tests using ant was much slower than running them
from the IDE. The culprit was the legacy-xml reporter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jaikiran merged PR #207:
URL: https://github.com/apache/ant/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
mkitti opened a new pull request, #99:
URL: https://github.com/apache/ant-ivy/pull/99
Currenty ivy does not include the classifier as a key for extra information.
This pull request adds classifier to the extra info key.
--
This is an automated message from the Apache Git Service.
To respo
mbs-c opened a new pull request, #100:
URL: https://github.com/apache/ant-ivy/pull/100
The namespaces of dependencies' extra attributes were forgotten before
writing them to the cache when a module descriptor was created from scratch.
With this change, namespaced attributes are correctly tr
mebigfatguy opened a new pull request, #208:
URL: https://github.com/apache/ant/pull/208
documentation says the attribute name for is arg, but it's
value. Updated doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jaikiran commented on PR #208:
URL: https://github.com/apache/ant/pull/208#issuecomment-1956990993
Thank you Dave for this fix. The change looks correct to me and matches the
`compilerarg` documentation of the `javac` task.
--
This is an automated message from the Apache Git Servi
jaikiran merged PR #208:
URL: https://github.com/apache/ant/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
lewismc opened a new pull request, #101:
URL: https://github.com/apache/ant-ivy/pull/101
PR to address https://issues.apache.org/jira/browse/IVY-1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
obsfeil opened a new pull request, #209:
URL: https://github.com/apache/ant/pull/209
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
jaikiran closed pull request #209: pull
URL: https://github.com/apache/ant/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
basil opened a new pull request, #210:
URL: https://github.com/apache/ant/pull/210
I am migrating from Commons Compress to Ant for tar/untar functionality,
since new releases of Commons Compress pull in unwanted dependencies, while new
releases of Ant are self-contained. But while doing so,
Seros commented on PR #101:
URL: https://github.com/apache/ant-ivy/pull/101#issuecomment-2133442798
Hey ^^ Just wanted to ask when we can expect this change to be merged as it
seems it's the only one left for the [next version
2.5.3](https://issues.apache.org/jira/issues?jql=project%20%3D%2
tkowalcz opened a new pull request, #211:
URL: https://github.com/apache/ant/pull/211
If the JVM of the monitored forked test hangs then `Process:destroy` might
not be effective. On unix systems it will send `SIGINT`. An alternative is to
use `Process: destroyForcibly` method to use `SIGKIL
jaikiran commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2266712802
Hello Tomasz, can you tell us the details of the issue you are running into?
That might help understand what change needs to be done.
--
This is an automated message from the Apache Git Serv
tkowalcz commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2267496463
> Hello Tomasz, can you tell us the details of the issue you are running
into? That might help understand what change needs to be done.
Absolutely. I just wanted to get the conversation
jaikiran commented on PR #211:
URL: https://github.com/apache/ant/pull/211#issuecomment-2281827658
Hello Tomasz,
> Tools like jstack were unable to attach to it unless -Force option was
used.
Were you able to get hold of a thread dump with `-F`?
This code dealing with pr
basil commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2318628836
Hey @jaikiran, great to see the 1.10.15 release of Ant is out. Can this
enhancement be considered for the next Ant release?
--
This is an automated message from the Apache Git Service.
To respo
jaikiran commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2321819107
Hello Basil, I'll need inputs from others on this one. Specifically because
this isn't just a technical change. I don't have enough historical knowledge
about the commons compress project, but
basil commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2321999138
Thanks for your reply @jaikiran. A search for "compress" in the Git history
shows a long history of @bodewig porting enhancements and fixes from Commons
Compress to Ant. Here are a few:
-
bodewig commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2322035548
The Commons Compress code base has been seeded (among other things) by code
originating from the Ant project. I used to be a committer (and release
manager) for Commons Compress and served the
basil commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2323423302
It is great to have the historical context and clearly articulated arguments
for and against this PR. This should help current maintainers to make an
informed decision. While I believe this unit-
basil commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2322499633
Thanks for the context, @bodewig. I would be happy to use Commons Compress
if it satisfied our dependency requirements, but I fully understand that this
decision is up to the current maintainers
bodewig commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2322833027
> but allow me to offer another perspective. Ideally there would be only one
Apache implementation of tar/untar functionality in Java.
Commons as a whole was born because of this idea. Th
1 - 100 of 142 matches
Mail list logo
