jaikiran commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401
Hello Stefan, > Looks as if StringResource printed its contents, but that seems wrong to me as there may be more places where code expects toString to not reveal the contents. Agreed. The `StringResource` is overriding the toString() to print the contents and that looked wrong to me too. However, it has an explicit `@since` on it so it looked to me that this might have been done intentionally for some reason. Like you say, there might be additional places we need to check where we log the `Resource.toString()` in a message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
