Re: task for antlib jars

2004-02-16 Thread Peter Reilly
using that file, delete it on exit explicitly. Will this work recursivly? I.e. when deleteing a directory Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: roles, restricted types

2004-02-17 Thread Peter Reilly
) we get to eat our own dogfood - using antlib/namespaces. 2) no need to make IntrospectionHelper more complicated. Peter Stefan Bodewig wrote: On Thu, 12 Feb 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: I have reactivated my code for restricted/roled types. I think we need that in

Re: Ant 1.7

2004-02-17 Thread Peter Reilly
ace, but at least for the core namespace you can. It is possible for any namespace, one however gets the warning: Attempting to override ... Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Ant 1.7

2004-02-17 Thread Peter Reilly
t requests. + DynamicConfigureNS + antlibize the optional tasks Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: REGRESSION: Ant 1.6+ doesn't detect duplicate targets

2004-02-18 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 18 Feb 2004, Jan Materne <[EMAIL PROTECTED]> wrote: But or Feature? :-) I think it is used as a feature with the task for target overriding... Peter I'd vote for bug. Stefan -

Re: Moving to Ant 1.6.1 => UnknownElements galor!

2004-02-18 Thread Peter Reilly
(types like fileset id=x). So.. interate over the tasks, if they are UEs, convert them to tasks, using UE#maybeConfigure and UE#getTask() This approach should work for ant1.5 and ant1.6. Peter Wascally Wabbit wrote: Ant Developers, I just did a quick Ant 1.5.4 -> 1.6.1 library switch. Ran our

Re: Moving to Ant 1.6.1 => UnknownElements galor!

2004-02-18 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 18 Feb 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: Your container class will need to check if the Task is an UnknownElement and call perform on it to convert it to a Task and to execute it. (see apache.tools.ant.taskdefs.Sequential) Peter, could you

Re: Ant 1.6.1 Converting Errors To Exceptions...Good|Bad?

2004-02-19 Thread Peter Reilly
Jose Alberto Fernandez wrote: From: Wascally Wabbit [mailto:[EMAIL PROTECTED] Ant Developers, I've come across (ok stumbled across) an implementation detail of the new Ant 1.6.1 "keepGoing" mode. The way the code is currently written Ant keeps going even if an Error (not an Exception) occurs. Thi

Peter Radics/SDE/Scania/DE ist außer Haus. [Web1-VirusChecked]

2004-02-20 Thread Peter . Radics
Ich werde ab 09.02.2004 nicht im Büro sein. Ich kehre zurück am 24.02.2004. Ich werde Ihre Nachricht nach meiner Rückkehr beantworten. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECT

Re: Moving to Ant 1.6.1 => UnknownElements galor!

2004-02-20 Thread Peter Reilly
Wascally Wabbit wrote: At 07:11 AM 2/19/2004, you wrote: On Wed, 18 Feb 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: > Your container class will need to check if the Task is > an UnknownElement and call perform on it to > convert it to a Task and to exe

Re: cvs commit: ant WHATSNEW

2004-02-20 Thread Peter Reilly
[EMAIL PROTECTED] wrote: mbenson 2004/02/19 13:14:16 Modified:src/testcases/org/apache/tools/ant/filters TokenFilterTest.java src/main/org/apache/tools/ant/filters TokenFilter.java src/etc/testcases/filters tokenfilter.xml .

Re: cvs commit: ant WHATSNEW

2004-02-20 Thread Peter Reilly
Opps, hit the send button too early. I meant to say good catch! Peter Peter Reilly wrote: [EMAIL PROTECTED] wrote: mbenson 2004/02/19 13:14:16 Modified:src/testcases/org/apache/tools/ant/filters TokenFilterTest.java src/main/org/apache/tools/ant

Re: [GUMP@lsd]: ant/test-ant failed

2004-02-20 Thread Peter Reilly
ides in import and 3 is plain evil. My vote goes for 1. Stefan I vote for 1 also. +1 for 1 Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: roles, restricted types

2004-02-20 Thread Peter Reilly
done at run time. [The current code does this mapping for ant-type at parse time]. My current feeling is that restricted types/roles are not necessary, one can use namespaces to distingish condition from selector . Peter - To

Re: roles, restricted types

2004-02-20 Thread Peter Reilly
Stefan Bodewig wrote: On Fri, 20 Feb 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: I meant that the core - conditions, filters, mappers can be in separate namespaces, but that these could still be in ant.jar, one can have multiple antlib.xml 's in ant.jar. Wouldn't that

Authors tag

2004-02-23 Thread Peter Reilly
t, but the Board is concerned about the legal ramifications around the use of author tags - it is quite acceptable and encouraged to recognize developers' efforts in a CHANGES file, or some other descriptive file which is associated with the overall PMC or release rather than individu

Re: Authors tag

2004-02-23 Thread Peter Reilly
Matt Benson wrote: --- Peter Reilly <[EMAIL PROTECTED]> wrote: Just noticed this in "ASF Board Summary for February 18, 2004" - author tags are officially discouraged. these I noticed this too. Could we change the checkstyle config to allow only whitespace as the @autho

Re: cvs commit: ant/src/etc/testcases/types filelist.xml

2004-02-23 Thread Peter Reilly
Hi, I have added a nested file element to filelist, used as follows: a) Is this change ok? b) Should it be in ant 1.6.2 c) Could someone run the unittests on windows please ;-) Peter [EMAIL PROTECTED] wrote: peterreilly2004/02/23 08:40:55 Modified:src/main/org/apache/tools

Re: cvs commit: ant/src/etc/testcases/types filelist.xml

2004-02-23 Thread Peter Reilly
noticed last week that duplicate targets were not detected in ant 1.6.*, so a test was put in. But no code was put in to fix the problem! I think that this should be added to the "teststhatfail" reference in build.xml until the fix for the problem is done. Peter Peter Reilly wrote: Hi, I ha

Re: cvs commit: ant build.xml

2004-02-23 Thread Peter Reilly
Antoine Lévy-Lambert wrote: [EMAIL PROTECTED] wrote: Hi Peter, I do not understand why you removed the dependency of run-single-test upon compile-tests,run-single-test-only There must be a good reason but I am surprised. I did not remove the dependency... There was a change last week (409) to

Re: Authors tag

2004-02-24 Thread Peter Reilly
case we should change cvs head and the 1.6 cvs head as well. Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: and XML NS hell ;-)

2004-02-24 Thread Peter Reilly
he enclosing type/task. You are missing a bm prefix from a nested include of a fileset element in a bm:lsync (i think) element. Also, is "sources" a typedef? Peter Thanks for any help. --DD - To unsubscribe,

Re: cvs diff format

2004-02-24 Thread Peter Reilly
Check the contents of your ~/.cvsrc file. It should have a line: diff -u Peter Matt Benson wrote: Hmm... formerly, when I would use "cvs diff somefile", the -u format would be used by default. Then out of nowhere the regular diff format starts being used by default. Does anyone know of

Re: and XML NS hell ;-)

2004-02-24 Thread Peter Reilly
.. } Then one can do: Peter Dominique Devienne wrote: From: Peter Reilly [mailto:[EMAIL PROTECTED] As regards the xml ns hell, I must agree - I still think that nested elements discovered through reflection should be in the ant core namespace as well as the namespace of the enclos

Re: cvs commit: ant WHATSNEW

2004-02-26 Thread Peter Reilly
nts. what about ? This is fine... works ok. Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: and XML NS hell ;-)

2004-02-26 Thread Peter Reilly
Dominique Devienne wrote: From: Peter Reilly [mailto:[EMAIL PROTECTED] Ah, I see, you are trying to use the contents of "sources" in javc and also in bm:lsync. This is indeed XML NS hell! The problem is that the ns uri and local name of the Unknown elements are given to the elements in t

Re: cvs commit: ant/src/etc/testcases/types filelist.xml

2004-02-26 Thread Peter Reilly
Hi Jan, as regards the tests - it looks like you are using the installed ant classes with the cvs ant test classes. Always with running the tests, I do: cd ~/cvs/ant rm -rf bootstrap build; ./build.sh test -Dtest.haltonfailure=yes Peter [EMAIL PROTECTED] wrote: a) Is this change ok? +1 b

Re: BugID 27282 Misspelling: s/occured/occurred/g

2004-02-27 Thread Peter Reilly
"occured" does look like it is mispelt! Peter [EMAIL PROTECTED] wrote: That Bug [1] is another mispelling-bug, so I´m carefully with that. The dictionary [2] confirms Jesses opinion, but babelfish [3] uses also "occured" while tranlating into German. So my question to the

Re: cvs commit: ant/src/etc/testcases/types filelist.xml

2004-02-27 Thread Peter Reilly
Antoine Lévy-Lambert wrote: Peter Reilly wrote: Hi, I have added a nested file element to filelist, used as follows: a) Is this change ok? Yes, it is OK. I do not understand too well the advantage of the filelist with nested element Well, the patch is just to make the filelist type

Re: Closing down ant-dev@jakarta and ant-user@jakarta?

2004-02-27 Thread Peter Reilly
Antoine Lévy-Lambert wrote: Matt Benson wrote: --- [EMAIL PROTECTED] wrote: +1 for closing. +1. -Matt +1 Antoine +1 Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED

Re: Ant build.xml: run "teststhatfail"

2004-02-27 Thread Peter Reilly
xcludes, http://cvs.apache.org/viewcvs.cgi/*checkout*/ant/build.xml?content-type=text%2Fplain&rev=1.290 and at one stage there was no tests that failed, soon afterwards, one was added back in (the beanshell one) but this did not have the excludes clause. Peter Jan 329: 330: 331:

Re: Ant build.xml: run "teststhatfail"

2004-02-27 Thread Peter Reilly
[EMAIL PROTECTED] wrote: Then I will add that again :) Or would it be better to add the if/unless to , I think so? yes, but does not support the if/unless attribute. Cheers, Peter - To unsubscribe, e-mail: [EMAIL PROTECTED

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Zip.java

2004-02-27 Thread Peter Reilly
Stefan Bodewig wrote: On 27 Feb 2004, <[EMAIL PROTECTED]> wrote: Log: A new roundup attribute on and related task Merge into the 1.6 branch? +1, We should keep 1.6 as up-to-date as possible, at least until the 1.7 core changes make this impossible.

Re: and XML NS hell ;-)

2004-03-03 Thread Peter Reilly
lines being changed, and one feels like an xml ns lawyer :-( Using the more relaxed rules only involves modifing a couple of lines and looks (IMO) a lot nicer: Peter Gus Heck wrote: Gus Heck wrote: re given to the elements in the calling macro. In a

Re: [PATCH] cvs docs

2004-03-03 Thread Peter Reilly
Commited, Thanks. Peter Shatzer, Larry wrote: A newer version of CVS has been released, updated links in document. Also a bit of tidying up. -- Larry Index: docs/manual/CoreTasks/cvs.html

Re: Authors tag

2004-03-03 Thread Peter Reilly
I feel like a vandal, but should we do this now? using http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27177 for the list of commiters Peter Stefan Bodewig wrote: On Tue, 24 Feb 2004, Conor MacNeill <[EMAIL PROTECTED]> wrote: We need to decide how we handle the author tags issue in t

Re: taskdefs inside an antlib and their classpath

2004-03-08 Thread Peter Reilly
implementation you can achieve most of what you want by using an with the resource and uri attributes, and hide this in an imported file: Where nytasker.xml looks something like this: Peter Mariano Benitez wrote: would it be very crazy to add a classpath

Re: and XML NS hell ;-)

2004-03-08 Thread Peter Reilly
macrodef as follows: and use it as follows: The same macrodef will not work if the goodtask and badtask are in different namespaced antlibs. Peter Gus Heck wrote: Hi Peter, Thanks for the long reply! I have a few questions and a

Re: Bug in macrodef?

2004-03-08 Thread Peter Reilly
Hi Dominique, There was a bug in macrodef's dealing of @@ (bugzilla 27069), fixed in current cvs. In the meantime "@${name}@" will get mapped to "@${name}@", as there is no attribute with the name "${name}". Peter Dominique Devienne wrote: I replaced the use

Re: taskdefs inside an antlib and their classpath

2004-03-08 Thread Peter Reilly
Mariano Benitez wrote: do you imply here that when you use with an already defined uri, being that an antlib uri, that it will add those definitions to the antlib uri? Yes, this is the way it works. For example: is the same as: and: Peter in your sample you are

Re: Authors tag

2004-03-09 Thread Peter Reilly
dot de slo Peter Stefan Bodewig wrote: On Wed, 03 Mar 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: I feel like a vandal, but should we do this now? +1 using http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27177 for the list of commiters I haven't checked that list mysel

Re: Authors tag

2004-03-09 Thread Peter Reilly
Hi Rob, Thanks, I did a google for Handlerson... Peter Anderson, Rob (Global Trade) wrote: rhanderson is me, Robert Anderson. Over the past few years I have been known as... rhanderson randerso rhanders rha4 rhande4 I have tried to use my hotmail address for most code submissions since that is

Re: Authors tag

2004-03-11 Thread Peter Reilly
Thanks, Peter Stefan Bodewig wrote: On Tue, 09 Mar 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: gg at grtmail dot com Gautam Guliani (used to be in Get.java before you removed it 8-) miha at softhome dot net Couldn't find anything but Miha. Mail him/her? skanthak a

Re: Authors tag

2004-03-11 Thread Peter Reilly
Thanks, googleing for "slo" was not too successful... Peter Steve Loughran wrote: Peter Reilly wrote: I have commited the removal of authors patch. I made a CONTRIBUTORS file at the top level containing the authors names - without corresponding e-mail addresses. The following name/e-mai

Re: cvs commit: ant/docs/manual/CoreTypes mapper.html

2004-03-12 Thread Peter Reilly
I waited to wait for the restricted types/roles question to be resolved before using s whole-scale for file mapper types, and I did not want to hard-code in addGlob() etc. Peter Matt Benson wrote: Most of the code is Peter's, to give credit where it's due. Peter, what was the reason

Re: cvs commit: ant/docs/manual/CoreTypes mapper.html

2004-03-12 Thread Peter Reilly
Thanks for committing the code and documenenting and writting the unit-tests! Peter Matt Benson wrote: Most of the code is Peter's, to give credit where it's due. Peter, what was the reason you wanted this to wait until 1.7? -Matt __ Do you Yahoo!? Yah

Re: Problem with +

2004-03-12 Thread Peter Reilly
ernativly you could use jython as the scripting language: file = project.resolveFile(r"@{file}") project.setNewProperty("@{property}", file.lastModified()) The r"" raw-string notation is quite powerfull. Peter Dominique Devienne wrote: From: Stefan Bodewig [mailto:[EM

Re: [SOS] Gump build of jakarta-slide - strange file resolution problem

2004-03-12 Thread Peter Reilly
e(new File(basedir), jdomjar)); called with ant -D"jdom.jar=/data3/gump/jdom/build/jdom.jar" works ok. Peter Antoine Lévy-Lambert wrote: Hi, I have been advising the slide developers (particularly Unico Hommes) about changing their build files to make them work better with gump. I wonde

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
If you use beanshell 2.0x (which you do!), you can use a normal script task to create a selector. Peter Jose Alberto Fernandez wrote: I need to construct a fileset using rules a little bit out of the ordinary and I an having a very hard time trying to do it in ANT. What I need is to be able to

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
Ok, an example! you can do: import java.io.File; import org.apache.tools.ant.types.selectors.FileSelector; public class NameSelector implements FileSelector { private String match; public void setMatch(String match) { this.match = match; } public bo

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
This is a known problem with beanshell 2.0b1. You need to just call the script once in a top-level target (! i.e. do not place the script task at the top-level!) and then use the antcall's. solves this problem by checking if the scripttypedef has been defined before. Peter Jose Alberto Fern

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
Dominique Devienne wrote: From: Peter Reilly [mailto:[EMAIL PROTECTED] This is a known problem with beanshell 2.0b1. Peter, since you seem to keep on top of Java scripting, do you know what's the status of BeanShell? Last time I looked, the source code for 2.0b1 was never checked in to

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
I was testing setting this with scripttypedef. Both groovy and beanshell ignore the setting of the classloader on the BSF engine. With groovy, one can work around the problem by setting the context classloader, but this does not work for beanshell. Peter Jose Alberto Fernandez wrote: From: Peter

Re: Poor support for selectors

2004-03-12 Thread Peter Reilly
AntClassLoaders are cached. Note, this redefine class problem does not happen with groovy. Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Suggested using.html diff

2004-03-16 Thread Peter Reilly
Committed, thanks. Peter Jack Woehr wrote: I think this is more accurate in detail than what stands now. -- Jack J. Woehr# "[F]ar in the empty sky a solitary esophagus slept http://www.well.com/~jax # upon motionless wing; everywhere brooded stillness, http://www.softwoeh

Re: Pb with ++

2004-03-16 Thread Peter Reilly
at DEBUG level only? According to the manual, setting quiet sets the waring level down, (and sets failonerror to false), you should just set failonerror to false. Peter And if the ZipFile.close() method really throws an exception, instead of simply ignoring it completely, shouldn't it be at

Re: Pb with ++

2004-03-16 Thread Peter Reilly
Dominique Devienne wrote: From: Peter Reilly [mailto:[EMAIL PROTECTED] ZipFile is supposed to do that, but apparently it doesn't work. not having windows, i cannot test this. It may also be that another process has it's grubby hands on the zip file. Possible, but unlik

Re: What do you think about a task ?

2004-03-29 Thread Peter Reilly
There was some discussion about Costin's classloader task for the 1.6 release: http://marc.theaimsgroup.com/?l=ant-dev&m=106389211508059&w=2 Peter Rainer Noack wrote: Hi Ant developers, After taskdef supports the loaderref attribute, I've written a task that is able to a

Re: nested elements in antlibs

2004-03-31 Thread Peter Reilly
That should work, at least it does for me: in an antlib at package test and used: Matt Benson wrote: I am finding that I cannot define the following in an antlib: and reference it with a namespace, due to the fact that the nested elements keep the default n

Re: cvs commit: ant WHATSNEW build.xml

2004-03-01 Thread Peter Reilly
Jose, You are right, the check is just for the main build file. Peter Jose Alberto Fernandez wrote: Peter, Maybe I do not understand the fix completely, but shouldn't the check be that a target cannot appear ON THE SAME FILE (imported or main) more than once? I.e., I should not be ab

Re: antlib and classloaders

2004-04-02 Thread Peter Reilly
ition classpath. The only problem with this is that the user build script needs to set the correct property before the antlib is activated. Peter Mariano Benitez wrote: I have this issue in mind: Since I need to provide antlibs to my customers, I would like them to have to manually configure as le

Re: antlib and classloaders

2004-04-02 Thread Peter Reilly
Hi, This sounds nice but does it save that much on . Peter Jose Alberto Fernandez wrote: Hi, I have been giving some thought on ways to solve this nagging issue of needing to put antlib jars on the lib directory. We hear over and over people wanting to keep their third party

Re: antlib and classloaders

2004-04-02 Thread Peter Reilly
ou thought about using the Class-Path attribute on the manifiest of the ANTLIB jar itself? This will not work too good as the jars get added to the global/default classloader and this may cause conflicts (multi commons_xx.jar for example). Peter If your libraries location are relative to your

Re: hotswap via ant

2004-04-03 Thread Peter Leschev
Hi David, Looking good! A couple of suggestions: - Currently it looks like you can only pass the port for the VM's debug port. It would be useful if you can specify a host as well (just default it to localhost so the user doesn't have to specify it

Re: Suggested Diff: UnknownElement.java

2004-04-05 Thread Peter Reilly
I am not sure it is good advice to tell people to recompile ant, in the (already alarming) error message that most ant newbies see. Normally people will get ant precomiled - to get all the optional tasks compiled correcty is difficult. Peter Jack J. Woehr wrote: This diff corrects an outdated

Re: Suggested Diff: UnknownElement.java

2004-04-07 Thread Peter Reilly
Jack J. Woehr wrote: Okay, how's this? That is good, I have committed it. Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: antlib and classloaders

2004-04-08 Thread Peter Reilly
xml file imported by a site's build.xml files. Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java

2004-04-14 Thread Peter Reilly
Yikes! Peter [EMAIL PROTECTED] wrote: mbenson 2004/04/13 14:42:59 Modified:src/main/org/apache/tools/ant/taskdefs ImportTask.java Log: Fixed "optional" attribute. Reported by: Nick Gianakas Revision ChangesPath 1.27 +1 -1 ant/src/main/org/apache/tools/an

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java

2004-04-14 Thread Peter Reilly
ImportTask.java to make sure that the changes are ok and then do commit ImportTask.java Peter Matt Benson wrote: And once again I escape having to merge anything I'm really going to have to learn to do that before 1.6.2... :( -Matt --- [EMAIL PROTECTED] wrote: peterreilly2004/04/14 01:

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs StyleTest.java

2004-04-16 Thread Peter Reilly
Hi Stefan, It is probally not too important, but the createMapper may be replaced by an addMapper(Mapper) method in ant 1.6. - This allows use of the ant-type type override. Peter [EMAIL PROTECTED] wrote: /** + * Defines the mapper to map source to destination files. + * @return

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs StyleTest.java

2004-04-16 Thread Peter Reilly
Stefan Bodewig wrote: On Fri, 16 Apr 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: It is probally not too important, but the createMapper may be replaced by an addMapper(Mapper) method in ant 1.6. - This allows use of the ant-type type override. So I should use that, thanks. Do we h

Re: AntCall manual typo?

2004-04-19 Thread Peter Reilly
The manual is correct, if a bit hard to follow. Using antcall, or ant, or subant, creates a new project. One can control the properties and references that this new project has by using the attributes and elements of antcall etal. Peter Jack Woehr wrote: In the manual pages for AntCall, text says

Re: [Container|Composite]Mapper

2004-04-21 Thread Peter Reilly
me, I used "containermapper" to be consistent with "globmapper" et al. However I have been known to use odd names at times (NewInterfaceManager2 is one I made at work). Peter. Ps. Thanks for updating the doc for macrodef, esp the text element!. Matt Benson wrote: To rehash yet aga

Re: [Container|Composite]Mapper

2004-04-21 Thread Peter Reilly
his shoulds good, and is a good reason to split up the containerclass. Peter Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-m

Re: Ant 1.6.2 ?

2004-04-21 Thread Peter Reilly
Maybe the manual entry for the jspc could should how to use the task bundled with tomcat 5.0. Peter [EMAIL PROTECTED] wrote: I propose 1. we fix 2. we tell people in the docs to use the tomcat own task if they encounter trouble. Sounds like a plan. Maybe we should encourage them to use

Re: tests failing w/ illegal access error

2004-04-21 Thread Peter Reilly
Steve Loughran wrote: This is me running build.sh test or ant test from ant CVS_HEAD; CLASSPATH is empty. or should be. I will take a look. Did you do rm -rf bootstrap build before doing ./build.sh test Peter - To unsubscribe, e

Re: [Container|Composite]Mapper

2004-04-21 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 21 Apr 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: The only thing to keep in mind is that the following (I think) should still work. as against: ... Why is this desirable? Less wordy or for a dif

Re: [Container|Composite]Mapper

2004-04-23 Thread Peter Reilly
Peter Reilly wrote: This could be done by adding an add(Mapper) method to the Copy class. This should be add(FileNameMapper) . Peter I am not too sure that this is a goal as this in effect makes Copy a container class for mappers, this should be I think done by the Mapper class itself. Peter

Re: [Container|Composite]Mapper

2004-04-23 Thread Peter Reilly
Matt Benson wrote: --- Peter Reilly <[EMAIL PROTECTED]> wrote: Ps. Thanks for updating the doc for macrodef, esp the text element!. Actually, that was all Jan's work. I just noticed a missing "e" on the word "attribut" and thought I'd fix

Re: [Container|Composite]Mapper

2004-04-23 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 21 Apr 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: But on reflection, it may be better to use the element in this case, inside an implicit aka So we seem to agree. Agreed! Peter

use of canonical in

2004-04-27 Thread Peter Reilly
problem is that this is a incompatible change. One could make the point that this is a bug and so should be fixed. (Use may need to be made of FileUtils.normalize() as well as File.getAbsolutePath() has given problems before). Peter

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Execute.java

2004-04-27 Thread Peter Reilly
Also each of the closees should be in their own try-catch. try { process.getInputStream().close(); } catch (Throwable t) { // Ignore exception } should work Peter Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: Error reporting pb with

2004-04-29 Thread Peter Reilly
with a -verbose flag to ant. Peter Dominique Devienne wrote: I have a that wraps a which in this case forks. The forked javac fails, but the 1.6 code for MacroInstance seems to eat up the stack traces for the nested exception, and displays only the message of the outermost exception. I suspect that

Re: cvs commit: ant/src/etc/testcases/taskdefs fail.xml

2004-04-29 Thread Peter Reilly
I see a small problem here. Exit was extending Task, and now is extending ConditionBase. ConditionBase does not extend Task so this breaks backward compatiblity. It may be better to do this: rather that: (Dispite the fact that I normally argue against extra nesting). Peter

Re: cvs commit: ant/src/etc/testcases/taskdefs fail.xml

2004-04-29 Thread Peter Reilly
t;role" code in to deal with the "or" and "and"s conditions/selectors. Peter As a matter of fact, now that the introspector is able to deal with "add" methods. Shouldn't we deprecate ConditionBase and discourage people from using inheritance? It would produ

[NEW TASK PROPOSAL] onceonly

2004-04-30 Thread Peter Reilly
In call In callee Peter package net.sf.antextra; import java.util.Set; import java.util.HashSet; import java.util.Collections; import org.apache.tools.ant.taskdefs.Sequential; /** * Ant task to run a sequence of tasks only * once. * Usefull for setting up stuff in files

Re: nested elements in antlibs

2004-04-01 Thread Peter Reilly
Opps, you are correct. I was using my anti-xml-hell patch http://marc.theaimsgroup.com/?l=ant-dev&m=107763945224538&w=2 you need to do the following silliness: see: http://ant.apache.org/manual/CoreTypes/antlib.html#currentnamespace Peter Matt Benson wrote: I can

Re: Trapping RuntimeExceptions form Tasks

2004-05-05 Thread Peter Reilly
There are a lot of "errors" that should be converted to buildexceptions. examples are "NoClassDefFoundError", "VerifyError" etc Peter Jose Alberto Fernandez wrote: Fair enough, but notice that the fix to failonerror (or is it the keepGoing global switch) will swallow

Re: Trapping RuntimeExceptions form Tasks

2004-05-05 Thread Peter Reilly
I see verify errors sometimes with beanshell and groovy scripts. Peter Stefan Bodewig wrote: On Wed, 05 May 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: There are a lot of "errors" that should be converted to buildexceptions. examples are "NoClassDefFoundError", "

Re: when are tasks instances no longer referenced?

2004-05-05 Thread Peter Reilly
, RuntimeConfigurable objects were written. Peter Mariano Benitez wrote: I have no ID in the task. [EMAIL PROTECTED] wrote: A task can be executed multiple times - via Ants API. Hello <![CDATA[ theEcho.perform(); theEcho.perform(); ]]> If a task has an ID its reference is stored in the projects ref

Re: when are tasks instances no longer referenced?

2004-05-05 Thread Peter Reilly
Yuji Yamano wrote: On Wed, 05 May 2004 16:51:58 +0100, Peter Reilly <[EMAIL PROTECTED]> wrote: At the moment all tasks/types instances are stored for the execute phase of a project. Which do you mean the parse time or the executing targets time? I think the instantitation timi

Re: antlibs and classloaders #2

2004-05-07 Thread Peter Reilly
ant calls. Peter Mariano Benitez wrote: I am at the edge of a mental crisis, I need help Can someone explain how antlib paths and tasks works, I have this situation that I cannot understand. I de

Re: antlibs and classloaders #2

2004-05-10 Thread Peter Reilly
cpptasks namespace. The way to work around this would be to do: Peter MAriano Mariano Benitez wrote: but ... If I call "typedef" for the same file, with the same task, same uri, etc, why it redefine the tasks if they are already defined? BTW, it could help

Re: antlibs and classloaders #2

2004-05-10 Thread Peter Reilly
This soulds ok, but it could be done like this: see: http://marc.theaimsgroup.com/?l=ant-dev&m=108331661709918&w=2 Peter Mariano Benitez wrote: Peter Reilly wrote: another thing, I did the thing because I ca

Re: antlibs and classloaders #2

2004-05-10 Thread Peter Reilly
difficult to remember to do this. The only difference will be the speed of the build. Peter This looks much better than calling some task from the antlib with doggie parameters. What do people think? Jose Alberto - To unsubscribe, e

Re: Trapping RuntimeExceptions form Tasks

2004-05-11 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 05 May 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: I see verify errors sometimes with beanshell and groovy scripts. Because you are reloading classes which is a problem in its own. I think you'd better find a way to avoid these VerifyErrors

Re: antlibs and classloaders #2

2004-05-11 Thread Peter Reilly
bute which is in that space. the implementation could use the new NS aware features that were added recently. I assume you mean the NS aware dymanic configurator patch. The second form of the antlibresolve task could use to implement the "antlib:ns" style a

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/filters ConcatFilterTest.java

2004-05-14 Thread Peter Reilly
- IIRC the first (pre-)releases of OS X have already been available in 2000. I think that it would be a good idea to use line.separator for the default value. It is less brittle than the current method, and I cannot imagine that many people would have used on MacOSX without setting the eol

Re: antlibs and classloaders #2

2004-05-17 Thread Peter Reilly
... . May be considered as a short-hand (antlibresolve is now a reserved name and may not be used as a task/type in an antlib). However: is very problematic. - for example the antlibresolve may be in a macrodef: ... ... Peter Jose Alberto Fernandez wr

Re: antlibs and classloaders #2

2004-05-17 Thread Peter Reilly
t is not wise to use the same uri for different antlibs, the user should always try to pick unique names for the antlibs, otherwise we go back to a single namespace. One antlib may "resolve" other antlibs if antlibresolve was an allowed task in an antlib. Peter This is my understanding

<    5   6   7   8   9   10   11   12   13   14   >