Sync task

2005-03-10 Thread Kev Jackson
I'm just renaming variables to prevent name hiding and I saw this - is it a bug? private int[] removeOrphanFiles(Set nonOrphans, File toDir) { int[] removedCount = new int[] {0, 0}; String[] excls = (String[]) nonOrphans.toArray(new String[nonOrphans.size() + 1]);

[patch] mainly name-hiding

2005-03-10 Thread Kev Jackson
kev Index: CVSPass.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/CVSPass.java,v retrieving revision 1.25 diff -u -r1.25 CVSPass.java --- CVSPass.java9 Mar 2005 00:20:40 - 1.25 +++ CVSP

Ant PMD report, 1.6.3 release

2005-03-11 Thread Kev Jackson
Hi, I've had some email issues, so I've only just started getting mailing list mails again [sigh] Anyway. I've just run PMD against the ant source to see how it measures up. There are about 7000 issues according to PMD, however the vast majority are things that I'm sure no-one would care abou

Re: [patch] mainly name-hiding

2005-03-14 Thread Kev Jackson
Martijn Kruithof wrote: Conor MacNeill wrote: Likewise, I do not see converting an if-else to a ternary conditional makes the code clearer - on the contrary it makes it more convoluted. Sorry about this one (the ternary conditional). I very rarely use these, and in this case, I was getting "un

Re: [VOTE] Ant 1.6.3 release candidate

2005-03-15 Thread Kev Jackson
Do we want to make a ant 1.6.3 RC1 on Wednesday, March 23d ? [x ] Yes (if we've addressed all the bugs/issues that we can) [ ] No - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: [VOTE] Ant 1.6.3 release candidate

2005-03-15 Thread Kev Jackson
[EMAIL PROTECTED] wrote: +1 (means yes) I thought only committers could +1 something on a vote? Ok, +1 if I can/makes any difference Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTEC

Re: [VOTE] Ant 1.6.3 release candidate - new date proposed : March 31st

2005-03-16 Thread Kev Jackson
Antoine Levy-Lambert wrote: Since several committers seemed to want a bit more time for fixes, let's vote for Ant 1.6.3 rc1 on Thursday, March 31st. (and cancel the previous vote of course) +1 I'm going to check spelling of all the html docs over the next couple of days, I know that there are a c

Doc spelling?

2005-03-16 Thread Kev Jackson
US or British spelling? Customize/Customise? Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

[patch] ant in anger

2005-03-16 Thread Kev Jackson
- fixed broken links - fixed spelling - -> - " -> " &c Kev Index: ant_in_anger.html === RCS file: /home/cvspublic/ant/docs/ant_in_anger.html,v retrieving revision 1.17 diff -u -r1.17 ant_in_anger.html --- ant_in_anger.html 5 Mar 20

Re: [patch] ant in anger

2005-03-16 Thread Kev Jackson
Antoine Levy-Lambert wrote: Good morning Kev, Good afternoon (just after lunch here :) I'll look at the other docs as I get the time. Fixing typos/broken links is really low-hanging fruit and I can get to a few of these before March 31st, so why not? Kev

Re: [patch] ant in anger

2005-03-17 Thread Kev Jackson
Shatzer, Larry wrote: why " to "? '"' is perfectly valid in HTML, and no need to escape it. Sorry, I'm assuming that the docs will be transformed into xml at some point, at that time " may be better than ". Kev - To unsubscrib

[patch] SchemaValidate

2005-03-23 Thread Kev Jackson
-remove unused exports -A href -> a href -javadoc tweaks Index: SchemaValidate.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/SchemaValidate.java,v retrieving revision 1.5 diff -u -r1.5 SchemaVa

new Task - CheckLink

2005-03-23 Thread Kev Jackson
Whilst I was hacking away at the docs a couple of weeks ago, I noticed that a most time-consuming thing was checking all the urls embedded in them. Since I had a couple of hours free today, I decided to knock up a little task to do it for me. Use Case: - check links in text source to ensure that

BZip2 tweaks

2005-03-24 Thread Kev Jackson
I looked at this before and I thought it could be improved, but when I saw the patch I decided to leave alone until that was applied. I'm no expert on BZip compression, so my changes are relatively minor e.g. for (i = 0; i < MAX_CODE_LEN; i++) { base[i] = 0; } for (i

[patch] bzip2

2005-03-24 Thread Kev Jackson
- removed trailing ';' - use array initialization instead of loops where appropriate As I said before, I saw the big patch on bugzilla and forgot about this, but as the big patch is no longer valid (breaks bc), here's my (very) minor version :) Kev Index: CBZip2InputStream.java =

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs SignJarTest.java

2005-03-25 Thread Kev Jackson
Well, a bit of hackery and you can verify that JAR is signed. But there is *nothing* to verify that the signature itself is trusted. Essentially "jarsigner -verify" is a worthless piece of junk from the security perspective. Who'd have thought that a commit message would have me ROFL! "Worthl

[patch] Stylebook task javadoc

2005-03-25 Thread Kev Jackson
noticed Stylebook was missing @param, renamed m_foo -> foo Kev Index: StyleBook.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/StyleBook.java,v retrieving revision 1.16 diff -u -r1.16 StyleBook.

[patch] oata.taskdefs.email

2005-03-25 Thread Kev Jackson
- namehiding - removed extra whitespace[shrug] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Validation of instance variables

2005-03-25 Thread Kev Jackson
We usually have to check to ensure that various values aren't null before calling execute() in the tasks. I've been thinking about this, and it seems that at the moment every task handles it differently. Some check the values as part of theexecute method, some have a seperate private method th

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs SignJarTest.java

2005-03-30 Thread Kev Jackson
Here are my current plans -pull the declaration of , tests, etc. -I'd leave the code over in optional, always excluded, with a "here is why this is broken" comment. Its aim is to warn off others. -Not attempt to use jar signing as a way of verifying JAR downloads in ; this was my plan. Could you

Re: [patch] Stylebook task javadoc

2005-03-31 Thread Kev Jackson
Uhm, they are protected. I don't think anybody is extending the task, but this is possible (actually, I don't even think anybody is using it). sorry, my bad. If this task is so old, should we not deprecate it and update the docs to mention it's unsupported/old/deprecated nature? Kev ---

Re: [patch] Stylebook task javadoc

2005-03-31 Thread Kev Jackson
Stefan Bodewig wrote: On Thu, 31 Mar 2005, Kev Jackson <[EMAIL PROTECTED]> wrote: If this task is so old, should we not deprecate it and update the docs to mention it's unsupported/old/deprecated nature? +1 Ok, hint taken I'll get on with the necessary u

Re: [patch] Stylebook task javadoc

2005-03-31 Thread Kev Jackson
here's the @deprecated stylebook and doc changes to OptionalTasks/stylebook.html (sorry the other changes are in the stylebook patch too) Kev Index: StyleBook.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/task

Re: ResourceCollections

2005-03-31 Thread Kev Jackson
1) a name for a ResourceCollection that acts like a Union without removing duplicates. What would it be used for? It is not a set operation that way and I'm not familiar enough (at least the english terms of) with list theory (if there is something like that at all). append? join? Un

Re: Drop 1.2/1.3 support in Ant 1.7 (or sometime)?

2005-04-07 Thread Kev Jackson
Jesse Glick wrote: Has anyone given thought to when we drop support for running Ant on JDK 1.2/1.3? These releases are pretty old by now and AFAIK all major platforms have had a decent 1.4 port for a while. I am guessing most Java developers would be using a relatively recent JDK anyway - and t

[patch] javadoc, name-hiding, if/else nesting

2005-04-12 Thread Kev Jackson
some tweaks, nothing major Kev Index: CollectionUtils.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/util/CollectionUtils.java,v retrieving revision 1.18 diff -u -r1.18 CollectionUtils.java --- CollectionUtils.ja

Re: regression in handling of failures

2005-04-12 Thread Kev Jackson
Looks like it was there in Ant 1.5 final (Java.run()), but now it's missing Here's a patch to fix this. Kev I have it on reliable authority (chapter 5 of java development with ant), that Ant1.5 would fail with a location error when you tried to run without a class on the classpath. But now I see

Re: [patch] javadoc, name-hiding, if/else nesting

2005-04-13 Thread Kev Jackson
if (condition) { return a; } return b; over: if (condition) { return a; } else { return b; } Only real benefit is to get rid of compiler warnings. I'm ambivalent about either way being "more correct", but the fewer warnings I get the better IMHO, so I remove nesting of returns in else

Re: [VOTE] Ant 1.6.3 release

2005-04-20 Thread Kev Jackson
Antoine Levy-Lambert wrote: Do we want to release Ant 1.6.3 on Thursday, April 28th ? Yes [X ] No [ ] Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Ant 1.6.4 release

2005-05-09 Thread Kev Jackson
[x] Yes [ ] No and +1 just in case ;) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

SVN repo?

2005-05-11 Thread Kev Jackson
Just a quickie, what's the URL for the SVN repo for Ant? The website still lists the CVS Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: SVN repo?

2005-05-12 Thread Kev Jackson
"Ant itself" still is in CVS. I thought that after 1.6.3 ANt was going to be moved into SVN (indeed part of the hurry for getting out 1.6.3 was to include the svn task so that other projects could start the move across), or am I mistaken? The URL is .

Re: SVN repo?

2005-05-12 Thread Kev Jackson
As a committer you really would need to use http*s*. I think that's the point :) I'm not a committer, or did I get commit access when I wasn't looking! Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: SVN repo?

2005-05-12 Thread Kev Jackson
Steve Loughran wrote: As a committer you really would need to use http*s*. I think that's the point :) I'm not a committer, I know. I may not be the youngest around here, but I still manage to keep track of a few people ;-) What I tried to say was that you can use https as a non-committer as wel

Re: [VOTE] Shut down the 1.6 branch after 1.6.5

2005-05-23 Thread Kev Jackson
Stefan Bodewig wrote: Hi, it's my strong belief that part of the reason the javah and move bugs made it into 1.6.3 is that our branches are living too long. The same happened to 1.5.2 (which required 1.5.3 quickly) because the 1.5 branch lived to long (IMHO). In my day-to-day Ant usage I use

Re: [VOTE] Shut down the 1.6 branch after 1.6.5

2005-05-23 Thread Kev Jackson
Yes. In particular the number of bugs that are only present in the branch but not on CVS head. Both the and bugs have been fixed in HEAD for many weeks before we released 1.6.3. process issue then. The complexity of keeping the curent branch in a predictable state when the development

Re: [VOTE] Shut down the 1.6 branch after 1.6.5

2005-05-23 Thread Kev Jackson
Unfortunately there's no simple fix. Sure. Kill branches as soon as possible so we don't need a process for dealing with them. ok, so then maintaining the branch becomes a trivial exercise "after 2* months it's dead and new code is always in HEAD and you don't have to migrate it to

[offtopic] jspc?

2005-05-27 Thread Kev Jackson
Quick question I'm working on a rather boring web app with Spring/Hibernate etc (insert current fad in Java Web Frameworks here). And I was just browsing around and saw jspc, and I remembered that there was an ant task.. Is there any benefit at all from running jspc before building the war?

[patch] remove unnecessary code

2005-06-20 Thread Kev Jackson
JavaClassHelper - removed call to get line separator, use StringUtils instead Kev Index: JavaClassHelper.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/filters/util/JavaClassHelper.java,v retrieving revision 1.

FileUtils.close()

2005-06-21 Thread Kev Jackson
This came up before, but I forgot what the consensus was (been a while since I've had time to play with Ant). Whenever FileUtils.close() is used, any resulting exceptions are swallowed and no logging is performed. I'd like to propose that instead of this "silent death" for close, that there i

Re: FileUtils.close()

2005-06-21 Thread Kev Jackson
Alexey N. Solofnenko wrote: Maybe just ioex.printStackTrace()? I thought it would be better to log to the specific calling task (although getting the error message from the exception makes perfect sense). I seem to recall a complaint about close silent behaviour with a full filesystem and

[patch] FileUtils close methods now log to calling tasks log

2005-06-22 Thread Kev Jackson
Based on the feedback, I added in the message retrieved from the io exception. This is just for writer/outputstream. Kev Index: FileUtils.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/util/FileUtils.java,v r

Re: How to pipe output to input?

2005-06-27 Thread Kev Jackson
Well! I am ashamed to say I had never encountered the mkfifo command. My only contact with "named pipes" [snip interesting pipes discussion] My only contact with named pipes was in the abomination that was WebSphere 3.5.1 (you had choices of Java, Corba or "Named Pipes" as a config opti

Re: Performance difference between 1.6.1 and 1.6.4 (in eclipse)

2005-06-27 Thread Kev Jackson
Dominique Devienne wrote: Ullrich was kind enough to provide me data gathered by my own performance listener, which shows timings for tasks as well as targets: Timing by tasks in Ant 1.6.2:in Ant 1.6.5 --- -- -- -- --- -- 19.578,0 ms 175,2%24x ant

[patch] use fileutils.close

2005-06-29 Thread Kev Jackson
- close with fileutils.close instead of manually Kev Index: BaseFilterReader.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/filters/BaseFilterReader.java,v retrieving revision 1.18 diff -u -r1.18 BaseFilterReade

XJ - xml extension for Java

2005-06-29 Thread Kev Jackson
Thought you may find this of interest. IBM have a new way of processing XML docs within Java. http://www.research.ibm.com/xj/samples/sample2.html Very cool page showing how this all works (cool in firefox anyway). I like the way you can construct objects from inlined xml target t = new targe

suggestion - remove antidote from components list on BugZilla

2005-06-29 Thread Kev Jackson
seems like a waste to have it still listed since it's deprecated Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: suggestion - remove antidote from components list on BugZilla

2005-06-29 Thread Kev Jackson
[EMAIL PROTECTED] wrote: I thought that, too - but there would be lot of work without win [1]. You can only delete a component in BugZilla if you re-assign all the bugs to something else? Seems to be a bit drastic (oh well) Kev --

Re: AW: AW: suggestion - remove antidote from components list on BugZilla

2005-06-30 Thread Kev Jackson
[EMAIL PROTECTED] wrote: Oh - background could be that no bug should be lost. Jan I can see that, but perhaps a 'feature' to archive off components with 100% closed bugs? It seems remarkable that this hasn't been thought of before (it probably has, but no-one wants to hack the code).

Re: AW: AW: suggestion - remove antidote from components list on BugZilla

2005-06-30 Thread Kev Jackson
I didnt thought that as well, but that´s not our playground. You could open a RFE on BugZilla itself :-) done - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: AW: suggestion - remove antidote from components list on BugZilla

2005-06-30 Thread Kev Jackson
Kev Jackson wrote: I didnt thought that as well, but that´s not our playground. You could open a RFE on BugZilla itself :-) done so... >>> What|Removed

Re: XJ - xml extension for Java

2005-07-05 Thread Kev Jackson
1. I wish jikes would move up to 1.5; my life is spent waiting for things to compile again. I've skipped Java 1.5 for various reasons: 1 - the 'enhanced for loop' is just crap 2 - I've not needed generics, I actually have no need for one of the major features of the language, maybe I could

Re: XJ - xml extension for Java

2005-07-06 Thread Kev Jackson
Since you are i hibernate user that may be one of the major reasons for you to switch (i know i will, eventually) to use the annotations and EJB3 hibernate stuff. I actually find Hibernate* to not be as good as advertised, but then I don't think the EJB3 stuff adds anything (indeed I feel i

Re: XJ - xml extension for Java

2005-07-06 Thread Kev Jackson
Alexey N. Solofnenko wrote: We can think whether generics and annotations are good or bad, but they are now a part of our lives. There is nothing we can do. - Alexey. not unless they delete the 1.4 capabilities! "Out of my cold dead hands".. ;) Anyway, well said, we sort of have to adapt

Java Development with Ant

2005-07-25 Thread Kev Jackson
Hi all, I'm preparing a talk for the developers here in Vietnam about how to use Ant to build software (mainly Java, but you know there's the .net tasks too). I have the main body of the presentation completed, but I wanted to include some of the more esoteric things you can do with Ant (not

Re: Java Development with Ant

2005-07-26 Thread Kev Jackson
They are at the leading edge then... I have been interviewing candidates for a developer position not later than yesterday and it left me with a bitter test about software process and tools used within a team working...no source control within a team of 15 people (10 dev), etc... all that wit

Re: FYI: document the code

2005-08-02 Thread Kev Jackson
James Fuller wrote: [EMAIL PROTECTED] wrote: You know that we (for several months :) are discussing about autogenerating the manual. I think we should have an eye on one of the Apache Google Summer of Code projects - RefDoc. Maybe we could reuse parts or the whole of it. See http://marc.th

Re: [VOTE] migrate to svn

2005-08-02 Thread Kev Jackson
[EMAIL PROTECTED] wrote: Ok, I got some "+1", but "sooner" is not a timeframe you could really vote on - IMO :-) So I suggest: "Migrate Ant from CVS to SVN on the weekend of 13./14. August 2005." That would be the first weekend after the one-week voting timeframe. After passing the vote we

[OT] Sorry for the spam...

2005-08-05 Thread Kev Jackson
Hi all, I'm messing around with CVS and trying to discover the latest version of a repo in CVS - any CVS guru's around who know is it possible? You can do something similar with svn, but CVS has versions/file. If that's the case I may have to keep a hash of file/version for each file, and t

Re: Ant task

2005-08-07 Thread Kev Jackson
Alexey Panchenko wrote: Hi all, jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Ant.java: 383:if (locals.size() > 0 && !(locals.size() == 1 384: && locals.get(0) == "")) { Is there a reason why the Strings are compared using == here and not

Re: Ant task

2005-08-08 Thread Kev Jackson
Peter Reilly wrote: I do not know if the "" will be interned, it probally will be, but the code is misleading, so am replacing it with a "".equals(locals.get(0)) Peter Kev Jackson wrote: fair enough ;)

antlibs

2005-08-08 Thread Kev Jackson
Hi all, I've got a couple of months left on my contract here and I don't want to just leave code behind before I go. I built a quick and dirty link checker task after hours (no worries on IP I promise), it's obviously not a good fit for Ant core, but as an Ant lib task I thought it might be

commons dev list CVS component

2005-08-08 Thread Kev Jackson
It looks like there's a possibility that a java based CVS component could soon be in commons/incubator, having noticed comments in the CVS task source about using a pure Java version (jCVS) and there being problems with IP, I can only hope that this (potential) component would solve that issue

Re: AW: commons dev list CVS component

2005-08-09 Thread Kev Jackson
[EMAIL PROTECTED] wrote: IMHO all stuff which relies on an external system (other than JDK or the OS :-) should be in an AntLib. And scm´s rely on the scm-server. So a quick view on the core task list gave me: - CVS: Cvs, CvsChangeLog, CvsVersion, CVSPass, CvsTagDiff mmh - not more ... And o

Re: AW: AW: commons dev list CVS component

2005-08-09 Thread Kev Jackson
[EMAIL PROTECTED] wrote: Holding the source in an AntLib doesnt mean that we cant ship them in the "main" distro (nearly) as usual. Jan Indeed, we just need to make the task point to the re-packaged versions instead, I presume we'll ship the svn task as part of verions 1.7 as an antlib?

Re: commons dev list CVS component

2005-08-09 Thread Kev Jackson
I would love to remove some of the fat from the current ANT and move more things to individual antlibs that people can load on demand. However, the main issue we need to face is how to maintain easy backward compatibility at least at the XML level. We need to define a proper strategy or antlib

Manual + xdocs etc

2005-08-10 Thread Kev Jackson
Hi all, Since the debate over deriving the Ant docs from the source has died down a little recently, I thought I'd just poke everyone again , and see who's still interested. The other thing I'd like to propose is a much needed update to the layout and visual appearance of the manual - it loo

Re: AW: Manual + xdocs etc

2005-08-11 Thread Kev Jackson
I think we should reorder the existing docs along the structure which I think Erik Hatcher had conceived and which is incarned by the @ant.category tags in the source code (scm, packaging, ...). A "complete" list of these tags would be helpful ... Agreed. I am still interested

Re: AW: [VOTE] migrate to svn

2005-08-11 Thread Kev Jackson
[EMAIL PROTECTED] wrote: I´m just getting the results of the vote. But I´m not sure which action from the bylaws to use. An "Adoption of New Codebase" needs 2/3 majority of committers which we havent (~ 1/3). Many committers havent voted, but we have consensus. How to proceed? [snip resu

strange logging error

2005-08-23 Thread Kev Jackson
Hi all, I'm writing a custom task at the moment and I've come across a problem the simple act of trying to log causes a NullPointerException at Task:347 which seems to be failing as the project is null. I'm pretty sure that this is being caused by my code, but I can't see what the problem is

Re: AW: strange logging error

2005-08-23 Thread Kev Jackson
[EMAIL PROTECTED] wrote: Maybe the project is not set correctly. What does "getProject()" refer? If you inherit from DispatchUtils, you dont have a real task (class inherited from oata.Task). You´re using a task wrapper instead. Jan I know, but I was inheriting from Task (just indirectly

Re: Please Unsubscribe this email address

2005-08-23 Thread Kev Jackson
Richard Evans wrote: ALL, I believe this address previously belonged to an employee with this name sake in the UK. However, I am in the US and do not work in the area of system resolutions. Thanks in advance for your responsiveness, - Richard Hi Richard, If you want to be removed from

SVN antlib

2005-08-25 Thread Kev Jackson
Hi all, I'm setting up CruiseControl and I need to access our code in svn, the default method appears to be simply to use the task and call out to a native svn client, but I seem to remember an antlib for svn - I looked around and tried to check out from the asf repo, but all I got was a cou

Re: SVN antlib

2005-08-26 Thread Kev Jackson
I looked around and tried to check out from the asf repo, but all I got was a couple of files. What else did you expect? Among the files is a build file, I hope. Yes that was all I'm afraid - I didn't look hard enough - found the actual sources later, but apache svn + firewall her

AntClassLoader2

2005-09-17 Thread Kev Jackson
Would it break BC to drop this empty class and the loader package for 1.7? I doubt if anyone is really using this in the wild and it's been deprecated for a while. Kev -- "It is through disobedience that progress has been made, through disobedience and through rebellion" - Oscar Wilde

[patch] HTML -> html

2005-09-18 Thread Kev Jackson
Just looking through the svn antlib to see how antlibs work and I found some uppercase HTML in src/etc/diff.xsl, as the other xsl sheet is in lowercase tags, I changed them over to lowercase. Kev Index: D:/eclipse/workspace/svn/src/etc/diff.xsl ==

Re: Maven and Ant collaboration on task codebase

2005-09-20 Thread Kev Jackson
Here's my non-committer 2pennies worth... I think it would be beneficial to refactor Ant for some of the commons-libs (commons-exec for example), I also think it'd be useful for Ant 1.7 to splitoff as many tasks as possible into antlibs. The Antlib idea seems to me to be the best way of refac

[patch] Delete task, remove unnecessary imports

2005-09-21 Thread Kev Jackson
- remove unneeded imports Kev Index: D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java === --- D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java (revision 290644)

dotnet antlib minor changes

2005-09-21 Thread Kev Jackson
- use FileUtils.getFileUtils() - remove unused import Kev Index: D:/java_projects/ant-sandbox/antlibs/dotnet/trunk/src/main/org/apache/ant/dotnet/MSBuildTask.java === --- D:/java_projects/ant-sandbox/antlibs/dotnet/trunk/src/main/o

Creating antlibs from taskdefs.optional.*

2005-09-22 Thread Kev Jackson
Hi all, I'm interested in the amount of effort it would take to create an antlib from one of the current optional taskdefs. For example ccm (Continuus). I"m using the svn, antunit and dotnet antlibs source as guidance, and it seems like all that is needed is an antlib.xml file and a target i

Re: Creating antlibs from taskdefs.optional.*

2005-09-22 Thread Kev Jackson
Replying to myself... It seems that with only a small amount of effort it is possible to create antlibs as I supposed, now all I have to do is find a way to use said new antlib with ant (oh and install Continuus to test...;) Kev ---

Re: Creating antlibs from taskdefs.optional.*

2005-09-22 Thread Kev Jackson
nope, you havent missed anything. I think we may want to extend the antlib with some extra stuff to ease installation -declaration of libraries that must be present (tests for classes) -declare minimum or required ant versions you mean something like ... So now I've got a ccm antli

[patch] Get Last X elements from resource collection

2005-09-26 Thread Kev Jackson
If you need to get the first X elements, presumably there will be occasions where you'll need to get the last X elements. Anyway, I've been playing with Haskell recently and it's affected my thinking :) Kev Index: D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/types/resources/L

suggestion refactor SCM

2005-09-26 Thread Kev Jackson
Hi I've been playing with darcs recently and I've almost finished an antlib for it (though I keep being distracted, first Haskell, now Lisp). 'darcs get' is roughly similar to 'cvs checkout' or 'svn co' I was wondering if it would make sense to refactor the SCM tasks into an interface (s

Re: [patch] Get Last X elements from resource collection

2005-09-28 Thread Kev Jackson
with first & last, we should also consider renaming to "head" & "tail" as suggested by (IIRC) Jan or Antoine. I'd prefer a "head" & "tail" naming style too, it matches functional list programming style, but your the main dev on this stuff it's up to you :) I just saw an opportunity to ch

Re: suggestion refactor SCM

2005-09-28 Thread Kev Jackson
On 29 Sep 2005, at 06:39, Brett Porter wrote: I'd also agree with that. We fully intended to make Maven2 plugins work as Ant tasks :) So with a wrapper, http://maven.apache.org/maven2/scm/maven-scm-plugin/ these goals would become tasks and their parameters would match up what's on the individ

[Patch] svn antlib

2005-09-28 Thread Kev Jackson
-use FileUtils.close method Kev Index: D:/java_projects/ant-sandbox/antlibs/svn/trunk/src/main/org/apache/ant/svn/AbstractSvnTask.java === --- D:/java_projects/ant-sandbox/antlibs/svn/trunk/src/main/org/apache/ant/svn/AbstractSvnTa

Darcs antlib beta ready

2005-09-29 Thread Kev Jackson
Hi all, I've finally had time today to fix up my antlib for darcs. Functionally you can use it to call darcs with common commands (get, pull, initialize, add, record, whatsnew) I'm missing - cool changelog task (ala CVS and SVN with xsl goodness), - complete docs - complete Junit tests - more

Quick question about properties

2005-10-12 Thread Kev Jackson
Hi all, I'm trying to refactor a build file we have here into a commonly used set of targets and then project specifc targets. Here's my directory setup ./common/build.xml ./common/build.properties ./build.xml (shown below) Now in the common/build.xml I use the property file tag to read in

Re: Quick question about properties

2005-10-12 Thread Kev Jackson
Stefan Bodewig wrote: On Thu, 13 Oct 2005, Kev Jackson <[EMAIL PROTECTED]> wrote: However if I try to run the project buildfile (./build.xml), none of the properties are available (quick checks with echo just give me variables instead of expanded properties). This is not wha

Re: Quick question about properties

2005-10-12 Thread Kev Jackson
Stefan Bodewig wrote: On Thu, 13 Oct 2005, Kev Jackson <[EMAIL PROTECTED]> wrote: However if I try to run the project buildfile (./build.xml), none of the properties are available (quick checks with echo just give me variables instead of expanded properties). This is not wha

Re: Quick question about properties

2005-10-13 Thread Kev Jackson
Peter Reilly wrote: At one stage, the import task behaved as if it was added at the end of the build file. This was an unexpected consequence (bug!) of the initial implementation. This was changed (I think) in 1.6.1 or 1.6.2, so that the import behaved as if it was inline. I have just checked th

Re: Quick question about properties

2005-10-13 Thread Kev Jackson
OK. they were tail first, and I have stated that fact both in the draft and in the big projects chapter of the second edition of Java development with Ant. Which means that I have bit of editing to do on the CVS-managed copies of that chapter. I've been trying to finish that chapter since a

[Patch] Use file utils ina static manner where possible

2005-10-25 Thread Kev Jackson
Just a quickie on Concat Kev Index: D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java === --- D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java (revision 328575) +

[Patch] DependSet - remove unnecessary codw

2005-10-25 Thread Kev Jackson
- removed FileUtils Kev Index: D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/DependSet.java === --- D:/java_projects/ant-core-trunk/src/main/org/apache/tools/ant/taskdefs/DependSet.java (revision 328

[Patch] Property - remove deprecated code

2005-10-25 Thread Kev Jackson
- removed ProjectHelper.parsePropertyString - added PropertyHelper.parsePropertyString Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Patch] Property - remove deprecated code

2005-10-26 Thread Kev Jackson
Kev Jackson wrote: - removed ProjectHelper.parsePropertyString - added PropertyHelper.parsePropertyString Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Always helps to

Re: XmlProperty

2005-11-02 Thread Kev Jackson
Something I've been meaning to propose for two years but never had the time to fully think through. Allow each task to take input in form of a ResourceCollection and to declare its output as a ResourceCollection as well. Using this, provide a task that chains the output of task n to the input

Re: AntUnit

2005-11-06 Thread Kev Jackson
I think the using / maintaining by ourselves is more of a chicken and egg problem - We do not really need it for our "outside ant" activities - We cannot really use it for our "inside ant" activities as it is in the sandbox. - We do not maintain it as we do not use it, and it is in the sand

[Patch] use StringUtils in AntUnit

2005-11-06 Thread Kev Jackson
- use StringUtils.LINE_SEP instead of looking up System.getProperty("line.seperator") each time - remove unused import statement Kev Index: D:/java_projects/ant-sandbox/antlibs/antunit/trunk/src/main/org/apache/ant/antunit/PlainAntUnitListener.java ==

<    1   2   3   4   >