vgoncharenko opened a new pull request #1: Fix issue ant-antlibs-common
submodule not found
URL: https://github.com/apache/ant-antlibs-props/pull/1
Hello, today during installation of this project I have faced an issue like
that:
+ git submodule init
Submodule 'common'
(https://
bodewig commented on issue #1: Fix issue ant-antlibs-common submodule not found
URL: https://github.com/apache/ant-antlibs-props/pull/1#issuecomment-447768646
Sorry for that, we are in the process of moving our repositories internally
at Apache, expect some hiccups.
Rather than mergi
vgoncharenko commented on issue #1: Fix issue ant-antlibs-common submodule not
found
URL: https://github.com/apache/ant-antlibs-props/pull/1#issuecomment-447769149
ok, thanks for your fast reaction to my problem.
This is an a
vgoncharenko closed pull request #1: Fix issue ant-antlibs-common submodule not
found
URL: https://github.com/apache/ant-antlibs-props/pull/1
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As thi
bodewig commented on issue #1: Fix issue ant-antlibs-common submodule not found
URL: https://github.com/apache/ant-antlibs-props/pull/1#issuecomment-447769681
should be fixed with df20430
Many thanks for reporting it.
T
twogee opened a new pull request #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85
javadoc fails nightly builds...
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468822545
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/107/
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468822780
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/113/
--
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468828666
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/108/
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468829867
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/114/
--
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468947269
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/109/
asfgit commented on issue #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85#issuecomment-468947532
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/115/
--
asfgit merged pull request #85: Incorrect HTML
URL: https://github.com/apache/ant/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
asfgit commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470197718
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/110/
-
asfgit commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470197699
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/116/
---
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470422494
Summerize the changes:
- Add new tool "Nu HTML Validator" for checking manual and site
check.xml: new target 'vnu'
- add attribute: -->
- remov
janmaterne edited a comment on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470422494
Summerize the changes:
- Add new tool "Nu HTML Validator" for checking manual and site
check.xml: new target 'vnu'
- add attribute: -->
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470423575
I like the idea of checking the html files.
But why are these changes required? Only because a tool sais that is not
enough for me. Do you have pointers to some
twogee commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470478712
The goal is to follow HTML 5 spec (except for index.html where we still have
frames).
What is missing is doctype and lang attribute instead of meta tags.
scope at
twogee commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470576630
Recommendations re [doctype](https://www.w3.org/QA/Tips/Doctype), [language
declaration](https://www.w3.org/International/questions/qa-html-language-declarations),
[sc
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470824474
Thanks for the links, sounds reasonable.
Two things I found:
1. maybe you should add a short paragraph in the section
like for the other tools
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470825471
Just summarize/quote the link contents:
- **doctype**: that declaration was used in HTML5 to distinguish between a
standards-compliant parsing mode and a so-call
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470832663
Tool "Copyright (c) 2013-2018 Mozilla Foundation"
(https://github.com/validator/validator/blob/master/src/nu/validator/client/SimpleCommandLineValidator.java),
so
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470836739
This PR can't be responsible for the failing tests as the sources or test
files are not touched.
Failing tests are:
src.tests.antunit.types.resources.
twogee commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470920527
Thanks for reviewing and excellent summaries.
These tests have failed multiple times previously; it looks like redirection
tests cannot connect to external serve
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-470939094
out|err-props could also work. Catch into prop, write prop to file and
print. Give it a try.
This
asfgit merged pull request #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
janmaterne commented on issue #83: Add HTML validation check
URL: https://github.com/apache/ant/pull/83#issuecomment-471177878
Added the redirection to file and did a few renamings. Merged into master.
This is an automated mes
twogee opened a new pull request #86: htmlcheck: correct tool name, consistent
report placement
URL: https://github.com/apache/ant/pull/86
Sorry about tardiness...
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #86: htmlcheck: correct tool name, consistent report
placement
URL: https://github.com/apache/ant/pull/86#issuecomment-471250804
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/11
asfgit commented on issue #86: htmlcheck: correct tool name, consistent report
placement
URL: https://github.com/apache/ant/pull/86#issuecomment-471250862
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/
asfgit merged pull request #86: htmlcheck: correct tool name, consistent report
placement
URL: https://github.com/apache/ant/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, please
twogee opened a new pull request #87: CSS contains non-ASCII quotes
URL: https://github.com/apache/ant/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
asfgit commented on issue #87: CSS contains non-ASCII quotes
URL: https://github.com/apache/ant/pull/87#issuecomment-474221694
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/112/
-
asfgit commented on issue #87: CSS contains non-ASCII quotes
URL: https://github.com/apache/ant/pull/87#issuecomment-474221620
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/118/
---
twogee closed pull request #87: CSS contains non-ASCII quotes
URL: https://github.com/apache/ant/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
twogee opened a new pull request #88: HTML5-compliant javadoc
URL: https://github.com/apache/ant/pull/88
We should also convert XSLT to produce HTML5...
This is an automated message from the Apache Git Service.
To respond to t
asfgit commented on issue #88: HTML5-compliant javadoc
URL: https://github.com/apache/ant/pull/88#issuecomment-474616741
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/119/
-
asfgit commented on issue #88: HTML5-compliant javadoc
URL: https://github.com/apache/ant/pull/88#issuecomment-474616822
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/113/
---
asfgit closed pull request #88: HTML5-compliant javadoc
URL: https://github.com/apache/ant/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jaikiran commented on issue #88: HTML5-compliant javadoc
URL: https://github.com/apache/ant/pull/88#issuecomment-474683056
Thank you, this is now merged.
This is an automated message from the Apache Git Service.
To respond to
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-475891807
Can one of the admins verify this patch?
This is an automated message from the
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-475891810
Can one of the admins verify this patch?
This is an automated message from the
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-475891809
Can one of the admins verify this patch?
This is an automated message from the
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-475891806
Can one of the admins verify this patch?
This is an automated message from the
craigpell opened a new pull request #89: Added version and mainClass attributes
to task.
URL: https://github.com/apache/ant/pull/89
Added version and mainClass attributes to task, to set binary
attributes of a modular jar file. For Ant 1.10.x. Addresses these tickets:
https://bz.apa
twogee commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r268422972
##
File path: manual/Tasks/jar.html
##
@@ -217,6 +217,23 @@ Parameters
include META-INF unless explici
twogee commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r268422972
##
File path: manual/Tasks/jar.html
##
@@ -217,6 +217,23 @@ Parameters
include META-INF unless explici
twogee commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r268423028
##
File path: manual/Tasks/jar.html
##
@@ -385,6 +402,40 @@ service
a JAR file has more that one implementat
twogee commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r268423359
##
File path: src/main/org/apache/tools/ant/util/jarattr/ClassFormatException.java
##
@@ -0,0 +1,59 @@
+/*
twogee commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r268423686
##
File path: src/main/org/apache/tools/ant/util/jarattr/Constant.java
##
@@ -0,0 +1,147 @@
+/*
Review com
jaikiran commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-476030934
this is ok to test
This is an automated message from the Apache Git Service.
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-476032382
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/114/
-
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-476032427
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/120/
jaikiran commented on a change in pull request #89: Added version and mainClass
attributes to task.
URL: https://github.com/apache/ant/pull/89#discussion_r270277284
##
File path: manual/Tasks/jar.html
##
@@ -217,6 +217,23 @@ Parameters
include META-INF unless expli
jaikiran commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-477864675
Thanks @craigpell, this is a very good enhancement and the code looks very
good too. I do have some suggestions/questions about some of the ne
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-477865927
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/121/
asfgit commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-477866471
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/115/
-
jaikiran commented on issue #89: Added version and mainClass attributes to
task.
URL: https://github.com/apache/ant/pull/89#issuecomment-477867207
While you are here, a quick suggestion/question - given that these changes
are related to Java modules in general and there probably will be m
janmaterne commented on issue #45: Consider returning a zero length array
rather than null.
URL: https://github.com/apache/ant/pull/45#issuecomment-480534186
While i agree and prefer returning Optional or an empty List, in this
case this would break backwards compatiblity. And therefore th
asfgit commented on issue #45: Consider returning a zero length array rather
than null.
URL: https://github.com/apache/ant/pull/45#issuecomment-480534191
Can one of the admins verify this patch?
This is an automated message f
asfgit commented on issue #45: Consider returning a zero length array rather
than null.
URL: https://github.com/apache/ant/pull/45#issuecomment-480534189
Can one of the admins verify this patch?
This is an automated message f
asfgit commented on issue #45: Consider returning a zero length array rather
than null.
URL: https://github.com/apache/ant/pull/45#issuecomment-480534190
Can one of the admins verify this patch?
This is an automated message f
asfgit commented on issue #45: Consider returning a zero length array rather
than null.
URL: https://github.com/apache/ant/pull/45#issuecomment-480534188
Can one of the admins verify this patch?
This is an automated message f
asfgit commented on issue #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90#issuecomment-480727727
Can one of the admins verify this patch?
This is an automated message from the Apache Git Servic
asfgit commented on issue #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90#issuecomment-480727725
Can one of the admins verify this patch?
This is an automated message from the Apache Git Servic
asfgit commented on issue #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90#issuecomment-480727724
Can one of the admins verify this patch?
This is an automated message from the Apache Git Servic
yuanjumao opened a new pull request #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit commented on issue #90: solve the unconsistent comments
URL: https://github.com/apache/ant/pull/90#issuecomment-480727726
Can one of the admins verify this patch?
This is an automated message from the Apache Git Servic
bodewig commented on a change in pull request #90: solve the unconsistent
comments
URL: https://github.com/apache/ant/pull/90#discussion_r273119651
##
File path: src/main/org/apache/tools/ant/ComponentHelper.java
##
@@ -452,12 +452,7 @@ public void checkTaskClass(final Cl
bodewig commented on a change in pull request #90: solve the unconsistent
comments
URL: https://github.com/apache/ant/pull/90#discussion_r273119872
##
File path: src/main/org/apache/tools/ant/UnknownElement.java
##
@@ -151,11 +151,7 @@ public RuntimeConfigurable getWrappe
bodewig commented on a change in pull request #90: solve the unconsistent
comments
URL: https://github.com/apache/ant/pull/90#discussion_r273120166
##
File path: src/main/org/apache/tools/ant/types/XMLCatalog.java
##
@@ -197,10 +197,7 @@ public Path createClasspath() {
bodewig commented on a change in pull request #90: solve the unconsistent
comments
URL: https://github.com/apache/ant/pull/90#discussion_r273121101
##
File path:
src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
##
@@ -686,9 +686,7 @@ p
linux1fans opened a new pull request #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91
Does not show progress 100%
This is an automated message from the Apache Git Service.
To respond to the message, p
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481115349
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481115346
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481115348
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481115345
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
jaikiran commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481125990
this is ok to test
This is an automated message from the Apache Git Service.
To respond to the messa
jaikiran commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481540419
This change looks fine to me. Is there a specific name you want us to use to
credit you for this change in our contributors list
https://github.com/apache/ant/blob/
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481542452
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/116/
asfgit commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481578372
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/122/
--
linux1fans commented on issue #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91#issuecomment-481622348
> This change looks fine to me. Is there a specific name you want us to use
to credit you for this change in our contributors list
https://github.com/apache/ant/b
asfgit closed pull request #91: Update ScpFromMessage.java
URL: https://github.com/apache/ant/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
asfgit commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-482920253
Can one of the admins verify this patch?
This is an automated message
asfgit commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-482920252
Can one of the admins verify this patch?
This is an automated message
bd2019us opened a new pull request #92: Wrap FileWriter with BufferedWriter for
better performance
URL: https://github.com/apache/ant/pull/92
When the FileWriter.write() method is invoked in a loop, it has a bad impact
on the performance of program. Therefore, the BufferedWriter is recomme
jaikiran commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-488627408
this is ok to test
This is an automated message from the Apache Git
asfgit commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-488629505
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/1
asfgit commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-488629495
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows
jaikiran commented on issue #92: Wrap FileWriter with BufferedWriter for better
performance
URL: https://github.com/apache/ant/pull/92#issuecomment-488631718
Thank you for the PR. This looks fine to me and I've merged this to upstream
master branch.
---
MatthiasGutheil opened a new pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit commented on issue #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#issuecomment-494398916
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To r
asfgit commented on issue #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#issuecomment-494398924
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To r
jaikiran commented on issue #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#issuecomment-494400763
this is ok to test
This is an automated message from the Apache Git Service.
To respond to the messag
asfgit commented on issue #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#issuecomment-494405154
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/124/
---
jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#discussion_r286053213
##
File path: src/etc/testcases/taskdefs/optional/junitlauncherwithtag.xml
##
@@ -0,0 +1,111 @@
+
Review comment:
Can you inc
jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#discussion_r286054440
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java
##
@@ -204,6 +215,8 @@ public
jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#discussion_r286056060
##
File path:
src/tests/junit/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTaskWithTagTest.java
##
@@ -0,0 +1
jaikiran commented on issue #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#issuecomment-494416920
This is a good addition to the task. Thank you for providing this patch.
Apart from the review comments I added inline, this mostly looks good to me.
---
1 - 100 of 714 matches
Mail list logo
