Re: ant git commit: Remove redundancies

2018-08-21 Thread Stefan Bodewig
> diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java > b/src/main/org/apache/tools/ant/types/PatternSet.java > -: new > StringBuilder(baseString).append(";encoding->").append(encoding).toString(); > +: baseString + ";encoding->" + encoding; I don'

Re: tstamp testMagicProperty consistently failing on Windows

2018-08-21 Thread Stefan Bodewig
On 2018-08-19, Jaikiran Pai wrote: > The tstamp (antunit) test named "testMagicProperty" has been > consistently failing (only) on Windows for a while now[1]. Both master > and 1.9.x branches. The failure looks really odd and something that I > haven't been able to understand yet. The one interest

Re: junitlauncher task - support for system properties in a non-forked execution

2018-08-21 Thread Stefan Bodewig
On 2018-08-16, Jaikiran Pai wrote: > While working on the documentation of the junitlauncher task, for fork > support, I realized that when we first released this task, due to an > oversight, I did not add support for setting system properties or > environment variables through this task. The fork

Re: junitlauncher task - support for system properties in a non-forked execution

2018-08-21 Thread Jaikiran Pai
Hi Stefan, On 22/08/18 12:00 AM, Stefan Bodewig wrote: > On 2018-08-16, Jaikiran Pai wrote: > >> However, I would like some inputs on whether such support for setting >> the system properties in a non-forked execution should be at the >> junitlauncher task level or whether it should be configured