Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166216151
--- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java ---
@@ -102,7 +102,7 @@
private static final String DEFAULT_MIME_TYPE = "text/plain";
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166217627
--- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java ---
@@ -377,7 +377,7 @@ public synchronized void run() {
}
// now d
Just to be clear, my -1 was meant for both this commit as well as a
subsequent commit where some specific jars have been tagged as JPMS
modules. I think adding this automatic module names just for the sake of
it isn't a good thing.
-Jaikiran
On 06/02/18 9:38 AM, Jaikiran Pai wrote:
I agree.
I understand the intent of your votes. I do experiment with using module
path in a real world application, so it's not an art for art's sake.
I will move the proposal to a PR. Talking of which, have you any comments
on IVY-1485 (aka PR-65)?
Gintas
2018-02-06 9:46 GMT+01:00 Jaikiran Pai :
> Just
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/65
These changes don't solve the real issue. The details of this issue are
part of the discussion in ant dev mailing list, where I explained what the real
issue is. I do have a completely different cod
On 2018-02-05, Gintautas Grigelionis wrote:
> I adjusted the proposal and I hope that I addressed your criticism.
Unfortunately it doesn't.
I'm afraid that we would be sending a wrong signal here. On top of that
I don't think Ant would actually work if parts of it are used as
modules. We use cla
On 2018-02-06, Jaikiran Pai wrote:
> don't think we should be doing any of these commits especially when
> there's a RC out which we plan to release.
In general we live in a commit then review world, so I think it is kind
of OK to perform bigger changes without discussion upfront. It would
have
On 2018-02-03, Stefan Bodewig wrote:
> git tag: ANT_1_9_10_RC1
> on commit: 528c94e
+1
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
On 2018-02-03, Stefan Bodewig wrote:
> git tag: ANT_1.10.2_RC1
> on commit: 0eba7eb
+1
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Hi
if I understand correctly our current PR build setup with Jenkins
requires somebody to comment on the issue in order to have Jenkins build
it.
Do we really want this extra step? For Commons Compress I never thought
about something like that.
If we do, how does Jenkins know who is allowed to t
Github user twogee closed the pull request at:
https://github.com/apache/ant-ivy/pull/65
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
The PR build on Jenkins is backed by the github PR integration
plugin[1]. One of the features of that plugin is to prevent some
malicious/rogue PR (imagine someone creating a PR with code which does
some odd things with the host on which it runs) being auto-triggered
against the Jenkins hosts.
So it looks like, although I did send a mail about this PR integration a
while back[1], I did not include the details about this plugin which was
used for the integration. Sorry about that.
[1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html
-Jaikiran
On 06/02/18 5:12 PM, Jaiki
On 2018-02-06, wrote:
> Do not add automatic module names
thank you
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r166282397
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
findResourceUsingPat
I put things back as they were, but we're breaking specs [1] by not having
unique Extension-Name (not that anybody cares).
Gintas
[1]
https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#Main_Attributes
(point 4)
2018-02-06 13:09 GMT+01:00 Stefan Bodewig :
> On 2018-02-06, wrote
Github user apupier commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/62#discussion_r166349423
--- Diff:
src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java ---
@@ -91,6 +91,9 @@ protected ResolvedResource
findResourceUsingPatt
On 2018-02-06, Jaikiran Pai wrote:
> The PR build on Jenkins is backed by the github PR integration
> plugin[1]. One of the features of that plugin is to prevent some
> malicious/rogue PR (imagine someone creating a PR with code which does
> some odd things with the host on which it runs) being au
On 2018-02-03, Stefan Bodewig wrote:
> I've created a release candidate for 1.9.10:
with +1s by
Jaikiran Pai
Jan Matèrne
Maarten Coene
Stefan Bodewig
and no other votes the vote has passed.
Stefan
-
To unsubscribe, e-mail: de
On 2018-02-03, Stefan Bodewig wrote:
> Hi all
> I've created a release candidate for 1.10.2:
Jan Matèrne
Jaikiran Pai
Stefan Bodewig
and no other votes the vote has passed.
I'll publish the artifacts and give the mirrors a few hours time to
catch up before updating the site and send out the re
Hi all
as you can witness in
https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368&r2=1823367&pathrev=1823368
I don't really know which change to highlight specifically.
The announcement is going to contain all changes, is there any one or
two changes you think we should highl
2018-02-06 11:05 GMT+01:00 Stefan Bodewig :
> On 2018-02-05, Gintautas Grigelionis wrote:
>
> > I adjusted the proposal and I hope that I addressed your criticism.
>
> Unfortunately it doesn't.
>
> I'm afraid that we would be sending a wrong signal here. On top of that
> I don't think Ant would ac
Please highlight JAI removal in Java 9+ and deprecation of Log4j.
Gintas
2018-02-06 18:48 GMT+01:00 Stefan Bodewig :
> Hi all
>
> as you can witness in
> https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.
> xml?r1=1823368&r2=1823367&pathrev=1823368
> I don't really know which change to
Maybe the new task is worth highlighting. But other than
that I don't have anything specific.
-Jaikiran
On 06/02/18 11:18 PM, Stefan Bodewig wrote:
Hi all
as you can witness in
https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368&r2=1823367&pathrev=1823368
I don't reall
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The Apache Ant Team is pleased to announce the releases of Apache Ant
1.9.10 and 1.10.2.
Apache Ant is a Java library and command-line tool that helps building
software.
The Apache Ant team currently maintains two lines of development. The
1.9.x rele
CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security
vulnerability
Severity: low
Vendor: The Apache Software Foundation
Versions Affected:
Apache Ant 1.9.0 - 1.9.9
Apache Ant 1.10.0 - 1.10.1
The unsupported Apache Ant 1.8 and lower versions are also affected.
De
26 matches
Mail list logo