I understand the intent of your votes. I do experiment with using module path in a real world application, so it's not an art for art's sake. I will move the proposal to a PR. Talking of which, have you any comments on IVY-1485 (aka PR-65)?
Gintas 2018-02-06 9:46 GMT+01:00 Jaikiran Pai <jai.forums2...@gmail.com>: > Just to be clear, my -1 was meant for both this commit as well as a > subsequent commit where some specific jars have been tagged as JPMS > modules. I think adding this automatic module names just for the sake of it > isn't a good thing. > > -Jaikiran > > > > On 06/02/18 9:38 AM, Jaikiran Pai wrote: > >> I agree. -1. >> >> On a related note, I don't think we should be doing any of these commits >> especially when there's a RC out which we plan to release. IMO, only >> blocker issues need to be addressed when the RC is out. >> >> -Jaikiran >> >> >> On 06/02/18 1:41 AM, Stefan Bodewig wrote: >> >>> Generate manifest files and add automatic module names for JPMS >>>> >>> -1 >>> >>> please remove the Automatic-Module-Name attributes as our jars are no >>> proper JPMS modules. >>> >>> Stefan >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org >>> For additional commands, e-mail: dev-h...@ant.apache.org >>> >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
