Re: svn commit: r531340 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread jcumps
I'm looking for the problem that is resolved by commit r531340 . This commit introduced two bugs, http://issues.apache.org/bugzilla/show_bug.cgi?id=42227 http://issues.apache.org/bugzilla/show_bug.cgi?id=4 I'm trying to fix these bugs, but would like to know which failing usecase was resolv

Re: svn commit: r531340 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread Kevin Jackson
Hi, I'm looking for the problem that is resolved by commit r531340 . This commit introduced two bugs, http://issues.apache.org/bugzilla/show_bug.cgi?id=42227 http://issues.apache.org/bugzilla/show_bug.cgi?id=4 I'm trying to fix these bugs, but would like to know which failing usecase was r

Re: svn commit: r531340 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread Kevin Jackson
Hi, Looking deeper into this, the reason that the bug #42227 has appeared is because ImportTask uses Location which uses FileUtils.fromURI, which is using the new Locator.fromURI I'll continue to try to find a workaround Kev -

Re: svn commit: r531340 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread Kevin Jackson
Hi all, I quick dissection of the code and I realized that I was encoding the file path to ensure that it was compatible with the URI requirements, but not decoding it before returning the value. A tiny change to the Locator.java code and the test case provided now passes. I need to re-test my

svn commit: r533024 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread kevj
Author: kevj Date: Fri Apr 27 02:03:26 2007 New Revision: 533024 URL: http://svn.apache.org/viewvc?view=rev&rev=533024 Log: -fix for bug #42227 Modified: ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.jav

AW: svn commit: r533024 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread Jan.Materne
Cool. >+//bug #42227 forgot to decode before returning >+return decodeUri(f.getAbsolutePath()); While I am a fan of comments I dont think this is needed. If you encode an URI the default behaviour is decoding, so this is nothing unusual. Jan --

DO NOT REPLY [Bug 42227] - ant fails to include a build file when run from a dir containing spaces

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r531340 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Locator.java

2007-04-27 Thread Steve Loughran
Kevin Jackson wrote: Hi, Looking deeper into this, the reason that the bug #42227 has appeared is because ImportTask uses Location which uses FileUtils.fromURI, which is using the new Locator.fromURI One thing I'm thinking of for is how to resource enable it; which means we need a way (an i

apachecon

2007-04-27 Thread Steve Loughran
I'm going to be at apachecon from late tuesday evening to friday evening, missing the hackathon. 1. I'm presenting on Extending Ant on Thursday morning; I've got some changes to do and may do a dry run the day before. I want to do some IDE work in the talk rather than just slideware. 2. H

svn commit: r533058 - /ant/core/trunk/WHATSNEW

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 03:51:34 2007 New Revision: 533058 URL: http://svn.apache.org/viewvc?view=rev&rev=533058 Log: bug ID#42231, a static method is package scoped instead of public Modified: ant/core/trunk/WHATSNEW Modified: ant/core/trunk/WHATSNEW URL: http://svn.apache.org/view

DO NOT REPLY [Bug 42275] New: - running ant off a network share can cause Ant to fail

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

resource enabling something

2007-04-27 Thread Steve Loughran
I'm just prototypting resource support for , so it can load scripts off the classpath, etc...all the work goes on in ScriptHelper One question. Should I resource enable a task by adding support for ResourceCollections inst add(ResourceCollection rc) rather than simple resources add(Resource

locator fun

2007-04-27 Thread Steve Loughran
an ant-user problem has thrown me into the depts of java's URI to file conversion.. public void testTripleForwardSlashNetworkURI() throws Exception { resolveTo("file:///PC03/jclasses/lib/ant-1.7.0.jar", "///PC03/jclasses/lib/ant-1.7.0.jar"); } [junit] FAILED [j

DO NOT REPLY [Bug 42275] - running ant off a network share can cause Ant to fail

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r533082 - in /ant/core/trunk/src: main/org/apache/tools/ant/launch/Locator.java tests/junit/org/apache/tools/ant/launch/ tests/junit/org/apache/tools/ant/launch/LocatorTest.java

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 05:45:53 2007 New Revision: 533082 URL: http://svn.apache.org/viewvc?view=rev&rev=533082 Log: Bug 42275: ant doesnt run from a network share, because of an error when trying to work out where we loaded from. 1. this exception is still raised, but caught and causes

DO NOT REPLY [Bug 42276] New: - String resource should support nested text

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42277] New: - String resources can have properties double expanded

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42276] - String resource should support nested text

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42277] - String resources can have properties double expanded

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 20174] - antClassloader does not set codebase and thus cannot handle signed jars

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r533110 - /ant/core/trunk/docs/manual/OptionalTasks/script.html

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 07:17:08 2007 New Revision: 533110 URL: http://svn.apache.org/viewvc?view=rev&rev=533110 Log: bsf reference Modified: ant/core/trunk/docs/manual/OptionalTasks/script.html Modified: ant/core/trunk/docs/manual/OptionalTasks/script.html URL: http://svn.apache.or

svn commit: r533112 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/Tokens.java

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 07:17:56 2007 New Revision: 533112 URL: http://svn.apache.org/viewvc?view=rev&rev=533112 Log: Bind string resources to projects. There's no bugrep with this, but it is good practise Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/Tokens.

svn commit: r533113 - /ant/core/trunk/src/main/org/apache/tools/ant/types/Resource.java

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 07:18:26 2007 New Revision: 533113 URL: http://svn.apache.org/viewvc?view=rev&rev=533113 Log: not files, resources Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/Resource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/Resource.

DO NOT REPLY [Bug 42277] - String resources can have properties double expanded

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r533115 - in /ant/core/trunk: docs/manual/CoreTypes/resources.html src/main/org/apache/tools/ant/types/resources/StringResource.java

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 07:20:45 2007 New Revision: 533115 URL: http://svn.apache.org/viewvc?view=rev&rev=533115 Log: bug 42276: support nested text bug 42277: String resources can have properties double expanded Nested text is allowed, and property expansion is done at the tail end of a

Re: resource enabling something

2007-04-27 Thread Matt Benson
--- Steve Loughran <[EMAIL PROTECTED]> wrote: > I'm just prototypting resource support for > , so it can load > scripts off the classpath, etc...all the work goes > on in ScriptHelper > > One question. Should I resource enable a task by > adding support for > ResourceCollections inst > > add(

DO NOT REPLY [Bug 42277] - String resources can have properties double expanded

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42277] - String resources can have properties double expanded

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r533121 - in /ant/core/trunk: ./ docs/manual/OptionalTasks/ src/main/org/apache/tools/ant/taskdefs/optional/script/ src/main/org/apache/tools/ant/util/ src/tests/antunit/taskdefs/optional/

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 07:37:56 2007 New Revision: 533121 URL: http://svn.apache.org/viewvc?view=rev&rev=533121 Log: Bug #41597; scriptdef should be resource-enabled. Added: ant/core/trunk/src/tests/antunit/taskdefs/optional/script/ ant/core/trunk/src/tests/antunit/taskdefs/optio

svn commit: r533122 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/StringResource.java

2007-04-27 Thread mbenson
Author: mbenson Date: Fri Apr 27 07:38:15 2007 New Revision: 533122 URL: http://svn.apache.org/viewvc?view=rev&rev=533122 Log: ws Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/StringResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resource

DO NOT REPLY [Bug 41597] - and other script tasks should work from resources

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r533121 - in /ant/core/trunk: ./ docs/manual/OptionalTasks/ src/main/org/apache/tools/ant/taskdefs/optional/script/ src/main/org/apache/tools/ant/util/ src/tests/antunit/taskdefs/optio

2007-04-27 Thread Matt Benson
I am staggering under the weight of this (in a good way). It looks cool. :) This is exactly the type of thing I had hoped would just occur to us after we got the resources stuff in place. Great work, Steve. :) -Matt --- [EMAIL PROTECTED] wrote: > Author: stevel > Date: Fri Apr 27 07:37:56 2

DO NOT REPLY [Bug 42276] - String resource should support nested text

2007-04-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: resource enabling scriptdef

2007-04-27 Thread Steve Loughran
Matt Benson wrote: --- Steve Loughran <[EMAIL PROTECTED]> wrote: I'm just prototypting resource support for , so it can load scripts off the classpath, etc...all the work goes on in ScriptHelper One question. Should I resource enable a task by adding support for ResourceCollections inst a

Re: svn commit: r533121 - in /ant/core/trunk: ./ docs/manual/OptionalTasks/ src/main/org/apache/tools/ant/taskdefs/optional/script/ src/main/org/apache/tools/ant/util/ src/tests/antunit/taskdefs/optio

2007-04-27 Thread Steve Loughran
Matt Benson wrote: I am staggering under the weight of this (in a good way). It looks cool. :) This is exactly the type of thing I had hoped would just occur to us after we got the resources stuff in place. Great work, Steve. :) -Matt oh, the basic code was easy. testing javascript, now t

Re: svn commit: r533121 - in /ant/core/trunk: ./ docs/manual/OptionalTasks/ src/main/org/apache/tools/ant/taskdefs/optional/script/ src/main/org/apache/tools/ant/util/ src/tests/antunit/taskdefs/optio

2007-04-27 Thread Matt Benson
--- Steve Loughran <[EMAIL PROTECTED]> wrote: > Matt Benson wrote: > > I am staggering under the weight of this (in a > good > > way). It looks cool. :) This is exactly the > type of > > thing I had hoped would just occur to us after we > got > > the resources stuff in place. Great work, Stev

svn commit: r533193 - /ant/core/trunk/docs/slides/extending_ant.odp

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 12:10:21 2007 New Revision: 533193 URL: http://svn.apache.org/viewvc?view=rev&rev=533193 Log: getting ready for apachecon Modified: ant/core/trunk/docs/slides/extending_ant.odp Modified: ant/core/trunk/docs/slides/extending_ant.odp URL: http://svn.apache.org/

svn commit: r533214 - /ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java

2007-04-27 Thread stevel
Author: stevel Date: Fri Apr 27 13:40:13 2007 New Revision: 533214 URL: http://svn.apache.org/viewvc?view=rev&rev=533214 Log: little bit of code review Modified: ant/core/trunk/src/main/org/apache/tools/ant/AntClassLoader.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/AntClassLo

Re: svn commit: r533082 - in /ant/core/trunk/src: main/org/apache/tools/ant/launch/Locator.java tests/junit/org/apache/tools/ant/launch/ tests/junit/org/apache/tools/ant/launch/LocatorTest.java

2007-04-27 Thread Kevin Jackson
Hi Steve, You've committed code which has an LGPL license (LocatorTest). Is this your intention or just a mistake based on how you've currently got your IDE configured? Kev On 4/27/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: stevel Date: Fri Apr 27 05:45:53 2007 New Revision: 533