cvs commit: ant/xdocs contributors.xml

2004-11-22 Thread ddevienne
ddevienne2004/11/21 10:22:37 Modified:xdocscontributors.xml Log: Add my blurb, testing write access to repo. --DD Revision ChangesPath 1.31 +10 -0 ant/xdocs/contributors.xml Index: contributors.xml ==

cvs commit: ant/docs contributors.html

2004-11-22 Thread bodewig
bodewig 2004/11/22 00:16:16 Modified:docs contributors.html Log: regenerate site Revision ChangesPath 1.51 +9 -0 ant/docs/contributors.html Index: contributors.html === RCS file: /home/

Re: cvs commit: ant/xdocs contributors.xml

2004-11-22 Thread Stefan Bodewig
On 21 Nov 2004, <[EMAIL PROTECTED]> wrote: > Add my blurb, testing write access to repo. --DD welcome. Now you need to learn that running ant -f docs.xml regenerates the site so that you can actually see your changes online 8-) Done for now. Stefan --

cvs commit: ant/src/main/org/apache/tools/zip ZipEntry.java

2004-11-22 Thread bodewig
bodewig 2004/11/22 01:23:38 Modified:src/etc ant-update.xsl src/main/org/apache/tools/ant AntClassLoader.java ComponentHelper.java Diagnostics.java DirectoryScanner.java IntrospectionHelper.java Proje

DO NOT REPLY [Bug 32126] - Condition "IsSigned" to check if a jarfile is signed

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/types/selectors SignedSelector.java

2004-11-22 Thread peterreilly
peterreilly2004/11/22 02:07:22 Modified:.WHATSNEW src/main/org/apache/tools/ant/taskdefs defaults.properties src/main/org/apache/tools/ant/types defaults.properties Added: src/main/org/apache/tools/ant/taskdefs IsSigned.java

Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors SignedSelector.java

2004-11-22 Thread Stefan Bodewig
On 22 Nov 2004, <[EMAIL PROTECTED]> wrote: > Index: ConditionAndTask.java > > protected abstract boolean evaluate(); > > /** >* This method evaluates the condition. It calls evaluate in >* the derived class. It sets the property if a property is >* present

Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors SignedSelector.java

2004-11-22 Thread Peter Reilly
Stefan Bodewig wrote: On 22 Nov 2004, <[EMAIL PROTECTED]> wrote: Index: ConditionAndTask.java protected abstract boolean evaluate(); /** * This method evaluates the condition. It calls evaluate in * the derived class. It sets the property if a property is * presen

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/condition IsSigned.java

2004-11-22 Thread peterreilly
peterreilly2004/11/22 02:48:57 Modified:src/main/org/apache/tools/ant/types/selectors SignedSelector.java src/main/org/apache/tools/ant/types defaults.properties src/main/org/apache/tools/ant/taskdefs defaults.properties Added:

DO NOT REPLY [Bug 32126] - Condition "IsSigned" to check if a jarfile is signed

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 32344] New: - C/C++ compile and link task

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 32344] - C/C++ compile and link task

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors SignedSelector.java

2004-11-22 Thread Stefan Bodewig
On Mon, 22 Nov 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: >>Why do you introduce an additional abstract method? >> >>Wouldn't it be easier to place the logic of your eval into execute() >>directly and force subclasses to implement eval() just as they'd do >>as plain conditions anyway? >> >> > I

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/condition IsSigned.java

2004-11-22 Thread bodewig
bodewig 2004/11/22 03:42:53 Modified:src/main/org/apache/tools/ant/taskdefs SignJar.java src/main/org/apache/tools/ant/taskdefs/condition IsSigned.java Log: * Use from * Refactor by moving the test into a static method so it is easie

DO NOT REPLY [Bug 30517] - [signjar] : uptodate enhancements

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 14950] - Task signjar defect

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/types defaults.properties

2004-11-22 Thread bodewig
bodewig 2004/11/22 03:52:39 Modified:src/main/org/apache/tools/ant/types defaults.properties Log: Fix class name, make tests pass Revision ChangesPath 1.31 +1 -1 ant/src/main/org/apache/tools/ant/types/defaults.properties Index: defaults.properties =

Re: cvs commit: ant/src/main/org/apache/tools/ant/types defaults.properties

2004-11-22 Thread Peter Reilly
Opps, Soory, my conflict resultion got confused. Peter [EMAIL PROTECTED] wrote: bodewig 2004/11/22 03:52:39 Modified:src/main/org/apache/tools/ant/types defaults.properties Log: Fix class name, make tests pass Revision ChangesPath 1.31 +1 -1 ant/src/main/org/apache/too

DO NOT REPLY [Bug 27641] - Ordering of targets affects processing of macro instance validation.

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: task testing style?

2004-11-22 Thread Erik Hatcher
Both styles of testing have their merits. There are some mock objects in Ant's test infrastructure (MockBuildListener, for example). The most important thing, of course, is that tests are created that ensure that the production code is working as it should. Sure, there are more moving parts i

cvs commit: ant/src/etc/testcases/taskdefs/conditions/jars - New directory

2004-11-22 Thread peterreilly
peterreilly2004/11/22 08:19:29 ant/src/etc/testcases/taskdefs/conditions/jars - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant/types/selectors/modifiedselector ModifiedSelector.java

2004-11-22 Thread stevel
stevel 2004/11/22 08:44:16 Modified:src/main/org/apache/tools/ant/types/selectors/modifiedselector ModifiedSelector.java Log: xdoclet complains it is illegal to have comments at the end. Revision ChangesPath 1.14 +2 -2 ant/src/main/org/

Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors/modifiedselector ModifiedSelector.java

2004-11-22 Thread Stefan Bodewig
On 22 Nov 2004, <[EMAIL PROTECTED]> wrote: > xdoclet complains it is illegal to have comments at the end. xdoclet lies 8-) I'm surprised it's only been in one file, though. JDEEs default template adds a comment at the end of a class/interface for example. Stefan

AW: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors /modifiedselector ModifiedSelector.java

2004-11-22 Thread Jan . Materne
puh - never heard, that such a comment should be wrong ... So that´s an error in xdoclet? Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Gesendet am: Montag, 22. November 2004 17:53 > An: [EMAIL PROTECTED] > Betreff: Re: cvs commit: > ant/src/main/org/ap

Re: AW: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors /modifiedselector ModifiedSelector.java

2004-11-22 Thread Matt Benson
FWIW the ANTLR java grammars have for years had trouble with comments at EOF without EOL. IIRC it's a pain to express correctly in a grammar that a single-line comment is terminated by a newline except when it occurs at the end of the file... could be other tools have similar issues? -Matt --- [

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/etc/testcases/taskdefs/conditions issigned.xml

2004-11-22 Thread peterreilly
peterreilly2004/11/22 09:14:23 Added: src/testcases/org/apache/tools/ant/taskdefs/condition IsSignedTest.java src/etc/testcases/taskdefs/conditions/jars apassword.jar nosign.jar pass.jar src/etc/testcases/tas

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

RE: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors/modifiedselector ModifiedSelector.java

2004-11-22 Thread Dominique Devienne
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > puh - never heard, that such a comment should be wrong ... > So that´s an error in xdoclet? Actually, it's true. The JLS at one point specified that the last line of a file shouldn't end with a comment without a trailing line ending (\n). W

cvs commit: ant/src/main/org/apache/tools/ant/util FileUtils.java

2004-11-22 Thread peterreilly
peterreilly2004/11/22 10:18:42 Modified:src/main/org/apache/tools/ant/util FileUtils.java Log: checkstyle changes Obtained from: Kevin Jackson Revision ChangesPath 1.73 +3 -3 ant/src/main/org/apache/tools/ant/util/FileUtils.java Index: FileUtils.java ==

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 31999] - Easier way to declare externally-written tasks in build script

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21657] - CVS Task - Not working with passfile

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 29027] - Classpath elements within taskdefs ignored when in Antlib

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 30339] - Jar task can create mysteriously broken jar files in 1.5.1, 1.6.2

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/docs/manual/CoreTasks zip.html jar.html war.html ear.html

2004-11-22 Thread mbenson
mbenson 2004/11/22 14:53:50 Modified:docs/manual/CoreTasks zip.html jar.html war.html ear.html Log: Added warnings regarding duplicate files to and family. PR: 30339 Revision ChangesPath 1.27 +6 -0 ant/docs/manual/CoreTasks/zip.html Index: zip.html ===

cvs commit: ant/docs/manual/CoreTasks zip.html war.html ear.html jar.html

2004-11-22 Thread mbenson
mbenson 2004/11/22 14:55:10 Modified:docs/manual/CoreTasks Tag: ANT_16_BRANCH zip.html war.html ear.html jar.html Log: Merge Revision ChangesPath No revision No revision 1.21.2.6 +6 -0 ant/docs/manual/C

DO NOT REPLY [Bug 30339] - insufficient emphasis placed on duplicate attribute of zip & co. WAS Jar task can create mysteriously broken jar files in 1.5.1, 1.6.2

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 30339] - insufficient emphasis placed on duplicate attribute of zip & co. WAS Jar task can create mysteriously broken jar files in 1.5.1, 1.6.2

2004-11-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu