Re: Execute#getExitCode doesn't work as advertised

2003-09-18 Thread Martijn Kruithof
Hi Well fair enough, it is recognizable as the exit value will in that case be Integer.MAX_VALUE, so that should not be an issue. (So far for the non-hardcoded values) Thanks, Martijn Stefan Bodewig wrote: On Wed, 17 Sep 2003, Martijn Kruithof <[EMAIL PROTECTED]> wrote: regarding option 1 would

Re: Execute#getExitCode doesn't work as advertised

2003-09-18 Thread Stefan Bodewig
On Wed, 17 Sep 2003, Martijn Kruithof <[EMAIL PROTECTED]> wrote: > regarding option 1 wouldn't this still need a patch to set > killedProcess() to true Hmm, only if it has been the watchdog that has killed the process IMHO. If the InterruptedException has been raised for any other reason, we sho

Re: Execute#getExitCode doesn't work as advertised

2003-09-17 Thread Martijn Kruithof
TCH=== -Ursprungliche Nachricht- Von: Stefan Bodewig [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 17. September 2003 10:38 An: [EMAIL PROTECTED] Betreff: Execute#getExitCode doesn't work as advertised Martijn Kruithof raised this issue in his patch for PR 23150. The javadocs say

AW: Execute#getExitCode doesn't work as advertised

2003-09-17 Thread Antoine Levy-Lambert
What you say makes sense Stefan, Antoine -Ursprungliche Nachricht- Von: Stefan Bodewig [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 17. September 2003 10:38 An: [EMAIL PROTECTED] Betreff: Execute#getExitCode doesn't work as advertised Martijn Kruithof raised this issue in his patc

Execute#getExitCode doesn't work as advertised

2003-09-17 Thread Stefan Bodewig
Martijn Kruithof raised this issue in his patch for PR 23150. The javadocs say * @return the exit value, 1 if the process was killed, but in fact, it doesn't do anything special for a killed process. Rather than "fixing" this method, I'd like to remove the comment. For two reasons (1) Ex