Re: [OT] FindBugs

2003-07-24 Thread Stefan Bodewig
On Thu, 24 Jul 2003, Christopher Lenz <[EMAIL PROTECTED]> wrote: > You can check for 1/ and 2/ with Checkstyle, too: I expected that to be the case, yes. My last commits (fixing of potential NPEs, resource leaks) are less likely to be detected, though. Stefan --

Re: [OT] FindBugs

2003-07-24 Thread Christopher Lenz
Stefan Bodewig wrote: Hi, I just stumbled over findbugs[1] (via Cafe au lait) and ran it over Ant's sources. Some of the reported problems are non-issues, but it also detected some things that checkstyle doesn't[2]. Some examples: * BaseFilterReader line 88 should use "" instead of new String(). *

[OT] FindBugs

2003-07-24 Thread Stefan Bodewig
Hi, I just stumbled over findbugs[1] (via Cafe au lait) and ran it over Ant's sources. Some of the reported problems are non-issues, but it also detected some things that checkstyle doesn't[2]. Some examples: * BaseFilterReader line 88 should use "" instead of new String(). * bufferPos in Tail