Stefan Bodewig wrote:
Hi,
I just stumbled over findbugs[1] (via Cafe au lait) and ran it over
Ant's sources.
Some of the reported problems are non-issues, but it also detected
some things that checkstyle doesn't[2]. Some examples:
* BaseFilterReader line 88 should use "" instead of new String().
* bufferPos in TailFilter is never used
* line 897 in IntrospectionHelper should use Boolean.valueOf instead
of the constructor.
You can check for 1/ and 2/ with Checkstyle, too:
<module name="IllegalInstantiation">
<property name="classes"
value="java.lang.Boolean,java.lang.String"/>
</module>
See:
http://checkstyle.sourceforge.net/config_coding.html#IllegalInstantiation
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
