Re: enhancement for PropertyFile, have a patch

2005-10-03 Thread Phil Hourihane
Created as issue 36901 in bugzilla. http://issues.apache.org/bugzilla/show_bug.cgi?id=36901 PHiL --- Phil Hourihane <[EMAIL PROTECTED]> wrote: > Oops. Sorry about that. Will do. > > PHiL > > --- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > > > Th

Re: enhancement for PropertyFile, have a patch

2005-10-03 Thread Phil Hourihane
Oops. Sorry about that. Will do. PHiL --- Dominique Devienne <[EMAIL PROTECTED]> wrote: > > The changes listed below are contained in the > patch > > file. The other files are attached individually. > > This list strips attachments usually. Please open a > BugZilla > enhancement isntead, and at

enhancement for PropertyFile, have a patch

2005-10-01 Thread Phil Hourihane
Hi folks, A little while ago I posted that I had code to grant which would allow the PropertyFile task to retain the layout of the properties file that it was editing (mail subject was also "enhancement for PropertyFile, have a patch"). I was busy for a while, so didn't get around to posting the

Re: enhancement for PropertyFile, have a patch

2005-09-04 Thread Phil Hourihane
eration would give people an out if they discovered a bug. PHiL --- Steve Loughran <[EMAIL PROTECTED]> wrote: > Phil Hourihane wrote: > > Dominique, > > > > I was pretty sure that Sun's stuff, although > available > > in source form, wasn't open-source per

Re: enhancement for PropertyFile, have a patch

2005-09-03 Thread Phil Hourihane
Dominique, I was pretty sure that Sun's stuff, although available in source form, wasn't open-source per se, so I avoided hacking their code. The class I have is subclassed from Properties (to allow for polymorphic substitution), and includes its own code for parsing the incoming file and handling

RE: enhancement for PropertyFile, have a patch

2005-09-02 Thread Phil Hourihane
harm no foul. PHiL --- Phil Hourihane <[EMAIL PROTECTED]> wrote: > Antoine, > > I'll certainly have a look at the filterchain stuff > and see how much overlap there is between the work I > did and that. The meterial that I prepared is only > in > passing a patch to P

RE: enhancement for PropertyFile, have a patch

2005-09-02 Thread Phil Hourihane
inion, all tasks which we have which are > manipulating text files > should be rewritten around filters. This would avoid > code duplication. > And make the functionality of property file > available on the fly. > > Cheers, > > Antoine > > Phil Hourihane w

enhancement for PropertyFile, have a patch

2005-08-31 Thread Phil Hourihane
Hi folks, I hope I am getting the etiquette right for this; I am a new body on the list. The PropertyFile (optional) task allows a script to alter an existing properties file, but all comments and layout are lost. This doesn't get a mention in bugzilla. I have an enhancement which retains layout