Antoine, I'll certainly have a look at the filterchain stuff and see how much overlap there is between the work I did and that. The meterial that I prepared is only in passing a patch to PropertyFile, the main piece of any interest is a subclass of Properties which retains the format of the input stream from which properties were loaded, and which I thought to put in the public domain.
Anyway, since you have picqued my interest, I will look at the filterchain stuff, which I am not currently familiar with. PHiL --- "Burgess, Benjamin" <[EMAIL PROTECTED]> wrote: > +1 - excellent proposal > > -----Original Message----- > From: Antoine Levy-Lambert [mailto:[EMAIL PROTECTED] > Sent: Friday, September 02, 2005 10:03 AM > To: Ant Developers List > Subject: Re: enhancement for PropertyFile, have a > patch > > Hello Phil, > I wonder whether, instead of patching PropertyFile, > you should not study > how the <filterchain/> framework works and implement > the functionalitiy > of propertyfile > as a filter. Then it should be possible to change > the implementation of > propertyfile to make it use filters. > To my opinion, all tasks which we have which are > manipulating text files > should be rewritten around filters. This would avoid > code duplication. > And make the functionality of property file > available on the fly. > > Cheers, > > Antoine > > Phil Hourihane wrote: > > >Hi folks, > > > >I hope I am getting the etiquette right for this; I > am > >a new body on the list. > > > >The PropertyFile (optional) task allows a script to > >alter an existing properties file, but all comments > >and layout are lost. This doesn't get a mention in > >bugzilla. I have an enhancement which retains > layout > >and comments when writing a properties file, with > >accompanying tests. > > > >I have a patch for the affected files, and there > are a > >few new files (util class, test class, and test > data) > >as well. > > > >Do the group want the enhancement? Or more detail > from > >me? Shall I post the patch and new files? Any > feedback > >is welcome. > > > >Philip Hourihane > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > ************************************************************** > This message, including any attachments, contains > confidential information intended for a specific > individual and purpose, and is protected by law. If > you are not the intended recipient, please contact > sender immediately by reply e-mail and destroy all > copies. You are hereby notified that any > disclosure, copying, or distribution of this > message, or the taking of any action based on it, is > strictly prohibited. > TIAA-CREF > ************************************************************** > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > > ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
