Hello David,
I ran the Ant testsuite against Java 20 build 20+36-2344 and Java 21 EA
build 21-ea+11-905. No regressions were found:
https://ci-builds.apache.org/job/Ant/job/Ant%20Master%20Linux%20(latest%20EA%20JDK)/33/
https://ci-builds.apache.org/job/Ant/job/Ant%20Master%20Linux%20(latest%2
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446276764
https://bz.apache.org/bugzilla/show_bug.cgi?id=66496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446269521
I'll create a bugzilla issue to scan for Resource#toString uses. This change
here is fine as it is and we don't need to clutter it with more discussion.
Thank you for catching this @dreis
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401
Hello Stefan,
> Looks as if StringResource printed its contents, but that seems wrong to
me as there may be more places where code expects toString to not reveal the
contents.
Ag
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553
I wonder what kind of `Resource` this is as `Resource#toString` is expected
to only print the resource's name - and this is what the code here relied on.
Looks as if `StringResource` printed i
asfgit closed pull request #199: Use verbose log level for loading stylesheets
URL: https://github.com/apache/ant/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446237933
Thank you for these changes. Looks good to me. I'll merge this shortly.
Since this is your first contribution to the Ant project, I'll be adding
`Christoph Dreis` to our contributors list
htt
dreis2211 commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118662584
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
