[GitHub] [ant] bodewig commented on pull request #129: Extract LegacyPlainResultFormatter.Stats#appendElapsed

2020-07-29 Thread GitBox
bodewig commented on pull request #129: URL: https://github.com/apache/ant/pull/129#issuecomment-665652034 Many thanks. By which name would you want us to credit you in Ant's CONTRIBUTORS file @simon04 ? This is an automated

[GitHub] [ant] bodewig merged pull request #115: Remove duplicated code

2020-07-29 Thread GitBox
bodewig merged pull request #115: URL: https://github.com/apache/ant/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig merged pull request #131: Another getCheckedRef() refactoring

2020-07-29 Thread GitBox
bodewig merged pull request #131: URL: https://github.com/apache/ant/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig merged pull request #123: Superfluous escapes

2020-07-29 Thread GitBox
bodewig merged pull request #123: URL: https://github.com/apache/ant/pull/123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig commented on pull request #130: Correct javadoc

2020-07-29 Thread GitBox
bodewig commented on pull request #130: URL: https://github.com/apache/ant/pull/130#issuecomment-665510741 For reference: https://bz.apache.org/bugzilla/show_bug.cgi?id=64612 I was under the false impression we had added selectors to all resource collections, obviously I am wrong. So

[GitHub] [ant] bodewig closed pull request #110: Backport magic names

2020-07-29 Thread GitBox
bodewig closed pull request #110: URL: https://github.com/apache/ant/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig commented on pull request #126: support to access local properties via propertyset

2020-07-29 Thread GitBox
bodewig commented on pull request #126: URL: https://github.com/apache/ant/pull/126#issuecomment-665651176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [ant] bodewig closed pull request #90: solve the unconsistent comments

2020-07-29 Thread GitBox
bodewig closed pull request #90: URL: https://github.com/apache/ant/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code

2020-07-29 Thread GitBox
bodewig commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r46659 ## File path: src/main/org/apache/tools/ant/listener/Log4jListener.java ## @@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) { fi

[GitHub] [ant] bodewig merged pull request #129: Extract LegacyPlainResultFormatter.Stats#appendElapsed

2020-07-29 Thread GitBox
bodewig merged pull request #129: URL: https://github.com/apache/ant/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] twogee commented on a change in pull request #133: Class.newInstance() is deprecated in Java 9+

2020-07-29 Thread GitBox
twogee commented on a change in pull request #133: URL: https://github.com/apache/ant/pull/133#discussion_r462240094 ## File path: src/main/org/apache/tools/zip/ExtraFieldUtils.java ## @@ -81,10 +87,10 @@ public static void register(Class c) { * @since 1.1 */ p

[GitHub] [ant] babasaikiran commented on pull request #126: support to access local properties via propertyset

2020-07-29 Thread GitBox
babasaikiran commented on pull request #126: URL: https://github.com/apache/ant/pull/126#issuecomment-665677054 @bodewig , had a look at the fail case.. seems this particular testcase is failing only on windows environment. Will try to get a windows machine to try and fix it.

[GitHub] [ant] bodewig merged pull request #130: Correct javadoc

2020-07-29 Thread GitBox
bodewig merged pull request #130: URL: https://github.com/apache/ant/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig commented on a change in pull request #133: Class.newInstance() is deprecated in Java 9+

2020-07-29 Thread GitBox
bodewig commented on a change in pull request #133: URL: https://github.com/apache/ant/pull/133#discussion_r462221738 ## File path: src/main/org/apache/tools/zip/ExtraFieldUtils.java ## @@ -81,10 +87,10 @@ public static void register(Class c) { * @since 1.1 */

[GitHub] [ant] bodewig merged pull request #133: Class.newInstance() is deprecated in Java 9+

2020-07-29 Thread GitBox
bodewig merged pull request #133: URL: https://github.com/apache/ant/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig merged pull request #132: More MagicNames

2020-07-29 Thread GitBox
bodewig merged pull request #132: URL: https://github.com/apache/ant/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig commented on pull request #131: Another getCheckedRef() refactoring

2020-07-29 Thread GitBox
bodewig commented on pull request #131: URL: https://github.com/apache/ant/pull/131#issuecomment-665259898 I don't see any reason to deprecate `DATA_TYPE_NAME`, You don't need to do that for the refactoring aynway. This is a

[GitHub] [ant] twogee commented on a change in pull request #115: Remove duplicated code

2020-07-29 Thread GitBox
twogee commented on a change in pull request #115: URL: https://github.com/apache/ant/pull/115#discussion_r461633282 ## File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java ## @@ -221,8 +221,6 @@ private String macroSubs(String s, Map macroMapping) {

[GitHub] [ant] bodewig commented on a change in pull request #132: More MagicNames

2020-07-29 Thread GitBox
bodewig commented on a change in pull request #132: URL: https://github.com/apache/ant/pull/132#discussion_r461854203 ## File path: src/main/org/apache/tools/ant/MagicNames.java ## @@ -207,11 +207,17 @@ private MagicNames() { */ public static final String REFID_LOCAL

[GitHub] [ant] bodewig commented on pull request #130: Correct javadoc

2020-07-29 Thread GitBox
bodewig commented on pull request #130: URL: https://github.com/apache/ant/pull/130#issuecomment-665257192 I don't understand why you want to change the filelist examples to use fileset. The other file is a Java file used inside of a test for rmic. -

[GitHub] [ant] twogee opened a new pull request #133: Class.newInstance() is deprecated in Java 9+

2020-07-29 Thread GitBox
twogee opened a new pull request #133: URL: https://github.com/apache/ant/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t