bodewig commented on pull request #129:
URL: https://github.com/apache/ant/pull/129#issuecomment-665652034
Many thanks. By which name would you want us to credit you in Ant's
CONTRIBUTORS file @simon04 ?
This is an automated
bodewig merged pull request #115:
URL: https://github.com/apache/ant/pull/115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig merged pull request #131:
URL: https://github.com/apache/ant/pull/131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig merged pull request #123:
URL: https://github.com/apache/ant/pull/123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig commented on pull request #130:
URL: https://github.com/apache/ant/pull/130#issuecomment-665510741
For reference: https://bz.apache.org/bugzilla/show_bug.cgi?id=64612
I was under the false impression we had added selectors to all resource
collections, obviously I am wrong. So
bodewig closed pull request #110:
URL: https://github.com/apache/ant/pull/110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig commented on pull request #126:
URL: https://github.com/apache/ant/pull/126#issuecomment-665651176
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
bodewig closed pull request #90:
URL: https://github.com/apache/ant/pull/90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r46659
##
File path: src/main/org/apache/tools/ant/listener/Log4jListener.java
##
@@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) {
fi
bodewig merged pull request #129:
URL: https://github.com/apache/ant/pull/129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
twogee commented on a change in pull request #133:
URL: https://github.com/apache/ant/pull/133#discussion_r462240094
##
File path: src/main/org/apache/tools/zip/ExtraFieldUtils.java
##
@@ -81,10 +87,10 @@ public static void register(Class c) {
* @since 1.1
*/
p
babasaikiran commented on pull request #126:
URL: https://github.com/apache/ant/pull/126#issuecomment-665677054
@bodewig , had a look at the fail case.. seems this particular testcase is
failing only on windows environment.
Will try to get a windows machine to try and fix it.
bodewig merged pull request #130:
URL: https://github.com/apache/ant/pull/130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig commented on a change in pull request #133:
URL: https://github.com/apache/ant/pull/133#discussion_r462221738
##
File path: src/main/org/apache/tools/zip/ExtraFieldUtils.java
##
@@ -81,10 +87,10 @@ public static void register(Class c) {
* @since 1.1
*/
bodewig merged pull request #133:
URL: https://github.com/apache/ant/pull/133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig merged pull request #132:
URL: https://github.com/apache/ant/pull/132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bodewig commented on pull request #131:
URL: https://github.com/apache/ant/pull/131#issuecomment-665259898
I don't see any reason to deprecate `DATA_TYPE_NAME`, You don't need to do
that for the refactoring aynway.
This is a
twogee commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r461633282
##
File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
##
@@ -221,8 +221,6 @@ private String macroSubs(String s, Map
macroMapping) {
bodewig commented on a change in pull request #132:
URL: https://github.com/apache/ant/pull/132#discussion_r461854203
##
File path: src/main/org/apache/tools/ant/MagicNames.java
##
@@ -207,11 +207,17 @@ private MagicNames() {
*/
public static final String REFID_LOCAL
bodewig commented on pull request #130:
URL: https://github.com/apache/ant/pull/130#issuecomment-665257192
I don't understand why you want to change the filelist examples to use
fileset.
The other file is a Java file used inside of a test for rmic.
-
twogee opened a new pull request #133:
URL: https://github.com/apache/ant/pull/133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
21 matches
Mail list logo