bodewig commented on a change in pull request #133:
URL: https://github.com/apache/ant/pull/133#discussion_r462221738
##########
File path: src/main/org/apache/tools/zip/ExtraFieldUtils.java
##########
@@ -81,10 +87,10 @@ public static void register(Class<?> c) {
* @since 1.1
*/
public static ZipExtraField createExtraField(ZipShort headerId)
- throws InstantiationException, IllegalAccessException {
+ throws InstantiationException, IllegalAccessException,
NoSuchMethodException, InvocationTargetException {
Review comment:
this changes the signature of a public method, I'm afraid we can not do
this without breaking backwards compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
