Re: svn commit: r743910 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/Javac.java

2009-02-13 Thread Jesse Glick
Stefan Bodewig wrote: if (!f.getName().equals("package-info.java")) { continue; should that test better be case-insensitive? Should it? I don't know. It seemed to work on XP as is. Would someone really specifically create a file PACKAGE-INFO.JAVA? Windows does at le

Re: svn commit: r743910 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/Javac.java

2009-02-13 Thread Peter Reilly
The version is 1.5 - and it is not meant to be replaced! Peter On Fri, Feb 13, 2009 at 3:04 PM, Dominique Devienne wrote: > On Thu, Feb 12, 2009 at 4:35 PM, wrote: >> +private static final byte[] PACKAGE_INFO_CLASS_HEADER = { >> +(byte) 0xca, (byte) 0xfe, (byte) 0xba, (byte) 0xbe,

Re: svn commit: r743910 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/Javac.java

2009-02-13 Thread Stefan Bodewig
good idea! On 2009-02-12, wrote: >>private void lookForPackageInfos(File srcDir, File[] newFiles) { >>for (int i = 0; i < newFiles.length; i++) { >>File f = newFiles[i]; >>if (!f.getName().equals("package-info.java")) { >>continue; should that

Re: svn commit: r743910 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/Javac.java

2009-02-13 Thread Dominique Devienne
On Thu, Feb 12, 2009 at 4:35 PM, wrote: > +private static final byte[] PACKAGE_INFO_CLASS_HEADER = { > +(byte) 0xca, (byte) 0xfe, (byte) 0xba, (byte) 0xbe, 0x00, 0x00, 0x00, > +0x31, 0x00, 0x07, 0x07, 0x00, 0x05, 0x07, 0x00, 0x06, 0x01, 0x00, > 0x0a, > +0x53, 0x6f, 0x

Re: Changing manifest task to accept classpath by reference and nested element!

2009-02-13 Thread Stefan Bodewig
On 2009-02-12, pedro surf wrote: > I believe changing the manifest task to accept a classpathref as a > parameter or a nested element would be a great change that would > increase the readability of the build and reduce the amount of code > necessary to do a simple (and usual) task. I'd probably