Purpose of FileUtils.close(...) (was: Re: [Patch] FileUtils more minor changes)

2004-12-16 Thread Jesse Glick
Kev Jackson wrote: As an aside, I went through the entire codebase last night and replaced every try { somthing.close() } catch (IOException e) { //swallow exception } with FileUtils.close() So what exactly *is* the intention of this method? IMHO, if an IOException was thrown when some strea

DO NOT REPLY [Bug 8031] - [PATCH] Suggest ProjectHelperImpl use File.toURI().toURL().toExternalForm()

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug

DO NOT REPLY [Bug 32718] - Cannot determine Ant home from Locator class if path contains umlauts

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant IntrospectionHelper.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 13:11:19 Modified:src/main/org/apache/tools/ant IntrospectionHelper.java Log: More LOC; also shrank constructor so checkstyle wouldn't complain. Revision ChangesPath 1.93 +176 -232 ant/src/main/org/apache/tools/ant/IntrospectionHelper.java I

cvs commit: ant/src/main/org/apache/tools/ant RuntimeConfigurable.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 13:10:32 Modified:src/main/org/apache/tools/ant RuntimeConfigurable.java Log: LOC Revision ChangesPath 1.58 +2 -4 ant/src/main/org/apache/tools/ant/RuntimeConfigurable.java Index: RuntimeConfigurable.java ==

Re: [Fwd: globmapper directory character interpreting]

2004-12-16 Thread Matt Benson
--- Stefan Bodewig <[EMAIL PROTECTED]> wrote: [SNIP] > >>>One could add an attribute to globmapper to tell > it to do the > >>>interpertation ("handledirchars" ?), > >>> > >> > >>I'd prefer an explicit attribute and use the same > attribute for the > >>regexp mapper as well. > >> > > I am neutral o

Re: [Fwd: globmapper directory character interpreting]

2004-12-16 Thread Stefan Bodewig
On Wed, 08 Dec 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: > Stefan Bodewig wrote: > >>On Mon, 06 Dec 2004, Peter Reilly <[EMAIL PROTECTED]> wrote: >>>One can of course use ${file.separator}, but this does make the >>>scripts look ugly and one is not inclined to do this. >> >>But likely is the

DO NOT REPLY [Bug 32732] - Project default attribute is no longer required

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 32738] New: - Delete task won't be quiet

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 10:13:18 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Yet more bumming & javadoc. You'd think I'd have stopped by now... Revision ChangesPath 1.43 +27 -34ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: Co

cvs commit: ant/src/main/org/apache/tools/ant RuntimeConfigurable.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 09:43:40 Modified:src/main/org/apache/tools/ant RuntimeConfigurable.java Log: Small refactoring Revision ChangesPath 1.57 +1 -2 ant/src/main/org/apache/tools/ant/RuntimeConfigurable.java Index: RuntimeConfigurable.java

cvs commit: ant/src/main/org/apache/tools/ant TaskAdapter.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 09:44:28 Modified:src/main/org/apache/tools/ant TaskAdapter.java Log: Mostly javadoc Revision ChangesPath 1.33 +6 -11 ant/src/main/org/apache/tools/ant/TaskAdapter.java Index: TaskAdapter.java

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread mbenson
mbenson 2004/12/16 08:51:11 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Same LOC count, minus 2 method calls, cute implementation. ;) Revision ChangesPath 1.42 +3 -3 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: Compone

cvs commit: ant/docs/manual using.html

2004-12-16 Thread mbenson
mbenson 2004/12/16 08:24:57 Modified:docs/manual Tag: ANT_16_BRANCH using.html Log: Sync from HEAD Revision ChangesPath No revision No revision 1.31.2.5 +14 -1 ant/docs/manual/using.html Index: using.html ===

cvs commit: ant/docs/manual using.html

2004-12-16 Thread mbenson
mbenson 2004/12/16 08:23:22 Modified:docs/manual using.html Log: Mark project's default attribute as optional (again!). PR: 32732 Revision ChangesPath 1.36 +6 -1 ant/docs/manual/using.html Index: using.html ==

cvs commit: ant/src/testcases/org/apache/tools/ant/types/selectors ModifiedSelectorTest.java

2004-12-16 Thread bodewig
bodewig 2004/12/16 06:01:40 Modified:src/main/org/apache/tools/ant/types Path.java src/main/org/apache/tools/ant/util JavaEnvUtils.java src/testcases/org/apache/tools/ant/filters ConcatFilterTest.java DynamicFilterTest.java

cvs commit: ant build.xml

2004-12-16 Thread bodewig
bodewig 2004/12/16 06:06:59 Modified:.build.xml Log: SplashScreenTest can't be compiled without SplashTask Revision ChangesPath 1.445 +1 -0 ant/build.xml Index: build.xml === RCS fil

cvs commit: ant/src/main/org/apache/tools/ant/types/selectors DateSelector.java

2004-12-16 Thread peterreilly
peterreilly2004/12/16 07:02:48 Modified:src/main/org/apache/tools/ant/types/selectors DateSelector.java Log: Checkstyle Revision ChangesPath 1.16 +1 -1 ant/src/main/org/apache/tools/ant/types/selectors/DateSelector.java Index: DateS

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2004-12-16 Thread peterreilly
peterreilly2004/12/16 06:57:10 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Checkstyle Revision ChangesPath 1.41 +1 -1 ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

DO NOT REPLY [Bug 32732] New: - Project default attribute is no longer required

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/vss MSVSS.java

2004-12-16 Thread peterreilly
peterreilly2004/12/16 01:50:08 Modified:src/main/org/apache/tools/ant/taskdefs/optional/vss MSVSS.java Log: Checkstyle - Kevin Jackson mods Revision ChangesPath 1.41 +210 -237 ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.jav

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/vss MSVSS.java

2004-12-16 Thread peterreilly
peterreilly2004/12/16 01:50:34 Modified:src/main/org/apache/tools/ant/taskdefs/optional/vss Tag: ANT_16_BRANCH MSVSS.java Log: sync Revision ChangesPath No revision No revision 1.34.2.7 +210 -237 ant/src/m

Re: New selector for creating a fileset. How do I use it?

2004-12-16 Thread Stefan Bodewig
On Wed, 15 Dec 2004, Rob Anderson <[EMAIL PROTECTED]> wrote: > I have written a new selector for creating a fileset. This selector > will select files that are checked out of clearcase. How do I > configure Ant to recognize my new selector? it. Stefan --

DO NOT REPLY [Bug 18945] - subversion

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 32727] - Version 1.6.2 doesn't include becl package??

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 32727] New: - Version 1.6.2 doesn't include becl package??

2004-12-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[Patch] MSVSS.java

2004-12-16 Thread Kev Jackson
- var names - style - javadoc The first of many... Index: MSVSS.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java,v retrieving revision 1.40 diff -u -r1.40 MSVSS.java --- MSVSS.java

[Patch] FileUtils more minor changes

2004-12-16 Thread Kev Jackson
- new generic close method - reduces duplicate code (may be useful for when we can finally remove code -> Ant2?) - minor loop tweak - buffer compare for JDK1.4+ (only runs on files < 1Mb to conserve memory during builds) +int stackSize = s.size(); while (tok.hasMoreTokens()) {

New selector for creating a fileset. How do I use it?

2004-12-16 Thread Anderson, Rob (Global Trade)
I have written a new selector for creating a fileset. This selector will select files that are checked out of clearcase. How do I configure Ant to recognize my new selector? Or does it automatically recognize anything in the package org.apache.tools.ant.types.selectors? Thanks, ___