DO NOT REPLY [Bug 32725] New: - Default value for macrodef element parameter

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant AntTypeDefinition.java ComponentHelper.java RuntimeConfigurable.java

2004-12-15 Thread mbenson
mbenson 2004/12/15 15:44:06 Modified:src/main/org/apache/tools/ant AntTypeDefinition.java ComponentHelper.java RuntimeConfigurable.java Log: More javadoc work and LOC bumming. Revision ChangesPath 1.15 +75 -128 ant/src/main/org/apache/tools/

cvs commit: ant/src/testcases/org/apache/tools/ant/types PermissionsTest.java

2004-12-15 Thread mbenson
mbenson 2004/12/15 15:44:31 Modified:src/testcases/org/apache/tools/ant/types PermissionsTest.java Log: Spelling Revision ChangesPath 1.7 +1 -1 ant/src/testcases/org/apache/tools/ant/types/PermissionsTest.java Index: PermissionsTes

DO NOT REPLY [Bug 8031] - [PATCH] Suggest ProjectHelperImpl use File.toURI().toURL().toExternalForm()

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug

DO NOT REPLY [Bug 32718] - Cannot determine Ant home from Locator class if path contains umlauts

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 8031] - [PATCH] Suggest ProjectHelperImpl use File.toURI().toURL().toExternalForm()

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug

DO NOT REPLY [Bug 8031] - [PATCH] Suggest ProjectHelperImpl use File.toURI().toURL().toExternalForm()

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug

DO NOT REPLY [Bug 32718] - Cannot determine Ant home from Locator class if path contains umlauts

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs PreSetDef.java

2004-12-15 Thread mbenson
mbenson 2004/12/15 13:47:19 Modified:src/main/org/apache/tools/ant/taskdefs PreSetDef.java Log: LOC bumming and Javadoc Revision ChangesPath 1.14 +58 -84ant/src/main/org/apache/tools/ant/taskdefs/PreSetDef.java Index: PreSetDef.java ===

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
--- Matt Benson <[EMAIL PROTECTED]> wrote: > I rarely document overridden methods myself, but I > will admit that I may have accidentally deleted > information detailing how the subclass > implementation > differs or elaborates substantially upon the base > implementation. I will go back today a

Re: cvs commit: ant/src/etc/testcases/taskdefs touch.xml

2004-12-15 Thread Matt Benson
--- [EMAIL PROTECTED] wrote: > Log: > use Touch#addConfigured(Mapper) rather than > add(Mapper) as the mapper is > used in the method > Thanks for that. -Matt __ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yah

cvs commit: ant/src/main/org/apache/tools/ant/types/selectors DateSelector.java

2004-12-15 Thread mbenson
mbenson 2004/12/15 08:37:11 Modified:src/main/org/apache/tools/ant/types/selectors DateSelector.java Log: Javadoc Revision ChangesPath 1.15 +17 -17 ant/src/main/org/apache/tools/ant/types/selectors/DateSelector.java Index: DateSelecto

Re: JUnitTask is too complex

2004-12-15 Thread Stefan Bodewig
On Wed, 15 Dec 2004, Yves Martin <[EMAIL PROTECTED]> wrote: > But why not create a junit2 and made junit deprecated ? Because you'll have to convince us as well as the existing task user base why they'd prefer . Less options and potentially more tasks won't be good selling arguments ;-) > Wa

cvs commit: ant/src/etc/testcases/taskdefs touch.xml

2004-12-15 Thread peterreilly
peterreilly2004/12/15 09:23:25 Modified:src/main/org/apache/tools/ant/taskdefs Touch.java src/testcases/org/apache/tools/ant/taskdefs TouchTest.java src/etc/testcases/taskdefs touch.xml Log: use Touch#addConfigured(Mapper) rather than add(Mapper) as the

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
I rarely document overridden methods myself, but I will admit that I may have accidentally deleted information detailing how the subclass implementation differs or elaborates substantially upon the base implementation. I will go back today and take a second look at what I deleted. --- Peter Rei

cvs commit: ant/src/main/org/apache/tools/ant PropertyHelper.java

2004-12-15 Thread mbenson
mbenson 2004/12/15 08:40:22 Modified:src/main/org/apache/tools/ant PropertyHelper.java Log: For non-debug (verbose) log messages, enclose property names in double quotes for clarity. Fix cases where "property name" is logged as '${property name}' as that notation more appropriat

cvs commit: ant/src/etc/testcases/taskdefs touch.xml

2004-12-15 Thread mbenson
mbenson 2004/12/15 08:09:27 Modified:src/etc/testcases/taskdefs touch.xml Log: Add time zone to the test case. Revision ChangesPath 1.5 +3 -3 ant/src/etc/testcases/taskdefs/touch.xml Index: touch.xml ==

Re: JUnitTask is too complex

2004-12-15 Thread Yves Martin
Stefan Bodewig <[EMAIL PROTECTED]> writes: > Before you get too excited by the opportunities (and yes, has > collected quite a bit of historic cruft) - we are not going to remove a > single attribute or nested element of any existing task, since backwards > compatibility is an extremely important

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Peter Reilly
Hi Matt, the following changes remove information from the javadoc. Peter [EMAIL PROTECTED] wrote: mbenson 2004/12/14 13:18:08 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java Log: Javadoc Revision ChangesPath 1.110 +31 -50a

Re: AW: [GUMP@brutus]: Project test-ant (in module ant) failed

2004-12-15 Thread Matt Benson
I was afraid something could go wrong with that particular testcase. Hmm... --- [EMAIL PROTECTED] wrote: > [junit] Testsuite: > org.apache.tools.ant.taskdefs.TouchTest > [junit] Tests run: 11, Failures: 0, Errors: 1, > Time elapsed: 0.75 sec > [junit] Testcase: > testGoodPattern(org.apac

Re: JUnitTask is too complex

2004-12-15 Thread Stefan Bodewig
On Wed, 15 Dec 2004, Yves Martin <[EMAIL PROTECTED]> wrote: > As a proposal, I think a simpler 'junit' task would be enough and > may avoid troubles: Before you get too excited by the opportunities (and yes, has collected quite a bit of historic cruft) - we are not going to remove a single att

DO NOT REPLY [Bug 32718] New: - Cannot determine Ant home from Locator class if path contains umlauts

2004-12-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Bug in JUnitReport: multiple reports of the same testcase

2004-12-15 Thread Yves Martin
Hello, To keep history of run test cases, I create a report per run with a timestamp in the file name. So I can have many files with the same test case run many times... and at the first sight, it seems that junitreport task do not support well such an input. The package summary is OK (

JUnitTask is too complex

2004-12-15 Thread Yves Martin
Hello, I'm working on a build system based on plugin, and I'm currently writting a 'junit' plugin to call test cases and to generate report... And I find the 'junit' optionnal task really complex (from the user-side point of view). The big trouble for me is that it is possible to declare

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/rmic KaffeRmic.java

2004-12-15 Thread bodewig
bodewig 2004/12/15 04:31:44 Modified:.Tag: ANT_16_BRANCH WHATSNEW src/main/org/apache/tools/ant/taskdefs/rmic Tag: ANT_16_BRANCH KaffeRmic.java Log: merge Revision ChangesPath No revision No

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/rmic KaffeRmic.java

2004-12-15 Thread bodewig
bodewig 2004/12/15 04:28:29 Modified:.WHATSNEW src/main/org/apache/tools/ant/taskdefs/rmic KaffeRmic.java Log: Document Kaffe rmic changes Revision ChangesPath 1.699 +3 -0 ant/WHATSNEW Index: WHATSNEW

Re: [Patch] FileUtils to use own close method

2004-12-15 Thread Stefan Bodewig
On Mon, 13 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > -FileUtils now uses close to close inputstreams inside itself I've applied this part of the patch, but have some more comments on the rest: > +int stackSize = s.size(); > while (tok.hasMoreTokens()) { > String thi

cvs commit: ant/src/main/org/apache/tools/ant/util FileUtils.java

2004-12-15 Thread bodewig
bodewig 2004/12/15 04:10:43 Modified:src/main/org/apache/tools/ant/util FileUtils.java Log: Use close method to close streams, Submitted by Kevin Jackson Revision ChangesPath 1.79 +6 -18 ant/src/main/org/apache/tools/ant/util/FileUtils.java Index: FileUtils.

AW: [GUMP@brutus]: Project test-ant (in module ant) failed

2004-12-15 Thread Jan . Materne
[junit] Testsuite: org.apache.tools.ant.taskdefs.TouchTest [junit] Tests run: 11, Failures: 0, Errors: 1, Time elapsed: 0.75 sec [junit] Testcase: testGoodPattern(org.apache.tools.ant.taskdefs.TouchTest): Caused an ERROR [junit] condition satisfied [junit] /home/gump/workspace

RE: Internal AntCall and references

2004-12-15 Thread Jose Alberto Fernandez
> From: Yves Martin [mailto:[EMAIL PROTECTED] > > > Stefan Bodewig <[EMAIL PROTECTED]> writes: > > > On Mon, 13 Dec 2004, Yves Martin <[EMAIL PROTECTED]> wrote: > > > >> To clean it, I decided to use project references but it does not > >> work with 'antcall': > > > > This is because you set

RE: Internal AntCall and references

2004-12-15 Thread Jose Alberto Fernandez
Isn't there a task in Ant-contrib that allows returning values from the sub-build to the main? Can't remember its name. Jose Alberto > -Original Message- > From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Sent: 15 December 2004 08:10 > To: [EMAIL PROTECTED] > Subject: Re: Internal AntCal

[GUMP@brutus]: Project test-ant (in module ant) failed

2004-12-15 Thread Gump Integration Build
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project test-ant has an issue affecting its community integration. This issue affects 1 p

Re: Internal AntCall and references

2004-12-15 Thread Yves Martin
Stefan Bodewig <[EMAIL PROTECTED]> writes: > On Mon, 13 Dec 2004, Yves Martin <[EMAIL PROTECTED]> wrote: > >> To clean it, I decided to use project references but it does not >> work with 'antcall': > > This is because you set the reference in a different Project instance > than you try to read

cvs commit: ant/src/main/org/apache/tools/zip ZipEntry.java ZipOutputStream.java

2004-12-15 Thread bodewig
bodewig 2004/12/15 00:14:08 Modified:src/main/org/apache/tools/zip ZipEntry.java ZipOutputStream.java Log: Loop optimization, Submitted by Kevin Jackson Revision ChangesPath 1.22 +3 -5 ant/src/main/org/apache/tools/zip/ZipEntry.java

Re: Internal AntCall and references

2004-12-15 Thread Stefan Bodewig
On Mon, 13 Dec 2004, Yves Martin <[EMAIL PROTECTED]> wrote: > To clean it, I decided to use project references but it does not > work with 'antcall': This is because you set the reference in a different Project instance than you try to read it in. > target A >antcall B >MyTask{getRefe

Re: PropertyHelper log message

2004-12-15 Thread Stefan Bodewig
On Tue, 14 Dec 2004, Matt Benson <[EMAIL PROTECTED]> wrote: > I'd like to know the popular opinion on the subject. No "popular opinion", just mine. 8-) Make that "foo" - and yes, for the override message as well, Jan. Stefan -

Re: LibrariesTest

2004-12-15 Thread Stefan Bodewig
On Tue, 14 Dec 2004, Matt Benson <[EMAIL PROTECTED]> wrote: > ...is in oata.taskdefs. Should it not be in > oata.taskdefs.repository ? Yes, I agree. Also it currently fails for me (hijacking your subject line 8-) after a fresh bootstrap. [junit] Download count mismatch: expected 0 but fetc

AW: PropertyHelper log message

2004-12-15 Thread Jan . Materne
You can change that, but then with your second suggestion \"foo\" because property names could contain blanks. And that would be hard to read. Mmh, the override-ignored message doesnt contain the \" neither. Override ignored for property with blank What do you think here? (setNewProperty(

[Patch] Minor tweaks to ZipEntry and ZipOutputStream

2004-12-15 Thread kj
- changed format of for loops to remove method calls - removed other method calls - made access to ZipEntry.DEFLATED/STORED more explicit to stop compiler whining - changed one javadoc On large file sets the VM should work a little less (a few method calls/entry) -> minor performance improvement.