Re: [VOTE] February 2025 PR of the Month

2025-02-26 Thread Ryan Hamilton
#46942 given how good it feels to see that much code deleted. On Wed, Feb 26, 2025 at 7:04 AM Rahul Vats wrote: > +1 for https://github.com/apache/airflow/pull/46939 > > Regards, > Rahul Vats > > > > On Wed, 26 Feb 2025 at 15:26, Pierre Jeambrun > wrote: > > > +1 for https://github.com/apache/a

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Stephen Mallette
On 2025/02/26 12:38:02 Jarek Potiuk wrote: > Yeah . `apache/gremlin" seems like a better option then. Does anyone have > anything against it? In the interest of ASF trademarks, I would suggest it be called "apache/tinkerpop" with "Gremlin" naming reserved for operators and the like, as it is

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Jarek Potiuk
> In the interest of ASF trademarks, I would suggest it be called "apache/tinkerpop" with "Gremlin" naming reserved for operators and the like, as it is now with GremlinOperator. I think this makes sense because it is connecting to TinkerPop-enabled systems via Gremlin. I would similarly suggest th

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Jarek Potiuk
Cool. I will let Ahmad comment, but I think we found the **someone** who will help in case there are some future issues with the Tinkerpop/Gremlin provider. While I like Gremlin better (it's just a cool name and I like the logo, tinkerpop has a cool logo as well https://tinkerpop.apache.org/index.h

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Ahmad Farhan
I did look into the naming and I thought that it would need to be discussed at some point before the lazy consensus stage after the dev work is done but I guess I was wrong :) I read through some docs regarding the naming and I kept thinking that Apache Gremlin might not be right, so I decided to

Re: [VOTE] February 2025 PR of the Month

2025-02-26 Thread Vishnu Chilukoori
+1 for https://github.com/apache/airflow/pull/46942 -- Regards, Vishnu Chilukoori On Wed, Feb 26, 2025 at 6:15 AM Pavankumar Gopidesu wrote: > +1 #46942 > > On Wed, Feb 26, 2025 at 2:06 PM Ryan Hamilton > wrote: > > > #46942 given how good it feels to see that much code deleted. > > > > On Wed

Re: [VOTE] February 2025 PR of the Month

2025-02-26 Thread Pavankumar Gopidesu
+1 #46942 On Wed, Feb 26, 2025 at 2:06 PM Ryan Hamilton wrote: > #46942 given how good it feels to see that much code deleted. > > On Wed, Feb 26, 2025 at 7:04 AM Rahul Vats wrote: > > > +1 for https://github.com/apache/airflow/pull/46939 > > > > Regards, > > Rahul Vats > > > > > > > > On Wed,

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Stephen Mallette
On Wed, Feb 26, 2025 at 12:57 PM Jarek Potiuk wrote: > > In the interest of ASF trademarks, I would suggest it be called > "apache/tinkerpop" with "Gremlin" naming reserved for operators and the > like, as it is now with GremlinOperator. I think this makes sense because > it is connecting to Tink

Re: [DISCUSS] Proposal to enhance the PR template

2025-02-26 Thread Ferruzzi, Dennis
Kaxil reviewed and merged it this morning, so I guess we'll see if that did it or not. - ferruzzi From: Amogh Desai Sent: Tuesday, February 25, 2025 10:11 PM To: dev@airflow.apache.org Subject: RE: [EXT] [DISCUSS] Proposal to enhance the PR template CAUTION:

[ANNOUNCE] Final (hopefully) woes with IDE integration in the new providers structure solved

2025-02-26 Thread Jarek Potiuk
Hello here, There was - apparently - one outstanding issue in the new provider structure - VSCode had trouble with recognising imports for cross-provider imports - because apparently it did not recognise implicit - also called native - packages (i.e. folders without __init__.py). We tested it with

[RESULT][VOTE] Airflow Providers - February 21, 2025

2025-02-26 Thread Elad Kalif
Hello, Apache Airflow Providers prepared on January 26, 2025 have been accepted. 3 "+1" binding votes received: - Elad Kalif - Jens Scheffler - Jarek Potiuk 2 "+1" non-binding votes received: - Amogh Desai - Niko Oliveira Vote thread: https://lists.apache.org/thread/05og5mkh44cdpy1tsxlooz2jyvk

Re: [ANNOUNCE] Final (hopefully) woes with IDE integration in the new providers structure solved

2025-02-26 Thread Jarek Potiuk
And I just merged Mikahil's VSCODe update: [4] (cool!). You can read vscode quick-start in [5] [4] https://github.com/apache/airflow/pull/47096 [5] https://github.com/apache/airflow/blob/main/contributing-docs/quick-start-ide/contributors_quick_start_vscode.rst J. On Wed, Feb 26, 2025 at 11:47 

Re: [VOTE] February 2025 PR of the Month

2025-02-26 Thread Pierre Jeambrun
+1 for https://github.com/apache/airflow/pull/46939 On Wed, Feb 26, 2025 at 6:01 AM Amogh Desai wrote: > +1 for https://github.com/apache/airflow/pull/46942 :D > Thanks & Regards, > Amogh Desai > > > On Wed, Feb 26, 2025 at 8:36 AM Ankit Chaurasia > wrote: > > > +1 for 46942, if it gets merged.

[ANNOUNCE] Apache Airflow Providers prepared on February 21, 2025 are released

2025-02-26 Thread Elad Kalif
Dear Airflow community, I'm happy to announce that new versions of Airflow Providers packages prepared on February 21, 2025 were just released. Full list of PyPI packages released is added at the end of the message. The source release, as well as the binary releases, are available here: https://

Re: [VOTE] February 2025 PR of the Month

2025-02-26 Thread Rahul Vats
+1 for https://github.com/apache/airflow/pull/46939 Regards, Rahul Vats On Wed, 26 Feb 2025 at 15:26, Pierre Jeambrun wrote: > +1 for https://github.com/apache/airflow/pull/46939 > > On Wed, Feb 26, 2025 at 6:01 AM Amogh Desai > wrote: > > > +1 for https://github.com/apache/airflow/pull/4694

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Ahmad Farhan
I pushed changes to move the provider into the “apache” directory. After updating the class references across the project, I re-tested and all tests passed. Regarding the use of Gremlin (or another graph query language like Cypher and SPARQL) for a common package approach, here are my thoughts on

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Jarek Potiuk
Yeah . `apache/gremlin" seems like a better option then. Does anyone have anything against it? I think we are pretty happy with accepting "other apache" projects as providers, so I see no issue with Gremlin - knowing that we can always reach out to our friendly Apache Community in case of any issue

Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Ahmad Farhan
I was thinking integration testing might be something to consider for testing this provider, I will have a read through the link and implement that. Thanks Jarek Farhan On Wed, Feb 26, 2025 at 12:40 PM Jarek Potiuk wrote: > Yeah . `apache/gremlin" seems like a better option then. Does anyone ha

RE: Re: [DISCUSS] New Provider for Gremlin

2025-02-26 Thread Stephen Mallette
fascinating - i was just visiting the list to discuss this very topic having just got started building the very same provider. :) Ahmad, thanks for your work jere. It's about inline with what I was planning. A bit about me, I'm one of the earliest contributors to TinkerPop, a current committer an