Wow, so many awesome PRs!
My vote goes to https://github.com/apache/airflow/pull/42959. This is
probably not the "best" PR. As a new contributor, he persists in finishing
the PR despite numerous comments and conflicts regarding this not-so-huge
request. I think this is something we could encourage
Damn.. I thought it was the previous month ;) . Been traveling for too
long. Tough, Tough choice this time
On Tue, Oct 29, 2024 at 10:58 PM Jens Scheffler
wrote:
> My vote is not on the list so far but I'd vote for #42505 - "Split
> providers out of the main "airflow/" tree into a UV worksp
My vote is not on the list so far but I'd vote for #42505 - "Split
providers out of the main "airflow/" tree into a UV workspace project"
by ashb
On 29.10.24 18:46, Jarek Potiuk wrote:
Let's improve the script and the heuristics :) -> propose a PR (and may be
that one will be candidate for the n
Let's improve the script and the heuristics :) -> propose a PR (and may be
that one will be candidate for the next PR of the month :D )
On Tue, Oct 29, 2024 at 6:07 PM Amogh Desai
wrote:
> Ok I got that part!
>
> The reason the score is low is because there are fewer reviews,
> comments and comm
Ok I got that part!
The reason the score is low is because there are fewer reviews,
comments and commits. But there are too many lines changed, which we should
value more!
Thanks & Regards,
Amogh Desai
On Tue, Oct 29, 2024 at 10:32 PM Amogh Desai
wrote:
> So I played around a bit with the PR
So I played around a bit with the PROTM script and this is the result I got:
Top 10 out of 461 PRs:
* PR #42782: AIP-84 Migrate get connections to FastAPI API #42571. Score:
190.008
* PR #43040: Masking configuration values irrelevant to DAG author. Score:
162.89
* PR #42080: Fix consistent ret
I am trying to take a stab at fixing the script for PROTM if there's any
issue there.
The script keeps running forever for me (or I am running out of patience
too soon), trying to check it out.
I will reach out to Briana if that's the case and try to figure it out.
Thanks & Regards,
Amogh Desai
Just to add a bit - Daniel also attempted (for a few brave moments)
considered adding this PR with +60K lines of code.
So not only brave, but also being a contender on both ends of the
spectrum... The best ... and not the best PR of the month maybe :D
J.
On Tue, Oct 29, 2024 at 1:33 PM Amogh Des
https://github.com/apache/airflow/pull/43445
On Tue, Oct 29, 2024 at 3:09 PM Jarek Potiuk wrote:
> Just to add a bit - Daniel also attempted (for a few brave moments)
> considered adding this PR with +60K lines of code.
>
> So not only brave, but also being a contender on both ends of the
> spec
Wow, I wasn't aware of the PR: https://github.com/apache/airflow/pull/42943.
Removing those many lines is extremely brave. My vote goes for that one too!
Thanks & Regards,
Amogh Desai
On Tue, Oct 29, 2024 at 12:55 AM Jarek Potiuk wrote:
> I was sure there were a few more candidates this mon
I was sure there were a few more candidates this month - and I am surprised
to not see them on the list (despite marking them with #protm - we
should likely look at the script :) ).
My personal candidate (and my vote goes to):
https://github.com/apache/airflow/pull/42943 "Remove BackfillJobRunner
11 matches
Mail list logo
