So I played around a bit with the PROTM script and this is the result I got:
Top 10 out of 461 PRs: * PR #42782: AIP-84 Migrate get connections to FastAPI API #42571. Score: 190.008 * PR #43040: Masking configuration values irrelevant to DAG author. Score: 162.89 * PR #42080: Fix consistent return response from PubSubPullSensor. Score: 160.888 * PR #42959: AIP-84 | Public list tags API. Score: 102.336 * PR #42629: AIP-84 Migrate views /object/historical_metrics_data to Fast API. Score: 97.188 * PR #42582: fix schedule_downstream_tasks bug. Score: 91.0 * PR #42808: Follow-up SLA purge. Score: 88.234 * PR #42048: AIP-69: Add Executor to Edge Provider. Score: 86.944 * PR #42725: AIP-84 Migrate GET Dag Run endpoint to FastAPI. Score: 82.992 * PR #42902: Fix PythonOperator DAG error when DAG has hyphen in name. Score: 82.55 On checking Daniel's PR score, this is what we get: *Selecting PR: #42943 `Remove BackfillJobRunner class` as candidate. Score: 10.752. Url: https://github.com/apache/airflow/pull/42943 <https://github.com/apache/airflow/pull/42943>* We calculate the score like so: def calc_interaction_score(self): """calculates interaction score""" interactions = ( self.num_comments + self.num_conv_comments + self.num_issue_comments ) * PrStat.COMMENT_INTERACTION_VALUE interactions += ( self.comment_reactions + self.conv_comment_reactions + self.num_issue_reactions ) * PrStat.REACTION_INTERACTION_VALUE self.interaction_score += interactions + self.num_reviews * PrStat.REVIEW_INTERACTION_VALUE And then we adjust the interaction score like this: def adjust_interaction_score(self): self.interaction_score *= min(self.num_protm + 1, 3) Slightly beats me why we are doing the min(self.num_protm + 1, 3) part here. I think #protm should have a higher score too. The fact that PROTM was added means that somebody valued the PR enough :) Thanks & Regards, Amogh Desai On Tue, Oct 29, 2024 at 7:40 PM Jarek Potiuk <ja...@potiuk.com> wrote: > https://github.com/apache/airflow/pull/43445 > > On Tue, Oct 29, 2024 at 3:09 PM Jarek Potiuk <ja...@potiuk.com> wrote: > > > Just to add a bit - Daniel also attempted (for a few brave moments) > > considered adding this PR with +60K lines of code. > > > > So not only brave, but also being a contender on both ends of the > > spectrum... The best ... and not the best PR of the month maybe :D > > > > J. > > > > On Tue, Oct 29, 2024 at 1:33 PM Amogh Desai <amoghdesai....@gmail.com> > > wrote: > > > >> Wow, I wasn't aware of the PR: > >> https://github.com/apache/airflow/pull/42943. > >> > >> Removing those many lines is extremely brave. My vote goes for that one > >> too! > >> > >> > >> > >> Thanks & Regards, > >> Amogh Desai > >> > >> > >> On Tue, Oct 29, 2024 at 12:55 AM Jarek Potiuk <ja...@potiuk.com> wrote: > >> > >> > I was sure there were a few more candidates this month - and I am > >> surprised > >> > to not see them on the list (despite marking them with #protm - we > >> > should likely look at the script :) ). > >> > > >> > My personal candidate (and my vote goes to): > >> > https://github.com/apache/airflow/pull/42943 "Remove > BackfillJobRunner > >> > class" => with -3500 lines of code. > >> > > >> > > >> > > >> > On Mon, Oct 28, 2024 at 8:12 PM Briana Okyere > >> > <briana.oky...@astronomer.io.invalid> wrote: > >> > > >> > > Hey All, > >> > > > >> > > It’s once again time to vote for the PR of the Month! > >> > > > >> > > With the help of the `get_important_pr_candidates` script in > >> dev/stats, > >> > > we've identified the following candidates: > >> > > > >> > > PR #42782: AIP-84 Migrate get connections to FastAPI API < > >> > > https://github.com/apache/airflow/pull/42782> > >> > > > >> > > PR #43040: Masking configuration values irrelevant to DAG author < > >> > > https://github.com/apache/airflow/pull/43040> > >> > > > >> > > PR #42080: Fix consistent return response from PubSubPullSensor < > >> > > https://github.com/apache/airflow/pull/42080> > >> > > > >> > > PR #42959: AIP-84 | Public list tags API < > >> > > https://github.com/apache/airflow/pull/42959> > >> > > > >> > > PR #42629: AIP-84 Migrate views /object/historical_metrics_data to > >> Fast > >> > API > >> > > <https://github.com/apache/airflow/pull/42629> > >> > > > >> > > Please reply to this thread with your selection or offer your own > >> > > nominee(s). > >> > > > >> > > Voting will close on Friday, Nov. 1st at 10 AM PST. The winner(s) > >> will be > >> > > featured in the next issue of the Airflow newsletter. > >> > > > >> > > Also, if there’s an article or event that you think should be > >> included in > >> > > this or a future issue of the newsletter, please drop me a line at < > >> > > briana.oky...@astronomer.io> > >> > > > >> > > -- > >> > > Briana Okyere > >> > > Community Manager > >> > > Astronomer > >> > > > >> > > >> > > >
