t; > > > > Ive been tossing around a few ideas and I think the best
> > alternative
> > > I
> > > > > > came up with was `deadline.expiration`. It's clear what it means
> > and
> > > > > > doesn't f
ine.expiration`. It's clear what it means
> and
> > > > > doesn't feel too awkward in use. I'm also good with deadline_time
> I
> > > > guess,
> > > > > but `deadline.deadline_time` "f
adline_time I
> > > guess,
> > > > but `deadline.deadline_time` "feels" awkward IMHO
> > > >
> > > >
> > > > - ferruzzi
> > > >
> > > >
> > > >
> > > >
> > doesn't feel too awkward in use. I'm also good with deadline_time I
> > guess,
> > > but `deadline.deadline_time` "feels" awkward IMHO
> > >
> > >
> > > - ferruzzi
> > >
> > >
> > >
> > > Fr
_
> > From: Daniel Standish
> > Sent: Tuesday, May 27, 2025 9:42 AM
> > To: dev@airflow.apache.org
> > Subject: RE: [EXT] [Lazy Concensus] Naming tweak in Deadlines table
> >
> > CAUTION: This email originated from outside of the organization. Do not
> > cl
, May 27, 2025 9:42 AM
> To: dev@airflow.apache.org
> Subject: RE: [EXT] [Lazy Concensus] Naming tweak in Deadlines table
>
> CAUTION: This email originated from outside of the organization. Do not
> click links or open attachments unless you can confirm the sender and know
> the
wkward IMHO
- ferruzzi
From: Daniel Standish
Sent: Tuesday, May 27, 2025 9:42 AM
To: dev@airflow.apache.org
Subject: RE: [EXT] [Lazy Concensus] Naming tweak in Deadlines table
CAUTION: This email originated from outside of the organization. Do not click
links or open a
Generally speaking, it's not a huge problem when you use a reserved word in
a column name. You add backticks or whatever. And we don't write the sql
manually anyway.
That said, plus one for deadline_time. Unless there's some other modifier
better than "deadline_". Don't love the "_at" naming.
Thanks Jens. In light of this, I'm proposing to rename it to "deadline_at" .
I've updated the PR as well. But "deadline_time" also sounds good. We can go
with that as well. I can update PR with what we agree here.
On 2025/05/27 01:47:57 Wei Lee wrote:
> Not sure whether "deadline.deadline_time"
Not sure whether "deadline.deadline_time" is an ok idea 🤔 I also worry about
what Jens said.
Best,
Wei
> On May 27, 2025, at 4:26 AM, Jens Scheffler
> wrote:
>
> Hi Denis,
>
> from point of content of the name matching to the meaning I agree - but I
> have doubts because the column name con
Hi Denis,
from point of content of the name matching to the meaning I agree - but
I have doubts because the column name conflicts with the SQL type that
has the same same. As we use ORM this is mostly fine but other logic
running SQL on the DB might get into conflict if column name "time" is
rawwar is working on some front-end stuff for the Deadlines feature and has a
suggestion to rename the database field which holds the calculated timestamp
from deadline.deadline to deadline.time. This seems reasonable to me and
slightly less confusing, but I wanted to throw it out there for laz
12 matches
Mail list logo
