I like expiration, works with and without the table name. +1 from me in that one. -- Regards, Aritra Basu
On Tue, 27 May 2025, 11:40 pm Ferruzzi, Dennis, <ferru...@amazon.com.invalid> wrote: > Ive been tossing around a few ideas and I think the best alternative I > came up with was `deadline.expiration`. It's clear what it means and > doesn't feel too awkward in use. I'm also good with deadline_time I guess, > but `deadline.deadline_time` "feels" awkward IMHO > > > - ferruzzi > > > ________________________________ > From: Daniel Standish <daniel.stand...@astronomer.io.INVALID> > Sent: Tuesday, May 27, 2025 9:42 AM > To: dev@airflow.apache.org > Subject: RE: [EXT] [Lazy Concensus] Naming tweak in Deadlines table > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur externe. > Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne pouvez > pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain que > le contenu ne présente aucun risque. > > > > Generally speaking, it's not a huge problem when you use a reserved word in > a column name. You add backticks or whatever. And we don't write the sql > manually anyway. > > That said, plus one for deadline_time. Unless there's some other modifier > better than "deadline_". Don't love the "_at" naming. > > On Mon, May 26, 2025 at 7:47 PM Kalyan Reddy <kaly...@apache.org> wrote: > > > Thanks Jens. In light of this, I'm proposing to rename it to > > "deadline_at" . I've updated the PR as well. But "deadline_time" also > > sounds good. We can go with that as well. I can update PR with what we > > agree here. > > > > On 2025/05/27 01:47:57 Wei Lee wrote: > > > Not sure whether "deadline.deadline_time" is an ok idea 🤔 I also worry > > about what Jens said. > > > > > > Best, > > > Wei > > > > > > > On May 27, 2025, at 4:26 AM, Jens Scheffler > <j_scheff...@gmx.de.INVALID> > > wrote: > > > > > > > > Hi Denis, > > > > > > > > from point of content of the name matching to the meaning I agree - > > but I have doubts because the column name conflicts with the SQL type > that > > has the same same. As we use ORM this is mostly fine but other logic > > running SQL on the DB might get into conflict if column name "time" is > not > > quoted. I see a set of pitfalls with the specific name therefore. > > > > > > > > See: https://www.postgresql.org/docs/current/datatype-datetime.html > > > > > > > > In this light I'd propose to keep it like the existing name (as > > timestamp has the same problem which just came into my mind as > alternative) > > > > > > > > Jens > > > > > > > > On 26.05.25 18:09, Ferruzzi, Dennis wrote: > > > >> rawwar is working on some front-end stuff for the Deadlines feature > > and has a suggestion to rename the database field which holds the > > calculated timestamp from deadline.deadline to deadline.time. This seems > > reasonable to me and slightly less confusing, but I wanted to throw it > out > > there for lazy consensus, or you can approve > > https://github.com/apache/airflow/pull/51026 for less-lazy agreement. > > > >> > > > >> Currently the table `deadline` has the following columns: > > > >> > > > >> dag_id > > > >> dagrun_id > > > >> deadline: calculated timestamp > > > >> callback > > > >> callback_kwargs > > > >> > > > >> > > > >> - ferruzzi > > > >> > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > >
