Re: [PATCH] Exclude .tox, distro_tracker/vendor, and docs/conf.py from flake8

2017-12-19 Thread Raphael Hertzog
On Mon, 18 Dec 2017, Ville Skyttä wrote: > -exclude = > .git,.ropeproject,__pycache__,distro_tracker/project/settings/local.py,*/migrations/*.py > +exclude = > .git,.ropeproject,.tox,__pycache__,distro_tracker/project/settings/local.py,distro_tracker/vendor,docs/conf.py,*/migrations/*.py Ok, for

Re: [PATCH] Exclude .tox, distro_tracker/vendor, and docs/conf.py from flake8

2017-12-19 Thread Paul Wise
On Tue, Dec 19, 2017 at 5:13 PM, Raphael Hertzog wrote: > But why distro_tracker/vendor? That sounds like embedded code copies so it should be checked/fixed by the upstream projects rather than by distro-tracker. > And why is it needed at all? I was not getting any warning from those > directori

Re: [PATCH] Exclude .tox, distro_tracker/vendor, and docs/conf.py from flake8

2017-12-19 Thread Ville Skyttä
On Tue, Dec 19, 2017 at 11:13 AM, Raphael Hertzog wrote: > On Mon, 18 Dec 2017, Ville Skyttä wrote: >> -exclude = >> .git,.ropeproject,__pycache__,distro_tracker/project/settings/local.py,*/migrations/*.py >> +exclude = >> .git,.ropeproject,.tox,__pycache__,distro_tracker/project/settings/local.

Bug#884754: bls: detect dpkg-gencontrol: warning: unused/unknown substitution variable

2017-12-19 Thread Mattia Rizzolo
On Tue, Dec 19, 2017 at 01:29:48PM +0800, Paul Wise wrote: > It would be nice to warn about present but unused or used but unknown > dpkg-gencontrol substitution variables. Here is an example of these: > > https://buildd.debian.org/status/fetch.php?pkg=python-backports-shutil-get-terminal-size&arc

Bug#884754: bls: detect dpkg-gencontrol: warning: unused/unknown substitution variable

2017-12-19 Thread Paul Wise
On Tue, Dec 19, 2017 at 6:15 PM, Mattia Rizzolo wrote: > I disagree: "unused substitution variable" often contains stuff that is > deprecated (e.g. ${python:Provides} and ${python:Versions} in your > example) that the maintainer is better off not using it. In general, it is a bug to not use set s