Re: RE : : RFS: autoconf-archive (updated package)

2011-07-08 Thread roucaries bastien
Reuploaded a new version comments online On Thu, Jul 7, 2011 at 5:27 PM, Kilian Krause wrote: > Hi Bastien, > > On Thu, 2011-07-07 at 07:50 +0200, roucaries bastien wrote: >> Please do not upload directly, i will upload git tree before under >> collab maint and postthe final ppackage here. >> >> I

Re: how to get people to run lintian on their packages

2011-07-08 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Karl, On 08.07.2011 05:49, Karl Goetz wrote: >> - The -I and --pedantic options should always be used. > > Why is that? the manual entry for --pedantic says >> Pedantic tags are Lintian at its most pickiest and >> include checks fo

Re: how to get people to run lintian on their packages

2011-07-08 Thread Charles Plessy
Le Fri, Jul 08, 2011 at 11:13:53AM +0200, Arno Töll a écrit : > > That said, some pedantic tags can probably be ignored but most are > nonetheless still a very helpful addition one better should consider > when packaging software. Hello everybody, I would like to add that in my experience, an in

Re: RFS: xxxterm (2nd attempt)

2011-07-08 Thread Kilian Krause
Luis, On Thu, 2011-07-07 at 23:12 +0100, Luis Henriques wrote: > Dear mentors, > > I am looking for a sponsor for my package "xxxterm". > > * Package name: xxxterm > Version : 1.399-1 > Upstream Author : Marco Peereboom , Stevan Andjelkovic > , Edd Barrett , Todd T. Fries > >

Re: how to get people to run lintian on their packages

2011-07-08 Thread Thomas Preud'homme
Le vendredi 8 juillet 2011 11:13:53, Arno Töll a écrit : > Hi Karl, > > On 08.07.2011 05:49, Karl Goetz wrote: > >> - The -I and --pedantic options should always be used. > > > > Why is that? the manual entry for --pedantic says > > > >> Pedantic tags are Lintian at its most pick

RFC: git-flow

2011-07-08 Thread Gergely Nagy
Hi! While I'm not looking for a sponsor for my package, git-flow, I would appreciate any comments regarding the packaging, and all ideas for improvement. * Package name: git-flow Version : 0.4.1-1~preview0 Upstream Author : Vincent Driessen , Kate Ward,

Re: RFS: flush (updated package)

2011-07-08 Thread Bernhard R. Link
* Fabrizio Regalli [110707 21:22]: > > > I am looking for a sponsor for the new version 0.9.10-1 > > > of my package "flush". > > > > Some 'LDFLAGS += -Wl,-z,defs -Wl,--as-needed' should help to get > > the depedency list a bit shortened. > > Ok, I can add this flags. Please do not add -Wl,--as-n

Nitpicking: you are doing it wrong

2011-07-08 Thread Jakub Wilk
(I'm creating a new thread rather than replying to a particular message, because my mail is not at all personal. It's a general tendency amongst many debian-mentors reviewers that I'm going to rant about.) A sponsor on 2011-07-08, 11:22 wrote: 1. You're using debhelper compat 7 and also only de

RFS: usb-imagewriter

2011-07-08 Thread Fabrizio Regalli
Dear mentors, I am looking for a sponsor for my package "usb-imagewriter". * Package name: usb-imagewriter Version : 0.1.3-1 Upstream Author : Oliver Grawert * URL : https://launchpad.net/usb-imagewriter * License : GPL-1 Section : misc It builds th

Re: RFS: usb-imagewriter

2011-07-08 Thread Fabrizio Regalli
On Fri, 2011-07-08 at 12:58 +0200, Fabrizio Regalli wrote: > Dear mentors, > > I am looking for a sponsor for my package "usb-imagewriter". > > * Package name: usb-imagewriter > Version : 0.1.3-1 > Upstream Author : Oliver Grawert > * URL : https://launchpad.net/usb-i

Re: RFS: xxxterm (2nd attempt)

2011-07-08 Thread Luis Henriques
Hi Kilian, Kilian Krause writes: > > Having a look at your package I find: First of all, thanks a lot for looking at the package! Later today I will go through your comments, make all the changes your suggesting and update the package at mentors. A few comments below. > 1. You're using debhe

Re: RFS: usb-imagewriter

2011-07-08 Thread Fabrizio Regalli
On Fri, 2011-07-08 at 13:03 +0200, Fabrizio Regalli wrote: > On Fri, 2011-07-08 at 12:58 +0200, Fabrizio Regalli wrote: > > Dear mentors, > > > > I am looking for a sponsor for my package "usb-imagewriter". > > > > * Package name: usb-imagewriter > > Version : 0.1.3-1 > > Upstream

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Thomas Preud'homme
Le vendredi 8 juillet 2011 12:55:52, Jakub Wilk a écrit : [SNIP] > > > Don't get me wrong, in my opinion (some of) these things are "good". But > making a big fuss about them is not helping anybody. It only distracts > attention from things that are important, and creates false impression > that

Re: RFS: qasmixer

2011-07-08 Thread Sebastian H.
Hello Kilian Also thanks to you for taking the time to review this package. The new package source is uploaded. looking closer at your package I find the following: 1. It's an intial upload to Debian AFAICT. Yet your debian/changelog is cluttered with a number of entries already. For an

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Scott Howard
On Fri, Jul 8, 2011 at 6:55 AM, Jakub Wilk wrote: > Dear reviewers, next time if you are going to complain about: > - debian/compat being "too low"; There are cases where it should be bumped [1], support for old versions gets removed. Many sponsors take the approach "What should be done eventuall

RFS: nullidentd (adopting package)

2011-07-08 Thread Jeroen Schot
Dear mentors, I am looking for a sponsor for the new version 1.0-5 of my package "nullidentd". It builds these binary packages: nullidentd - small, fast identd daemon Here is the ‘lintian’ commandline I ran, and its output: $ lintian -IE --pedantic I: nullidentd source: quilt-patch-missing-desc

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Scott Howard
On Fri, Jul 8, 2011 at 6:55 AM, Jakub Wilk wrote: > Don't get me wrong, in my opinion (some of) these things are "good". But > making a big fuss about them is not helping anybody. It only distracts > attention from things that are important, and creates false impression that > they are somehow cru

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread David Bremner
On Fri, 8 Jul 2011 08:47:31 -0400, Scott Howard wrote: > > > - debian/copyright not in DEP-5 format; > > This is accepted and will be policy soon [3]. "What should be done > eventually must be done immediately." > I think you might misunderstand the DEP process, which is easy to do. The follow

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Wolodja Wentland
On Fri, Jul 08, 2011 at 12:55 +0200, Jakub Wilk wrote: > (I'm creating a new thread rather than replying to a particular > message, because my mail is not at all personal. It's a general > tendency amongst many debian-mentors reviewers that I'm going to > rant about.) > > A sponsor on 2011-07-08,

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08.07.2011 15:56, Wolodja Wentland wrote: >>> 1. You're using debhelper compat 7 and also only debhelper >= >>> 7.0.50~ as Build-Depends. Please bump that to 8 >> >> Seriously? Is the sponsor suggesting that one should be >> build-depending on a new

Re: RFS: nullidentd (adopting package)

2011-07-08 Thread gregor herrmann
On Fri, 08 Jul 2011 14:40:46 +0200, Jeroen Schot wrote: > Here is the ‘lintian’ commandline I ran, and its output: Thank you for providing this information! > $ lintian -IE --pedantic > I: nullidentd source: quilt-patch-missing-description 01_random_usernames.diff > I: nullidentd source: quilt-

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Russ Allbery
Scott Howard writes: > On Fri, Jul 8, 2011 at 6:55 AM, Jakub Wilk wrote: >> - debian/copyright not in DEP-5 format; > This is accepted and will be policy soon [3]. "What should be done > eventually must be done immediately." It will be in Policy and maintained via the Policy process, but it's

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Adam Borowski
On Fri, Jul 08, 2011 at 04:31:49PM +0200, Arno Töll wrote: > On 08.07.2011 15:56, Wolodja Wentland wrote: > > I can understand how this applies to older packages that have been created > > in > > the past and just don't use some of the new functionality, but I guess that > > the points are valid f

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Arno Töll
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Adam, On 08.07.2011 18:24, Adam Borowski wrote: > If you don't make use of newest shiniest features, higher debhelper levels > just make backporting harder for no gain. There is debhelper 8 in both, lenny-backports as well as in squeeze-backports.

Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Andreas Moog
On 07/07/2011 10:43 PM, Paul Wise wrote: > There is one lintian warning: > > I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1 Ups, yes. Symbols file added. > Two cppcheck warnings: > > [libpar2.h:29]: (error) Memory leak: LibPar2::par1Repairer > [libpar2.h:30]: (error) Memory leak

Re: RFS: qasmixer

2011-07-08 Thread Kilian Krause
Hi Sebastian, On Fri, Jul 08, 2011 at 02:05:05PM +0200, Sebastian H. wrote: [...] > >2. Your debian/watch doesn't work. Yield remote version -0.12.0 [...] > The whole point for the 0.12.1 release was to make Debian > integration smoother. Since most things seem to work now I've > uploaded the tarb

Re: RFS: xxxterm (2nd attempt)

2011-07-08 Thread Luis Henriques
Hi, Kilian Krause writes: > Having a look at your package I find: Ok, so I re-worked the package and uploaded a new version into mentors: dget http://mentors.debian.net/debian/pool/main/x/xxxterm/xxxterm_1.399-1.dsc I tried to follow all the advices, a few comments follow. > 1. You're using d

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Michael Tautschnig
Hi Jakub, hi all, [...] (whether or not to request bumping debhelper compat; I do agree with the technical arguments put forward by Jakub, but that's not the focus of my reply) The obvious provocative answer is: Nitpicking is the way to go. As always, however, there's more than black and white ou

Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Kilian Krause
Hi Andreas, On Fri, Jul 08, 2011 at 07:35:41PM +0200, Andreas Moog wrote: > On 07/07/2011 10:43 PM, Paul Wise wrote: > > > There is one lintian warning: > > > > I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1 > > Ups, yes. Symbols file added. [...] > Thanks for checking the packa

Re: RFS: xnoise (2nd try)

2011-07-08 Thread Joachim Wiedorn
Hello Jörn, I have packaged xnoise without any lintian errors/warnings. Very good work. Unfortunately I am not a DD. So you must search further for an sponsor. One tip: Instead of using in debian/rules: override_dh_installman: dh_installman debian/xnoise.1 it is better creating a file d

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Thomas Goirand
Hi, Nice topic, thanks to Jakub for having the good idea to have started it. On 07/08/2011 08:47 PM, Scott Howard wrote: > Right now, the general consensus is the dh and cdbs produce > debian packages that are easier to maintain in the long run (if the > sponsor has to take over maintenance of th

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Thomas Goirand
> > On Fri, Jul 08, 2011 at 12:55 +0200, Jakub Wilk wrote: > > [...] but should be made explicit as the reasons not to use dh, for > example, might mean that the helper is lacking functionality or > behaves buggy in certain situations. I don't get it here... Do you think that debian/rules call

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Thomas Goirand
> Hi Adam, > > On 08.07.2011 18:24, Adam Borowski wrote: > > If you don't make use of newest shiniest features, higher debhelper > levels > > just make backporting harder for no gain. > > There is debhelper 8 in both, lenny-backports as well as in > squeeze-backports. > > Moreover Debian packages t

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Gergely Nagy
Thomas Goirand writes: >> On Fri, Jul 08, 2011 at 12:55 +0200, Jakub Wilk wrote: >> >> [...] but should be made explicit as the reasons not to use dh, for >> example, might mean that the helper is lacking functionality or >> behaves buggy in certain situations. > > I don't get it here... > > D

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Leo "costela" Antunes
On 08/07/11 22:23, Thomas Goirand wrote: > On 07/08/2011 08:47 PM, Scott Howard wrote: >> Right now, the general consensus is the dh and cdbs produce >> debian packages that are easier to maintain in the long run (if the >> sponsor has to take over maintenance of the package or if NMUs are >> requi

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Christian Kastner
On 07/08/2011 12:29 PM, Arno Töll wrote: > On 08.07.2011 18:24, Adam Borowski wrote: >> If you don't make use of newest shiniest features, higher debhelper levels >> just make backporting harder for no gain. > > There is debhelper 8 in both, lenny-backports as well as in > squeeze-backports. There

Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Andreas Moog
On 07/08/2011 09:31 PM, Kilian Krause wrote: > Hi Andreas, > > On Fri, Jul 08, 2011 at 07:35:41PM +0200, Andreas Moog wrote: >> On 07/07/2011 10:43 PM, Paul Wise wrote: >> >>> There is one lintian warning: >>> >>> I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1 >> >> Ups, yes. Symbo

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread George Danchev
On Saturday, July 09, 2011 12:41:09 AM Leo "costela" Antunes wrote: > On 08/07/11 22:23, Thomas Goirand wrote: > > On 07/08/2011 08:47 PM, Scott Howard wrote: > >> Right now, the general consensus is the dh and cdbs produce > >> debian packages that are easier to maintain in the long run (if the >

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Roger Leigh
On Sat, Jul 09, 2011 at 04:23:05AM +0800, Thomas Goirand wrote: > On 07/08/2011 08:47 PM, Scott Howard wrote: > > Right now, the general consensus is the dh and cdbs produce > > debian packages that are easier to maintain in the long run (if the > > sponsor has to take over maintenance of the packa

Re: how to get people to run lintian on their packages

2011-07-08 Thread Karl Goetz
On Fri, 8 Jul 2011 11:32:20 +0200 "Thomas Preud'homme" wrote: > Le vendredi 8 juillet 2011 11:13:53, Arno Töll a écrit : > > Hi Karl, > > > > On 08.07.2011 05:49, Karl Goetz wrote: > > >> - The -I and --pedantic options should always be used. > > > > > > Why is that? the manual entry for --pe

Re: Nitpicking: you are doing it wrong

2011-07-08 Thread Joey Hess
Scott Howard wrote: > From the debhelper manpage > > "Unless otherwise indicated, all debhelper documentation assumes that > you are using the most recent compatibility level, and in most cases > does not indicate if the behavior is different in an earlier > compatibility level, so if you are not