Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Jaromír Mikeš
Od: Tobias Frost Hello Tobias, thank you for reviewing! "Ok, review complete. When below things are fixed, I will upload it. -- tobi d/copyright: (beside the already discussed things) - Files-Excluded not needed - Whats the copyright of the gpx examples? - src/cursors not documented d

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Tobias Frost
On Mon, 2014-08-18 at 09:02 +0200, Jaromír Mikeš wrote: > Od: Sebastiaan Couwenberg > > I think the WTFPL short name should keep the version number, > WTFPL-2 was > better IMHO. > > The text of the QT license exception is still missing the LGPL > e

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Tobias Frost
On Mon, 2014-08-18 at 14:11 +0200, Sebastiaan Couwenberg wrote: > On 08/18/2014 08:52 AM, Tobias Frost wrote: > > Hi Sebastiaan, > > > > On Sun, 2014-08-17 at 23:57 +0200, Sebastiaan Couwenberg wrote: > >> On 08/17/2014 10:55 PM, Tobias Frost wrote: > >>> Regarding the patch: I'm not near a PC ri

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Ansgar Burchardt
On 08/18/2014 14:11, Sebastiaan Couwenberg wrote: > The license header in the artifact doesn't state the "or later", but > refers to the license as published by the FSF which does include it: [...] > The full license text is not included in the header, but is deferred to > the license as published

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Sebastiaan Couwenberg
On 08/18/2014 08:52 AM, Tobias Frost wrote: > Hi Sebastiaan, > > On Sun, 2014-08-17 at 23:57 +0200, Sebastiaan Couwenberg wrote: >> On 08/17/2014 10:55 PM, Tobias Frost wrote: >>> Regarding the patch: I'm not near a PC right now, so can't check: Are you >>> sure the license of those files with t

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Tobias Frost
On Sun, 2014-08-17 at 21:11 +0200, Jaromír Mikeš wrote: Ok, review complete. When below things are fixed, I will upload it. -- tobi d/copyright: (beside the already discussed things) - Files-Excluded not needed - Whats the copyright of the gpx examples? - src/cursors not documented d/dir

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Jaromír Mikeš
Od: Sebastiaan Couwenberg "I think the WTFPL short name should keep the version number, WTFPL-2 was better IMHO. The text of the QT license exception is still missing the LGPL exception text. I suggest at least the changes included in the attached patch. Since the license text of the QT commerc

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-18 Thread Tobias Frost
Hi Sebastiaan, On Sun, 2014-08-17 at 23:57 +0200, Sebastiaan Couwenberg wrote: > On 08/17/2014 10:55 PM, Tobias Frost wrote: > > Regarding the patch: I'm not near a PC right now, so can't check: Are you > > sure the license of those files with the exception had a "or later" on > > their GPL opt

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Sebastiaan Couwenberg
On 08/17/2014 10:55 PM, Tobias Frost wrote: > Regarding the patch: I'm not near a PC right now, so can't check: Are you > sure the license of those files with the exception had a "or later" on their > GPL option? I'm pretty sure about that. The QT project licensing page links to the licenses as

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Sebastiaan Couwenberg
Thanks for incorporating the feedback. I think the WTFPL short name should keep the version number, WTFPL-2 was better IMHO. The text of the QT license exception is still missing the LGPL exception text. I suggest at least the changes included in the attached patch. Since the license text of the

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Jaromír Mikeš
Hello, thank you all for quick responces! I've just uploaded fixed version of qmapshack 0.3.0 to debian mentors. Copyright file now follow SPDX license shortnames. wrap-and-sort -a -s has been run over control and copyright file http://mentors.debian.net/package/qmapshack best regards Jaromir

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Tobias Frost
On Sun, 2014-08-17 at 19:46 +0200, Jaromír Mikeš wrote: > Can you please advice what to do with "LGPL-2.1 with Digia Qt LGPL > Exception 1.1" license? > Files: src/helpers/CTextEditWidget.cpp > src/helpers/CTextEditWidget.h I'd write: "License: QT_COMMERICIAL or GPL-3 or LGPL-2.1 with Digia Qt

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Tobias Frost
On Sun, 2014-08-17 at 19:27 +0200, Sebastiaan Couwenberg wrote: > On 08/17/2014 06:35 PM, Jaromír Mikeš wrote: > > I just uploaded new upstream version of qmapshack 0.3.0 to debian mentors. > > This package fixing all previous issues, I would be grateful for reviewing. > > Regarding the copyright

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Sebastiaan Couwenberg
On 08/17/2014 07:46 PM, Jaromír Mikeš wrote: > Can you please advice what to do with "LGPL-2.1 with Digia Qt LGPL Exception > 1.1" license? The relevant documention in the copyright-format 1.0 states: " An exception or clarification to a license is signalled in plain text, by appending /with keyw

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Jaromír Mikeš
Od: Sebastiaan Couwenberg "On 08/17/2014 06:35 PM, Jaromír Mikeš wrote: > I just uploaded new upstream version of qmapshack 0.3.0 to debian mentors. > This package fixing all previous issues, I would be grateful for reviewing. Regarding the copyright file I suggest to use the SPDX license short

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Sebastiaan Couwenberg
On 08/17/2014 06:35 PM, Jaromír Mikeš wrote: > I just uploaded new upstream version of qmapshack 0.3.0 to debian mentors. > This package fixing all previous issues, I would be grateful for reviewing. Regarding the copyright file I suggest to use the SPDX license shortnames as much as possible. ht

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-17 Thread Jaromír Mikeš
Hello, I just uploaded new upstream version of qmapshack 0.3.0 to debian mentors. This package fixing all previous issues, I would be grateful for reviewing. http://mentors.debian.net/package/qmapshack (I am not regenerating png icons during the build time as package don't need to repacked anym

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-10 Thread Jaromír Mikeš
Od: Tobias Frost Hello Tobias, "On Fri, 2014-08-08 at 14:19 +0200, Jaromír Mikeš wrote: > I already managed to fix few issues in packaging repo: > > http://anonscm.debian.org/cgit/pkg-grass/qmapshack.git Just briefly looked over it :) +1 Jut one thing (probably overlooked earlier): Any re

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-10 Thread Tobias Frost
On Fri, 2014-08-08 at 14:19 +0200, Jaromír Mikeš wrote: > Od: Tobias Frost > (snip) > I already managed to fix few issues in packaging repo: > > http://anonscm.debian.org/cgit/pkg-grass/qmapshack.git Just briefly looked over it :) +1 Jut one thing (probably overlooked earlier): Any reason for y

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-08 Thread Jaromír Mikeš
Od: Tobias Frost Hello Tobias, "- d/copyright is incomplete, there are at least 2 files not documented for the 3rdParty folder. (CGetOpt.cpp and main.cpp) (The html file in this dir is obviously generated by doxygen), the examples gpx are also not in the copyright file. There are two anima

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-06 Thread Tobias Frost
Control: tags -1 moreinfo On Wed, 2014-08-06 at 17:11 +0200, Jaromír Mikeš wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "qmapshack" > > * Package name: qmapshack > Version : 0.2.0+ds1-1 > Upstream Autho

Bug#757243: RFS: qmapshack/0.2.0+ds1-1

2014-08-06 Thread Jaromír Mikeš
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "qmapshack" * Package name: qmapshack Version : 0.2.0+ds1-1 Upstream Author : Oliver Eichler * URL : https://bitbucket.org/maproom/qmapshack/wiki/Home * License