On Sun, 2014-08-17 at 19:27 +0200, Sebastiaan Couwenberg wrote: > On 08/17/2014 06:35 PM, Jaromír Mikeš wrote: > > I just uploaded new upstream version of qmapshack 0.3.0 to debian mentors. > > This package fixing all previous issues, I would be grateful for reviewing. > > Regarding the copyright file I suggest to use the SPDX license > shortnames as much as possible. > > http://spdx.org/licenses/ > > So instead of "BSD (3 clause)" as used by licensecheck, use BSD-3-Clause > instead. And use the minor numbers for the GPL licenses, so GPL-3.0+ > instead of GPL-3+.
> The copyright-format 1.0 specifies that license names cannot contain > spaces (unless they define exceptions), using the SPDX license names > prevents that. > > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-syntax Yes, it should be BSD-3-Clause. Its sufficient to write GPL-3+, as the copyright-format 1.0 writes: "For SPDX compatibility, versions with trailing dot-zeroes are considered to be equivalent to versions without (e.g., "2.0.0" is considered equal to "2.0" and "2")." (Also used in the examples) > There is also an additional space after the Source field that should be > removed. Jaromír, can you fix those tho minor things and maybe run wrap-and-sort over it. Then ping me... If you want, uploda it to mentors, but I can also work from the git repository) I'll take a look at the package tomorrow morning then... > Kind Regards, > > Bas > > -- > GPG Key ID: 4096R/E88D4AF1 > Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 > > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1408299643.30119.13.ca...@edoras.loewenhoehle.ip
